[stable:linux-5.4.y 1944/3499] drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning: no previous prototype for 'lpfc_defer_acc_rsp'

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4530 bytes --]

Hi James,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git linux-5.4.y
head:   9f4b26f3ea18cb2066c9e58a84ff202c71739a41
commit: a9e53499f4de56277f76ae2d362248a0632a5bc2 [1944/3499] scsi: lpfc: Fix incomplete NVME discovery when target
config: ia64-randconfig-r004-20201125 (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/commit/?id=a9e53499f4de56277f76ae2d362248a0632a5bc2
        git remote add stable https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git
        git fetch --no-tags stable linux-5.4.y
        git checkout a9e53499f4de56277f76ae2d362248a0632a5bc2
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   In file included from arch/ia64/include/asm/pgtable.h:154,
                    from include/linux/mm.h:99,
                    from include/linux/bvec.h:13,
                    from include/linux/blk_types.h:10,
                    from include/linux/genhd.h:19,
                    from include/linux/blkdev.h:11,
                    from drivers/scsi/lpfc/lpfc_nportdisc.c:24:
   arch/ia64/include/asm/mmu_context.h: In function 'reload_context':
   arch/ia64/include/asm/mmu_context.h:137:41: warning: variable 'old_rr4' set but not used [-Wunused-but-set-variable]
     137 |  unsigned long rr0, rr1, rr2, rr3, rr4, old_rr4;
         |                                         ^~~~~~~
   drivers/scsi/lpfc/lpfc_nportdisc.c: At top level:
   drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: no previous prototype for 'lpfc_defer_pt2pt_acc' [-Wmissing-prototypes]
     290 | lpfc_defer_pt2pt_acc(struct lpfc_hba *phba, LPFC_MBOXQ_t *link_mbox)
         | ^~~~~~~~~~~~~~~~~~~~
>> drivers/scsi/lpfc/lpfc_nportdisc.c:344:1: warning: no previous prototype for 'lpfc_defer_acc_rsp' [-Wmissing-prototypes]
     344 | lpfc_defer_acc_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
         | ^~~~~~~~~~~~~~~~~~

vim +/lpfc_defer_acc_rsp +344 drivers/scsi/lpfc/lpfc_nportdisc.c

   330	
   331	/**
   332	 * lpfc_defer_tgt_acc - Progress SLI4 target rcv PLOGI handler
   333	 * @phba: Pointer to HBA context object.
   334	 * @pmb: Pointer to mailbox object.
   335	 *
   336	 * This function provides the unreg rpi mailbox completion handler for a tgt.
   337	 * The routine frees the memory resources associated with the completed
   338	 * mailbox command and transmits the ELS ACC.
   339	 *
   340	 * This routine is only called if we are SLI4, acting in target
   341	 * mode and the remote NPort issues the PLOGI after link up.
   342	 **/
   343	void
 > 344	lpfc_defer_acc_rsp(struct lpfc_hba *phba, LPFC_MBOXQ_t *pmb)
   345	{
   346		struct lpfc_vport *vport = pmb->vport;
   347		struct lpfc_nodelist *ndlp = pmb->ctx_ndlp;
   348		LPFC_MBOXQ_t *mbox = pmb->context3;
   349		struct lpfc_iocbq *piocb = NULL;
   350		int rc;
   351	
   352		if (mbox) {
   353			pmb->context3 = NULL;
   354			piocb = mbox->context3;
   355			mbox->context3 = NULL;
   356		}
   357	
   358		/*
   359		 * Complete the unreg rpi mbx request, and update flags.
   360		 * This will also restart any deferred events.
   361		 */
   362		lpfc_nlp_get(ndlp);
   363		lpfc_sli4_unreg_rpi_cmpl_clr(phba, pmb);
   364	
   365		if (!piocb) {
   366			lpfc_printf_vlog(vport, KERN_ERR, LOG_DISCOVERY | LOG_ELS,
   367					 "4578 PLOGI ACC fail\n");
   368			if (mbox)
   369				mempool_free(mbox, phba->mbox_mem_pool);
   370			goto out;
   371		}
   372	
   373		rc = lpfc_els_rsp_acc(vport, ELS_CMD_PLOGI, piocb, ndlp, mbox);
   374		if (rc) {
   375			lpfc_printf_vlog(vport, KERN_ERR, LOG_DISCOVERY | LOG_ELS,
   376					 "4579 PLOGI ACC fail %x\n", rc);
   377			if (mbox)
   378				mempool_free(mbox, phba->mbox_mem_pool);
   379		}
   380		kfree(piocb);
   381	out:
   382		lpfc_nlp_put(ndlp);
   383	}
   384	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 30493 bytes --]