From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA3FC56202 for ; Thu, 26 Nov 2020 08:08:51 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7EAA720B80 for ; Thu, 26 Nov 2020 08:08:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T3MIXEOw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7EAA720B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IS86vpjpwYChtRCOp1xJx9jIIFQ8B2wel1mRsJiRAV0=; b=T3MIXEOwPOyFiyaRrTXbXHtGu oGf6y1bFsvyvtF+c2LfGrj/hrdFLQSTo2tl0MtrIT++Q2UOIwZ6IjK6euBTZarzZeuKE2uADMBSyS X62wuoR4L52nyFTpGFp/7IQOnlLTP85Uzm7go2rGe5hj1WVKvlOuK82NhsdviWAKaUSCa5qCD39MN AHqVjd8kKd5VqElXaBFa0uKyfvxmVCSgE7clztpw6Oi8sdQDWvdI3qMh9iiI1YAVJA3NTkGoWDATA 3DMwF9tR7CNXeHkE+g87C4MUivr6EQYRfoHRSqtVZ1u40nRc33zQVq+nDKv9T+Byj5lC1kJ8XQuOR Myykd2e1Q==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiCJF-0006QZ-7z; Thu, 26 Nov 2020 08:07:21 +0000 Received: from mail-wr1-f66.google.com ([209.85.221.66]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiCJ7-0006Oq-Q2 for linux-arm-kernel@lists.infradead.org; Thu, 26 Nov 2020 08:07:15 +0000 Received: by mail-wr1-f66.google.com with SMTP id z7so1115886wrn.3 for ; Thu, 26 Nov 2020 00:07:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a3ZeRES82glp/ESVkrw8r5rJKHDjdPhl9dQN3iqL2dM=; b=oXntBuslqSWL+nXdVOGdCzRGomJX2jzwnZ3yl4VV812PY6A25Vwpy4aIa9B7K8voLK VyHpOvWtD6WDObVsqiGVfls4u14cGBIa7xSDad9r3a8yghOkDgIiISu4UZQ9CKi/jU5X LTL0q+7onxgzyynrHi8Ymd2YnII7gsAye+VajuK4HUSiVKkLO+bzpHA/DUOhz+NC/QNb 9Ejv+v8UcDOJH1Hj0sLoyXo3mSkhkneE5BTkdr3U3mLGIpmHEvK0IDu70kkcWs/MYLhB 1rYRxPQ29TQkQMwkDKkU/4rXsL3DD9JX/IjX5csmWArF5gl8EjsGGGP2AWXQ4G8K3+ju A4VQ== X-Gm-Message-State: AOAM533+GPzjlFUoalvEo4wplX6kmjmoPvj0mkecQtp/N4pTcHULMogX dYPoPTfa2138/3WSHe12bJs= X-Google-Smtp-Source: ABdhPJzyyzAo4v01XsEoV1VcmfHcNIMsy/fn3brXPQpnEXdBAUrXd3alDnXOmWESuFAJBfNnypZndA== X-Received: by 2002:a5d:688b:: with SMTP id h11mr2187850wru.417.1606378032000; Thu, 26 Nov 2020 00:07:12 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id h20sm7287786wmb.29.2020.11.26.00.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 00:07:10 -0800 (PST) Date: Thu, 26 Nov 2020 09:07:08 +0100 From: Krzysztof Kozlowski To: Adam Ford Subject: Re: [PATCH 2/2] arm64: dts: imx8mm-beacon-som: Fix PMIC clock error Message-ID: <20201126080708.GB4347@kozik-lap> References: <20201125210339.1071419-1-aford173@gmail.com> <20201125210339.1071419-2-aford173@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201125210339.1071419-2-aford173@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_030714_063340_CBAE28DC X-CRM114-Status: GOOD ( 16.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Fabio Estevam , Sascha Hauer , aford@beaconembedded.com, linux-kernel@vger.kernel.org, Rob Herring , NXP Linux Team , Pengutronix Kernel Team , Shawn Guo , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 25, 2020 at 03:03:39PM -0600, Adam Ford wrote: > The PMIC throws an errors because the clock isn't assigned to it. > Fix this by assigning the clocks info. > > Fixes: acb01032e11a ("arm64: defconfig: Enable clock driver for ROHM BD718x7 PMIC") Hi, This is not the correct Fixes tag. The defconfig change did not introduce any bug in DTS. The error message was there before, regardless of defconfigs. Defconfigs are merely a development or distro aid, not a definition of working state. If it really was a bug, then the commit adding DTS is to blame. Second, I am not sure if there is a bug here to fix - having incomplete DTS is a bug? Missing device nodes in DTS is a bug? Also, pay attention to proper white spaces. There is only single whitespace after ':' and no blank line after entire Fixes tag. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B0BBC56202 for ; Thu, 26 Nov 2020 08:07:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B1C3A20DD4 for ; Thu, 26 Nov 2020 08:07:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388633AbgKZIHO (ORCPT ); Thu, 26 Nov 2020 03:07:14 -0500 Received: from mail-wr1-f68.google.com ([209.85.221.68]:43780 "EHLO mail-wr1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731457AbgKZIHO (ORCPT ); Thu, 26 Nov 2020 03:07:14 -0500 Received: by mail-wr1-f68.google.com with SMTP id s8so1088423wrw.10; Thu, 26 Nov 2020 00:07:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=a3ZeRES82glp/ESVkrw8r5rJKHDjdPhl9dQN3iqL2dM=; b=PE9uR1uCEYn8e7Raid/M7fHYw9L0bT9ROYl6DlTPJJR4V+S2U6ojz0WgKPwcUcuNZ7 dpXdP8R8U2WyqlyxHT2eMVY/uzKIqG0sb9ERMdzYP20rbvsJiM7RzeYEjsGKKxcPTx+t 1aogxaXlSKkLTDpXNUD4Jz748lA0PV7TnUuq5cTpBvd9CmI7MouShiE9qr2j0XnIgzxt ucDEbXJnKjTuRGU8V89oWGA80iGBGfjnCstvNXY+J08r5aN3T7pRR6ayObXHNBlu9TdJ UL+TVlYwhkNJK7fKr4zKDTjkEkksY1CWISKIh5zK2ejGR5QLXgIY/5bEfZkBAa3q5Yh/ GbbQ== X-Gm-Message-State: AOAM532DmH6SJbcWid0tk022tbevvChXnq7klss+HyErDS7I3KvlVXw/ kA0w0I3CIUJMQEwW+xjXO3s= X-Google-Smtp-Source: ABdhPJzyyzAo4v01XsEoV1VcmfHcNIMsy/fn3brXPQpnEXdBAUrXd3alDnXOmWESuFAJBfNnypZndA== X-Received: by 2002:a5d:688b:: with SMTP id h11mr2187850wru.417.1606378032000; Thu, 26 Nov 2020 00:07:12 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id h20sm7287786wmb.29.2020.11.26.00.07.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Nov 2020 00:07:10 -0800 (PST) Date: Thu, 26 Nov 2020 09:07:08 +0100 From: Krzysztof Kozlowski To: Adam Ford Cc: linux-arm-kernel@lists.infradead.org, aford@beaconembedded.com, Rob Herring , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] arm64: dts: imx8mm-beacon-som: Fix PMIC clock error Message-ID: <20201126080708.GB4347@kozik-lap> References: <20201125210339.1071419-1-aford173@gmail.com> <20201125210339.1071419-2-aford173@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20201125210339.1071419-2-aford173@gmail.com> Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Wed, Nov 25, 2020 at 03:03:39PM -0600, Adam Ford wrote: > The PMIC throws an errors because the clock isn't assigned to it. > Fix this by assigning the clocks info. > > Fixes: acb01032e11a ("arm64: defconfig: Enable clock driver for ROHM BD718x7 PMIC") Hi, This is not the correct Fixes tag. The defconfig change did not introduce any bug in DTS. The error message was there before, regardless of defconfigs. Defconfigs are merely a development or distro aid, not a definition of working state. If it really was a bug, then the commit adding DTS is to blame. Second, I am not sure if there is a bug here to fix - having incomplete DTS is a bug? Missing device nodes in DTS is a bug? Also, pay attention to proper white spaces. There is only single whitespace after ':' and no blank line after entire Fixes tag. Best regards, Krzysztof