From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 430C5C6379D for ; Thu, 26 Nov 2020 10:00:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EC0C2221FD for ; Thu, 26 Nov 2020 10:00:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387509AbgKZJ7y (ORCPT ); Thu, 26 Nov 2020 04:59:54 -0500 Received: from verein.lst.de ([213.95.11.211]:33730 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387493AbgKZJ7x (ORCPT ); Thu, 26 Nov 2020 04:59:53 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id 9883168B02; Thu, 26 Nov 2020 10:59:48 +0100 (CET) Date: Thu, 26 Nov 2020 10:59:48 +0100 From: Christoph Hellwig To: Minchan Kim Cc: Christoph Hellwig , Jens Axboe , Justin Sanders , Josef Bacik , Ilya Dryomov , Jack Wang , "Michael S. Tsirkin" , Jason Wang , Paolo Bonzini , Stefan Hajnoczi , Konrad Rzeszutek Wilk , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Mike Snitzer , Song Liu , "Martin K. Petersen" , dm-devel@redhat.com, linux-block@vger.kernel.org, drbd-dev@lists.linbit.com, nbd@other.debian.org, ceph-devel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-raid@vger.kernel.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, Sergey Senozhatsky Subject: Re: [PATCH 60/78] zram: remove the claim mechanism Message-ID: <20201126095948.GA24035@lst.de> References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-61-hch@lst.de> <20201126011107.GA57352@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126011107.GA57352@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: ceph-devel@vger.kernel.org On Wed, Nov 25, 2020 at 05:11:07PM -0800, Minchan Kim wrote: > With this patch, how deal with the race? > > CPU 1 CPU 2 > > hot_remove_store > zram_remove > zram_busy > return -EBUSY > open /dev/zram0 > del_gendisk > zram_reset and destroy Yeah, it looks like zram does not really handle hot unplugging unlike other drivers. So I've dropped this one for now. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32887C63777 for ; Thu, 26 Nov 2020 10:00:21 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 68FD32145D for ; Thu, 26 Nov 2020 10:00:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 68FD32145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-408-5iRgsJ_4O7O_MoUfmk5H8w-1; Thu, 26 Nov 2020 05:00:15 -0500 X-MC-Unique: 5iRgsJ_4O7O_MoUfmk5H8w-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 839D280B721; Thu, 26 Nov 2020 10:00:10 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 9F5665B4A0; Thu, 26 Nov 2020 10:00:09 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id A9DEC4A7C6; Thu, 26 Nov 2020 10:00:03 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AQA01Nh017304 for ; Thu, 26 Nov 2020 05:00:01 -0500 Received: by smtp.corp.redhat.com (Postfix) id EFAC3B5503; Thu, 26 Nov 2020 10:00:00 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast01.extmail.prod.ext.rdu2.redhat.com [10.11.55.17]) by smtp.corp.redhat.com (Postfix) with ESMTPS id E84A29D484 for ; Thu, 26 Nov 2020 09:59:58 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 7FD6785828A for ; Thu, 26 Nov 2020 09:59:58 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-550-SoZiHk8oMDS5yJQBYNUMxQ-1; Thu, 26 Nov 2020 04:59:53 -0500 X-MC-Unique: SoZiHk8oMDS5yJQBYNUMxQ-1 Received: by verein.lst.de (Postfix, from userid 2407) id 9883168B02; Thu, 26 Nov 2020 10:59:48 +0100 (CET) Date: Thu, 26 Nov 2020 10:59:48 +0100 From: Christoph Hellwig To: Minchan Kim Message-ID: <20201126095948.GA24035@lst.de> References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-61-hch@lst.de> <20201126011107.GA57352@google.com> MIME-Version: 1.0 In-Reply-To: <20201126011107.GA57352@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-loop: dm-devel@redhat.com Cc: Justin Sanders , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, Christoph Hellwig , linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , drbd-dev@tron.linbit.com, ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , Sergey Senozhatsky , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [dm-devel] [PATCH 60/78] zram: remove the claim mechanism X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Wed, Nov 25, 2020 at 05:11:07PM -0800, Minchan Kim wrote: > With this patch, how deal with the race? > > CPU 1 CPU 2 > > hot_remove_store > zram_remove > zram_busy > return -EBUSY > open /dev/zram0 > del_gendisk > zram_reset and destroy Yeah, it looks like zram does not really handle hot unplugging unlike other drivers. So I've dropped this one for now. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E13D1C56202 for ; Thu, 26 Nov 2020 10:00:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 309292145D for ; Thu, 26 Nov 2020 10:00:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2FQlrAlV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 309292145D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=L8VdLb0NBkrXPMLMV4UNnBYarsR7FrD6qRUm49QGDwI=; b=2FQlrAlVyXc1xZITRkFbi2NDO gUG5QUoxXPy5JGUbD/SGbe30wrj9maHkO8Qh9I6Q+bqij9xkAnXDNmEkn+HfbKO8vr3kpYv1T2NfS y/1Ddkh5z9H0T/EN1KQtsQD77bqbmcqpTgU11y5MG2akdvSwJ67tUTdAZGtAYfjNAZPEf8KG4tsJw bQkP/Rs3pGyvAmQJznmzeihXi3ugiUeqI3BuInnR9l6ihT2K0hALS9fuZRdNHlVl87wPNJy+YSB+w Hra2uOlXsUEq/d9RR8/dw5ZcomWJpUbxj09LgKC0MYIxASIsrLn5rbQ1NLWMDKI4v3kdHKTU6IYXt dkhH42RYw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiE4G-000077-VI; Thu, 26 Nov 2020 10:00:01 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiE4C-000064-8B for linux-nvme@lists.infradead.org; Thu, 26 Nov 2020 09:59:57 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 9883168B02; Thu, 26 Nov 2020 10:59:48 +0100 (CET) Date: Thu, 26 Nov 2020 10:59:48 +0100 From: Christoph Hellwig To: Minchan Kim Subject: Re: [PATCH 60/78] zram: remove the claim mechanism Message-ID: <20201126095948.GA24035@lst.de> References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-61-hch@lst.de> <20201126011107.GA57352@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126011107.GA57352@google.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_045956_470463_10B62D1D X-CRM114-Status: GOOD ( 10.73 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Justin Sanders , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, Christoph Hellwig , drbd-dev@lists.linbit.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , Sergey Senozhatsky , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Roger Pau =?iso-8859-1?Q?Monn=E9?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Nov 25, 2020 at 05:11:07PM -0800, Minchan Kim wrote: > With this patch, how deal with the race? > > CPU 1 CPU 2 > > hot_remove_store > zram_remove > zram_busy > return -EBUSY > open /dev/zram0 > del_gendisk > zram_reset and destroy Yeah, it looks like zram does not really handle hot unplugging unlike other drivers. So I've dropped this one for now. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by mail19.linbit.com (LINBIT Mail Daemon) with ESMTP id 3DEFD420634 for ; Thu, 26 Nov 2020 10:59:50 +0100 (CET) Date: Thu, 26 Nov 2020 10:59:48 +0100 From: Christoph Hellwig To: Minchan Kim Message-ID: <20201126095948.GA24035@lst.de> References: <20201116145809.410558-1-hch@lst.de> <20201116145809.410558-61-hch@lst.de> <20201126011107.GA57352@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126011107.GA57352@google.com> Cc: Justin Sanders , Mike Snitzer , "Michael S. Tsirkin" , Jason Wang , linux-nvme@lists.infradead.org, Song Liu , dm-devel@redhat.com, Christoph Hellwig , drbd-dev@lists.linbit.com, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, Ilya Dryomov , Jack Wang , Konrad Rzeszutek Wilk , Josef Bacik , nbd@other.debian.org, linux-raid@vger.kernel.org, Stefan Hajnoczi , ceph-devel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org, "Martin K. Petersen" , Sergey Senozhatsky , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Roger Pau =?iso-8859-1?Q?Monn=E9?= Subject: Re: [Drbd-dev] [PATCH 60/78] zram: remove the claim mechanism List-Id: "*Coordination* of development, patches, contributions -- *Questions* \(even to developers\) go to drbd-user, please." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Nov 25, 2020 at 05:11:07PM -0800, Minchan Kim wrote: > With this patch, how deal with the race? > > CPU 1 CPU 2 > > hot_remove_store > zram_remove > zram_busy > return -EBUSY > open /dev/zram0 > del_gendisk > zram_reset and destroy Yeah, it looks like zram does not really handle hot unplugging unlike other drivers. So I've dropped this one for now.