From: Lukas Wunner <lukas@wunner.de>
To: Qing Zhang <zhangqing@loongson.cn>
Cc: "Mark Brown" <broonie@kernel.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
linux-spi@vger.kernel.org, "Huacai Chen" <chenhc@lemote.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
devicetree@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Krzysztof Kozlowski" <krzk@kernel.org>
Subject: Re: [PATCH 1/3] spi: Loongson: Add Loongson 3A+7A SPI controller driver support
Date: Thu, 26 Nov 2020 12:58:38 +0100 [thread overview]
Message-ID: <20201126115838.GA29170@wunner.de> (raw)
In-Reply-To: <1606123148-315-1-git-send-email-zhangqing@loongson.cn>
On Mon, Nov 23, 2020 at 05:19:06PM +0800, Qing Zhang wrote:
> +static struct platform_device loongson_spi_device = {
> + .name = "loongson-spi",
> + .id = 0,
> + .num_resources = ARRAY_SIZE(loongson_spi_resources),
> + .resource = loongson_spi_resources,
> +};
Why isn't this struct allocated at runtime?
> + if (ret == PCIBIOS_SUCCESSFUL) {
> + loongson_spi_resources[1].start = v8;
> + loongson_spi_resources[1].end = v8;
> + platform_device_register(&loongson_spi_device);
> + }
> +
> +err_out:
> + return ret;
> +}
> +
> +static void loongson_spi_pci_unregister(struct pci_dev *pdev)
> +{
> + pci_release_region(pdev, 0);
> +}
Seems like platform_device_unregister() is missing here.
Thanks,
Lukas
prev parent reply other threads:[~2020-11-26 12:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 9:19 [PATCH 1/3] spi: Loongson: Add Loongson 3A+7A SPI controller driver support Qing Zhang
2020-11-23 9:19 ` [PATCH 2/3] MIPS: Loongson64: DTS: Add SPI support to LS3A Qing Zhang
2020-11-23 10:48 ` Jiaxun Yang
2020-11-23 9:19 ` [PATCH 3/3] MIPS: Loongson: Enable Loongson SPI in loongson3_defconfig Qing Zhang
2020-11-23 13:10 ` [PATCH 1/3] spi: Loongson: Add Loongson 3A+7A SPI controller driver support Mark Brown
2020-11-24 1:54 ` zhangqing
2020-11-26 11:58 ` Lukas Wunner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201126115838.GA29170@wunner.de \
--to=lukas@wunner.de \
--cc=broonie@kernel.org \
--cc=chenhc@lemote.com \
--cc=devicetree@vger.kernel.org \
--cc=ebiederm@xmission.com \
--cc=f4bug@amsat.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=tsbogend@alpha.franken.de \
--cc=zhangqing@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.