All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
	linux-arm-kernel@lists.infradead.org, kasan-dev@googlegroups.com,
	linux-kernel@vger.kernel.org
Subject: Re: linux-next 20201126 - build error on arm allmodconfig
Date: Thu, 26 Nov 2020 14:32:40 +0000	[thread overview]
Message-ID: <20201126143239.GM1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <28070.1606400573@turing-police>

On Thu, Nov 26, 2020 at 09:22:53AM -0500, Valdis Klētnieks wrote:
> On Thu, 26 Nov 2020 14:14:29 +0000, Russell King - ARM Linux admin said:
> 
> > The real answer is for asm/kasan.h to include linux/linkage.h
> 
> Looking deeper, there's  7 different arch/../asm/kasan.h - are we better off
> patching all 7, or having include/linux/kasan.h include it just before
> the include of asm/kasan.h?

I wouldn't like to say definitively - it depends on what the policy
now is. However, linux/linage.h is way cheaper than linux/pgtable.h
so it probably makes sense for linux/kasan.h to include it given the
number of asm/kasan.h headers needing it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: "Valdis Klētnieks" <valdis.kletnieks@vt.edu>
Cc: Andrey Ryabinin <aryabinin@virtuozzo.com>,
	kasan-dev@googlegroups.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: linux-next 20201126 - build error on arm allmodconfig
Date: Thu, 26 Nov 2020 14:32:40 +0000	[thread overview]
Message-ID: <20201126143239.GM1551@shell.armlinux.org.uk> (raw)
In-Reply-To: <28070.1606400573@turing-police>

On Thu, Nov 26, 2020 at 09:22:53AM -0500, Valdis Klētnieks wrote:
> On Thu, 26 Nov 2020 14:14:29 +0000, Russell King - ARM Linux admin said:
> 
> > The real answer is for asm/kasan.h to include linux/linkage.h
> 
> Looking deeper, there's  7 different arch/../asm/kasan.h - are we better off
> patching all 7, or having include/linux/kasan.h include it just before
> the include of asm/kasan.h?

I wouldn't like to say definitively - it depends on what the policy
now is. However, linux/linage.h is way cheaper than linux/pgtable.h
so it probably makes sense for linux/kasan.h to include it given the
number of asm/kasan.h headers needing it.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

  reply	other threads:[~2020-11-26 14:34 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-26 13:25 linux-next 20201126 - build error on arm allmodconfig Valdis Klētnieks
2020-11-26 13:25 ` Valdis Klētnieks
2020-11-26 14:14 ` Russell King - ARM Linux admin
2020-11-26 14:14   ` Russell King - ARM Linux admin
2020-11-26 14:18   ` Valdis Klētnieks
2020-11-26 14:18     ` Valdis Klētnieks
2020-11-26 14:22   ` Valdis Klētnieks
2020-11-26 14:22     ` Valdis Klētnieks
2020-11-26 14:32     ` Russell King - ARM Linux admin [this message]
2020-11-26 14:32       ` Russell King - ARM Linux admin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201126143239.GM1551@shell.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=aryabinin@virtuozzo.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=valdis.kletnieks@vt.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.