From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61871C56202 for ; Thu, 26 Nov 2020 18:03:03 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B70CC207BC for ; Thu, 26 Nov 2020 18:03:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B70CC207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-476-CkUPIOINN2uKQc99WDOWbA-1; Thu, 26 Nov 2020 13:02:59 -0500 X-MC-Unique: CkUPIOINN2uKQc99WDOWbA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 0032D1842158; Thu, 26 Nov 2020 18:02:55 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.21]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AA7B75D6D1; Thu, 26 Nov 2020 18:02:54 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 7DAB14BB7B; Thu, 26 Nov 2020 18:02:54 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 0AQI2WAL002805 for ; Thu, 26 Nov 2020 13:02:32 -0500 Received: by smtp.corp.redhat.com (Postfix) id 74AEC112D407; Thu, 26 Nov 2020 18:02:32 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast03.extmail.prod.ext.rdu2.redhat.com [10.11.55.19]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 70E69112D406 for ; Thu, 26 Nov 2020 18:02:29 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 478CF811E78 for ; Thu, 26 Nov 2020 18:02:29 +0000 (UTC) Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-382-ZbSDNneoOUub-xIhNLxx2g-1; Thu, 26 Nov 2020 13:02:26 -0500 X-MC-Unique: ZbSDNneoOUub-xIhNLxx2g-1 Received: by verein.lst.de (Postfix, from userid 2407) id B348768B05; Thu, 26 Nov 2020 19:02:23 +0100 (CET) Date: Thu, 26 Nov 2020 19:02:23 +0100 From: Christoph Hellwig To: Jan Kara Message-ID: <20201126180223.GA25921@lst.de> References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-37-hch@lst.de> <20201126173518.GV422@quack2.suse.cz> <20201126180048.GA422@quack2.suse.cz> MIME-Version: 1.0 In-Reply-To: <20201126180048.GA422@quack2.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.3 X-loop: dm-devel@redhat.com Cc: Jens Axboe , Mike Snitzer , linux-mm@kvack.org, Greg Kroah-Hartman , Jan Kara , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , Tejun Heo , linux-bcache@vger.kernel.org, Christoph Hellwig Subject: Re: [dm-devel] [PATCH 36/44] block: allocate struct hd_struct as part of struct bdev_inode X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Thu, Nov 26, 2020 at 07:00:48PM +0100, Jan Kara wrote: > > I don't think hd_struct holds a reference to block_device, does it? > > bdev_alloc() now just assigns bdev->bd_part->bdev = bdev... > > Now I understood this is probably correct - each partition (including > gendisk as 0 partition) holds the initial bdev reference and only when > corresponding kobject is getting destroyed we stop holding onto that > reference. Right? Yes. -- dm-devel mailing list dm-devel@redhat.com https://www.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A84F5C56202 for ; Thu, 26 Nov 2020 18:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5EC0F207BC for ; Thu, 26 Nov 2020 18:02:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403901AbgKZSC2 (ORCPT ); Thu, 26 Nov 2020 13:02:28 -0500 Received: from verein.lst.de ([213.95.11.211]:35314 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2391698AbgKZSC1 (ORCPT ); Thu, 26 Nov 2020 13:02:27 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id B348768B05; Thu, 26 Nov 2020 19:02:23 +0100 (CET) Date: Thu, 26 Nov 2020 19:02:23 +0100 From: Christoph Hellwig To: Jan Kara Cc: Christoph Hellwig , Jens Axboe , Tejun Heo , Josef Bacik , Coly Li , Mike Snitzer , Greg Kroah-Hartman , Johannes Thumshirn , dm-devel@redhat.com, Jan Kara , linux-block@vger.kernel.org, linux-bcache@vger.kernel.org, linux-mtd@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 36/44] block: allocate struct hd_struct as part of struct bdev_inode Message-ID: <20201126180223.GA25921@lst.de> References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-37-hch@lst.de> <20201126173518.GV422@quack2.suse.cz> <20201126180048.GA422@quack2.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201126180048.GA422@quack2.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-bcache@vger.kernel.org On Thu, Nov 26, 2020 at 07:00:48PM +0100, Jan Kara wrote: > > I don't think hd_struct holds a reference to block_device, does it? > > bdev_alloc() now just assigns bdev->bd_part->bdev = bdev... > > Now I understood this is probably correct - each partition (including > gendisk as 0 partition) holds the initial bdev reference and only when > corresponding kobject is getting destroyed we stop holding onto that > reference. Right? Yes. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E51A5C63697 for ; Thu, 26 Nov 2020 18:03:37 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 93B3A207BC for ; Thu, 26 Nov 2020 18:03:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="EdEQ9EYn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 93B3A207BC Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8VxicVgKtIF2HlSWQT5DPKVWhYDkRrm2OkjGx/tgaRI=; b=EdEQ9EYn8+uLR7UMhUMRy3JBY l2hCTLLdCypC90Z6xNbq1WzBbM2pbXKgoHgmE2jTlnSSDIXeV87NRlkNpyob8y0M8l1BMEv8QjXpt lwyuEojZiBeoCVVNrLUZcRvC0D5WN79nQYC7QyeWIS+gQYNkkQVVUrX3Iq20qaIytn+7CSn8aLFs9 wpWdrJpLbPBWsccvU/IuIHWRVxV96DZ4SLb+VeA5SXHOZG+6C4h6TLZaup36NV7xZFshZkuDMes7U JLwbE8wsQNbXv2/xXOagLUF+e9fdWLTbjRfMUEC9nq9YCMG7ZIMtcqH1GSn4Yf6Yd+LcmF55Nd+2P 3cVCDnnew==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiLbA-0005OB-UW; Thu, 26 Nov 2020 18:02:28 +0000 Received: from verein.lst.de ([213.95.11.211]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiLb8-0005N4-KG for linux-mtd@lists.infradead.org; Thu, 26 Nov 2020 18:02:27 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B348768B05; Thu, 26 Nov 2020 19:02:23 +0100 (CET) Date: Thu, 26 Nov 2020 19:02:23 +0100 From: Christoph Hellwig To: Jan Kara Subject: Re: [PATCH 36/44] block: allocate struct hd_struct as part of struct bdev_inode Message-ID: <20201126180223.GA25921@lst.de> References: <20201126130422.92945-1-hch@lst.de> <20201126130422.92945-37-hch@lst.de> <20201126173518.GV422@quack2.suse.cz> <20201126180048.GA422@quack2.suse.cz> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201126180048.GA422@quack2.suse.cz> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201126_130226_777250_F68BCB4E X-CRM114-Status: GOOD ( 10.69 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jens Axboe , Mike Snitzer , linux-mm@kvack.org, Greg Kroah-Hartman , Jan Kara , Josef Bacik , Coly Li , linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, dm-devel@redhat.com, linux-mtd@lists.infradead.org, Johannes Thumshirn , Tejun Heo , linux-bcache@vger.kernel.org, Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Thu, Nov 26, 2020 at 07:00:48PM +0100, Jan Kara wrote: > > I don't think hd_struct holds a reference to block_device, does it? > > bdev_alloc() now just assigns bdev->bd_part->bdev = bdev... > > Now I understood this is probably correct - each partition (including > gendisk as 0 partition) holds the initial bdev reference and only when > corresponding kobject is getting destroyed we stop holding onto that > reference. Right? Yes. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/