From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kic2s-0001IW-HM for mharc-qemu-riscv@gnu.org; Fri, 27 Nov 2020 06:36:10 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44340) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kic2r-0001HI-Kr for qemu-riscv@nongnu.org; Fri, 27 Nov 2020 06:36:09 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23344) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kic2n-0001Wp-Bp for qemu-riscv@nongnu.org; Fri, 27 Nov 2020 06:36:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606476964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=14aEWzZrDPF7XWUDksGeOC7vvrJ7oGa+7SJaCTLJz8o=; b=IGFiD1CXP5uAWc7Kzj1SdF7BYeBwAAjclSS9tIpf8jmyAixy/B79zBdcEP6xMNJnjd70yB IDeQop0XVyenRqYP6VSa4ezYZPXBbPhXr9moU5BDDVwvYSfxOR7Cahhur3/1PKap0EO6mG 3CE45cg4XRFVMmmsnX+GGd6qPFuvAGA= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-pbiAshTNPIW_4tnfi4fxTA-1; Fri, 27 Nov 2020 06:36:00 -0500 X-MC-Unique: pbiAshTNPIW_4tnfi4fxTA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 760209A22A; Fri, 27 Nov 2020 11:35:55 +0000 (UTC) Received: from gondolin (ovpn-113-65.ams2.redhat.com [10.36.113.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5BB875D720; Fri, 27 Nov 2020 11:35:36 +0000 (UTC) Date: Fri, 27 Nov 2020 12:35:33 +0100 From: Cornelia Huck To: Eduardo Habkost Cc: qemu-devel@nongnu.org, Gerd Hoffmann , Thomas Huth , Richard Henderson , Peter Maydell , Michael Rolnik , Sarah Harris , "Edgar E. Iglesias" , Paolo Bonzini , Michael Walle , Laurent Vivier , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Aurelien Jarno , Jiaxun Yang , Aleksandar Rikalo , Anthony Green , Chris Wulff , Marek Vasut , Stafford Horne , David Gibson , Palmer Dabbelt , Alistair Francis , Sagar Karandikar , Bastian Koppelmann , Yoshinori Sato , David Hildenbrand , Mark Cave-Ayland , Artyom Tarasenko , Guan Xuetao , Max Filippov , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org, qemu-s390x@nongnu.org Subject: Re: [PATCH v2 1/6] arch_init: Move QEMU_ARCH definitions to cpu.h Message-ID: <20201127123533.3707edf5.cohuck@redhat.com> In-Reply-To: <20201125205636.3305257-2-ehabkost@redhat.com> References: <20201125205636.3305257-1-ehabkost@redhat.com> <20201125205636.3305257-2-ehabkost@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 11:36:09 -0000 On Wed, 25 Nov 2020 15:56:31 -0500 Eduardo Habkost wrote: > Instead of a collection of #ifdefs on arch_init.c, define > QEMU_ARCH inside each cpu.h file. >=20 > Signed-off-by: Eduardo Habkost > --- > Cc: Richard Henderson > Cc: Peter Maydell > Cc: Michael Rolnik > Cc: Sarah Harris > Cc: "Edgar E. Iglesias" > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Cc: Michael Walle > Cc: Laurent Vivier > Cc: "Philippe Mathieu-Daud=C3=A9" > Cc: Aurelien Jarno > Cc: Jiaxun Yang > Cc: Aleksandar Rikalo > Cc: Anthony Green > Cc: Chris Wulff > Cc: Marek Vasut > Cc: Stafford Horne > Cc: David Gibson > Cc: Palmer Dabbelt > Cc: Alistair Francis > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Yoshinori Sato > Cc: David Hildenbrand > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > Cc: Guan Xuetao > Cc: Max Filippov > Cc: qemu-devel@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-ppc@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-s390x@nongnu.org > --- > target/alpha/cpu.h | 1 + > target/arm/cpu.h | 1 + > target/avr/cpu.h | 1 + > target/cris/cpu.h | 1 + > target/hppa/cpu.h | 1 + > target/i386/cpu.h | 1 + > target/lm32/cpu.h | 1 + > target/m68k/cpu.h | 1 + > target/microblaze/cpu.h | 1 + > target/mips/cpu.h | 1 + > target/moxie/cpu.h | 1 + > target/nios2/cpu.h | 1 + > target/openrisc/cpu.h | 1 + > target/ppc/cpu.h | 1 + > target/riscv/cpu.h | 1 + > target/rx/cpu.h | 1 + > target/s390x/cpu.h | 1 + > target/sh4/cpu.h | 1 + > target/sparc/cpu.h | 1 + > target/tricore/cpu.h | 1 + > target/unicore32/cpu.h | 1 + > target/xtensa/cpu.h | 1 + > softmmu/arch_init.c | 46 ----------------------------------------- > 23 files changed, 22 insertions(+), 46 deletions(-) Much better :) Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a19:ee0a:0:0:0:0:0 with SMTP id g10csp2290819lfb; Fri, 27 Nov 2020 03:36:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXJ3RGOKuJUOsdw065kyeNhGrayzBintMQUwR4HbxGbv+OG1dIF9T+BA4FqbW5NS7LcWPa X-Received: by 2002:a25:d04b:: with SMTP id h72mr10818707ybg.523.1606476978517; Fri, 27 Nov 2020 03:36:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1606476978; cv=none; d=google.com; s=arc-20160816; b=EYjFwaxfcyAEc4ev7mnZIN7PuAggVsGr+Tjh32FV9QpxAWC7dEGr76LFTxSI4uTnfh gQKSfsE1cA0+Q5+g6fkIdGnA7NKqBJGr9pqGMHznXnVQcwmAnY2Ih69n/3eKryCAR6pE pvsBYG1aB1rML5B3NgE20iwucH2hYyJYTkl17/HEAHD85hg8++DHqjVLrMbCzieci06I GCNRVqgAJFGyy31Z0/XKqDjVEimSCJotjjCm5RBWubZ3kh3BcsaTnR0B0eGbQlRiBh13 2LJcwTzqTmODZ0e7f/o+TSo+PcS05Bs0LIje2A1MQZlXOzi21dheX2hY7dbwKcdQvY/n k8YA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:cc:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:organization:references:in-reply-to:message-id:subject :to:from:date:dkim-signature; bh=14aEWzZrDPF7XWUDksGeOC7vvrJ7oGa+7SJaCTLJz8o=; b=GlutsrGQUlslODUB2u+LYbtpavpLLoAEL1BN25VuIoWFF+v/i2HOD8yAynhnjpmh+6 pHtttRoSw67abGihAm5laATKH8caXg7boP4CXe0au6N+5E2Ck7T2/AGUf/LfrmzFixti igEnrYmAvZYxBPlTWxkxXZIe6GVRJrj/OycZycvLdO6Cwcz1pIYjiEhEWvWfugjNQyDZ vFyWGNjKR9takSoOxoLzxhSL05fI6cwNryQzIkcrvh61U9TzZCwb/Tmd3H1V6YuO6NNZ /krbMif91I6MAcvdEKpt0fDmLjtYDTBgA9WhV8HrE4BZxIxAz86DSZGMd3p6NJ0I9RNG IKLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=E7bI5q0C; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id t7si12497620ybl.108.2020.11.27.03.36.18 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Fri, 27 Nov 2020 03:36:18 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=fail header.i=@redhat.com header.s=mimecast20190719 header.b=E7bI5q0C; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1]:35998 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kic2z-0001HO-Ry for alex.bennee@linaro.org; Fri, 27 Nov 2020 06:36:17 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kic2q-0001Gx-Bm for qemu-arm@nongnu.org; Fri, 27 Nov 2020 06:36:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:34572) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kic2k-0001WY-N9 for qemu-arm@nongnu.org; Fri, 27 Nov 2020 06:36:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606476962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=14aEWzZrDPF7XWUDksGeOC7vvrJ7oGa+7SJaCTLJz8o=; b=E7bI5q0CMBYvpnfOg0fTdtvgDPcpOdF7O0B7TMHbW12uWyBICvSnP3KkwWfUf/RzPirzyA nQkD49UZimvPWTiZl0vlYRqazZNLSHBXwtUg1l7uDRaIcXAsaRBH34xzNRNtiw0gIV1rbv ipOMJUrO8MhDFC9vzq9FpBnmd6AyTFI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-pbiAshTNPIW_4tnfi4fxTA-1; Fri, 27 Nov 2020 06:36:00 -0500 X-MC-Unique: pbiAshTNPIW_4tnfi4fxTA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 760209A22A; Fri, 27 Nov 2020 11:35:55 +0000 (UTC) Received: from gondolin (ovpn-113-65.ams2.redhat.com [10.36.113.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5BB875D720; Fri, 27 Nov 2020 11:35:36 +0000 (UTC) Date: Fri, 27 Nov 2020 12:35:33 +0100 From: Cornelia Huck To: Eduardo Habkost Subject: Re: [PATCH v2 1/6] arch_init: Move QEMU_ARCH definitions to cpu.h Message-ID: <20201127123533.3707edf5.cohuck@redhat.com> In-Reply-To: <20201125205636.3305257-2-ehabkost@redhat.com> References: <20201125205636.3305257-1-ehabkost@redhat.com> <20201125205636.3305257-2-ehabkost@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sarah Harris , Sagar Karandikar , David Hildenbrand , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Jiaxun Yang , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Max Filippov , Alistair Francis , Gerd Hoffmann , Guan Xuetao , Marek Vasut , Yoshinori Sato , qemu-ppc@nongnu.org, Artyom Tarasenko , Thomas Huth , Richard Henderson , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Michael Walle , Palmer Dabbelt , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: "Qemu-arm" X-TUID: C0J9rGnY7rHm On Wed, 25 Nov 2020 15:56:31 -0500 Eduardo Habkost wrote: > Instead of a collection of #ifdefs on arch_init.c, define > QEMU_ARCH inside each cpu.h file. >=20 > Signed-off-by: Eduardo Habkost > --- > Cc: Richard Henderson > Cc: Peter Maydell > Cc: Michael Rolnik > Cc: Sarah Harris > Cc: "Edgar E. Iglesias" > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Cc: Michael Walle > Cc: Laurent Vivier > Cc: "Philippe Mathieu-Daud=C3=A9" > Cc: Aurelien Jarno > Cc: Jiaxun Yang > Cc: Aleksandar Rikalo > Cc: Anthony Green > Cc: Chris Wulff > Cc: Marek Vasut > Cc: Stafford Horne > Cc: David Gibson > Cc: Palmer Dabbelt > Cc: Alistair Francis > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Yoshinori Sato > Cc: David Hildenbrand > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > Cc: Guan Xuetao > Cc: Max Filippov > Cc: qemu-devel@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-ppc@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-s390x@nongnu.org > --- > target/alpha/cpu.h | 1 + > target/arm/cpu.h | 1 + > target/avr/cpu.h | 1 + > target/cris/cpu.h | 1 + > target/hppa/cpu.h | 1 + > target/i386/cpu.h | 1 + > target/lm32/cpu.h | 1 + > target/m68k/cpu.h | 1 + > target/microblaze/cpu.h | 1 + > target/mips/cpu.h | 1 + > target/moxie/cpu.h | 1 + > target/nios2/cpu.h | 1 + > target/openrisc/cpu.h | 1 + > target/ppc/cpu.h | 1 + > target/riscv/cpu.h | 1 + > target/rx/cpu.h | 1 + > target/s390x/cpu.h | 1 + > target/sh4/cpu.h | 1 + > target/sparc/cpu.h | 1 + > target/tricore/cpu.h | 1 + > target/unicore32/cpu.h | 1 + > target/xtensa/cpu.h | 1 + > softmmu/arch_init.c | 46 ----------------------------------------- > 23 files changed, 22 insertions(+), 46 deletions(-) Much better :) Reviewed-by: Cornelia Huck From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0D17C2D0E4 for ; Fri, 27 Nov 2020 11:36:49 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 15FEE204EF for ; Fri, 27 Nov 2020 11:36:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E7bI5q0C" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 15FEE204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:37664 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kic3U-0001xQ-1N for qemu-devel@archiver.kernel.org; Fri, 27 Nov 2020 06:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44314) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kic2q-0001H5-SV for qemu-devel@nongnu.org; Fri, 27 Nov 2020 06:36:08 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:46164) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kic2k-0001WX-S9 for qemu-devel@nongnu.org; Fri, 27 Nov 2020 06:36:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606476962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=14aEWzZrDPF7XWUDksGeOC7vvrJ7oGa+7SJaCTLJz8o=; b=E7bI5q0CMBYvpnfOg0fTdtvgDPcpOdF7O0B7TMHbW12uWyBICvSnP3KkwWfUf/RzPirzyA nQkD49UZimvPWTiZl0vlYRqazZNLSHBXwtUg1l7uDRaIcXAsaRBH34xzNRNtiw0gIV1rbv ipOMJUrO8MhDFC9vzq9FpBnmd6AyTFI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-pbiAshTNPIW_4tnfi4fxTA-1; Fri, 27 Nov 2020 06:36:00 -0500 X-MC-Unique: pbiAshTNPIW_4tnfi4fxTA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 760209A22A; Fri, 27 Nov 2020 11:35:55 +0000 (UTC) Received: from gondolin (ovpn-113-65.ams2.redhat.com [10.36.113.65]) by smtp.corp.redhat.com (Postfix) with ESMTP id 5BB875D720; Fri, 27 Nov 2020 11:35:36 +0000 (UTC) Date: Fri, 27 Nov 2020 12:35:33 +0100 From: Cornelia Huck To: Eduardo Habkost Subject: Re: [PATCH v2 1/6] arch_init: Move QEMU_ARCH definitions to cpu.h Message-ID: <20201127123533.3707edf5.cohuck@redhat.com> In-Reply-To: <20201125205636.3305257-2-ehabkost@redhat.com> References: <20201125205636.3305257-1-ehabkost@redhat.com> <20201125205636.3305257-2-ehabkost@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=cohuck@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=216.205.24.124; envelope-from=cohuck@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Sarah Harris , Sagar Karandikar , David Hildenbrand , Anthony Green , Mark Cave-Ayland , qemu-devel@nongnu.org, Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Max Filippov , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , Guan Xuetao , Marek Vasut , Yoshinori Sato , qemu-ppc@nongnu.org, Artyom Tarasenko , Thomas Huth , Richard Henderson , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Michael Walle , Palmer Dabbelt , Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Wed, 25 Nov 2020 15:56:31 -0500 Eduardo Habkost wrote: > Instead of a collection of #ifdefs on arch_init.c, define > QEMU_ARCH inside each cpu.h file. >=20 > Signed-off-by: Eduardo Habkost > --- > Cc: Richard Henderson > Cc: Peter Maydell > Cc: Michael Rolnik > Cc: Sarah Harris > Cc: "Edgar E. Iglesias" > Cc: Paolo Bonzini > Cc: Eduardo Habkost > Cc: Michael Walle > Cc: Laurent Vivier > Cc: "Philippe Mathieu-Daud=C3=A9" > Cc: Aurelien Jarno > Cc: Jiaxun Yang > Cc: Aleksandar Rikalo > Cc: Anthony Green > Cc: Chris Wulff > Cc: Marek Vasut > Cc: Stafford Horne > Cc: David Gibson > Cc: Palmer Dabbelt > Cc: Alistair Francis > Cc: Sagar Karandikar > Cc: Bastian Koppelmann > Cc: Yoshinori Sato > Cc: David Hildenbrand > Cc: Cornelia Huck > Cc: Thomas Huth > Cc: Mark Cave-Ayland > Cc: Artyom Tarasenko > Cc: Guan Xuetao > Cc: Max Filippov > Cc: qemu-devel@nongnu.org > Cc: qemu-arm@nongnu.org > Cc: qemu-ppc@nongnu.org > Cc: qemu-riscv@nongnu.org > Cc: qemu-s390x@nongnu.org > --- > target/alpha/cpu.h | 1 + > target/arm/cpu.h | 1 + > target/avr/cpu.h | 1 + > target/cris/cpu.h | 1 + > target/hppa/cpu.h | 1 + > target/i386/cpu.h | 1 + > target/lm32/cpu.h | 1 + > target/m68k/cpu.h | 1 + > target/microblaze/cpu.h | 1 + > target/mips/cpu.h | 1 + > target/moxie/cpu.h | 1 + > target/nios2/cpu.h | 1 + > target/openrisc/cpu.h | 1 + > target/ppc/cpu.h | 1 + > target/riscv/cpu.h | 1 + > target/rx/cpu.h | 1 + > target/s390x/cpu.h | 1 + > target/sh4/cpu.h | 1 + > target/sparc/cpu.h | 1 + > target/tricore/cpu.h | 1 + > target/unicore32/cpu.h | 1 + > target/xtensa/cpu.h | 1 + > softmmu/arch_init.c | 46 ----------------------------------------- > 23 files changed, 22 insertions(+), 46 deletions(-) Much better :) Reviewed-by: Cornelia Huck