Re: [PATCH v2 1/4] HID: hid-sensor-custom: Add custom sensor iio support

[Jonathan Cameron <jic23@kernel.org>]

On Wed, 25 Nov 2020 10:27:21 +0800
"Ye, Xiang" <xiang.ye@intel.com> wrote:

> On Tue, Nov 24, 2020 at 11:32:11AM +0000, Jonathan Cameron wrote:
> > Hi
> > ...  
> > > > >  	sysfs_remove_group(&sensor_inst->pdev->dev.kobj,
> > > > > diff --git a/include/linux/hid-sensor-ids.h b/include/linux/hid-sensor-ids.h
> > > > > index 530c09f3e64a..46db3056f04b 100644
> > > > > --- a/include/linux/hid-sensor-ids.h
> > > > > +++ b/include/linux/hid-sensor-ids.h
> > > > > @@ -128,6 +128,10 @@
> > > > >  #define HID_USAGE_SENSOR_UNITS_DEGREES_PER_SECOND		0x15
> > > > >  
> > > > >  /* Common selectors */
> > > > > +#define HID_USAGE_SENSOR_PROP_DESC				0x200300
> > > > > +#define HID_USAGE_SENSOR_PROP_FRIENDLY_NAME			0x200301
> > > > > +#define HID_USAGE_SENSOR_PROP_SERIAL_NUM			0x200307
> > > > > +#define HID_USAGE_SENSOR_PROP_MANUFACTURER			0x200305
> > > > >  #define HID_USAGE_SENSOR_PROP_REPORT_INTERVAL			0x20030E
> > > > >  #define HID_USAGE_SENSOR_PROP_SENSITIVITY_ABS			0x20030F
> > > > >  #define HID_USAGE_SENSOR_PROP_SENSITIVITY_RANGE_PCT		0x200310
> > > > > @@ -159,4 +163,39 @@
> > > > >  #define HID_USAGE_SENSOR_PROP_REPORTING_STATE_NO_EVENTS_ENUM	0x200840
> > > > >  #define HID_USAGE_SENSOR_PROP_REPORTING_STATE_ALL_EVENTS_ENUM	0x200841
> > > > >  
> > > > > +/* Custom Sensor (2000e1) */
> > > > > +#define HID_USAGE_SENSOR_HINGE				        0x20020B
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_LOCATION			0x200400
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELE_TIME_SINCE_SYS_BOOT		0x20052B
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_USAGE		0x200541
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE		0x200543    
> > > > Given these are all defined in a block could we use a macro?
> > > > HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x)                     0x200543 + (x)
> > > > 
> > > > perhaps?
> > > > 
> > > > I'm not sure what the preferred convention is in this file.    
> > > If using HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x), we should give a range to x, like (1<x<28).
> > > How to ensure the x is in the range? It can be an issue when someone using x out of the range.  
> > 
> > It can be done via build time checking.
> > https://elixir.bootlin.com/linux/latest/source/include/linux/build_bug.h#L49
> > Normally we wouldn't bother and would rely on review to pick up on this but
> > I'd have no problem with a paranoid check in the macro. Particularly as 28 isn't
> > exactly and obvious number to support!  
> Because HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE is used as case condition, we cannot use
> Build_BUG_ON in the macro like below.
> #define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x)                            \
>        ({                                                                     \
>                BUILD_BUG_ON(x > 28);                                          \
>                BUILD_BUG_ON(x < 0);                                           \
>                (HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_BASE + (x));         \
>        })

Ah. I'd missed the case condition element.  Good point!


> 
> I can use the define with a comments to declear the range of x.
> #define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_BASE           0x200543
> /* Custom Sensor data 28=>x>=0 */
> #define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE(x)                            \
> 	(HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_BASE + (x)) 
> 
Sounds good to me.

Thanks,

Jonathan

> Thanks
> Ye, Xiang
> >   
> > > 
> > > Thanks
> > > Xiang  
> > > >     
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_1		0x200544
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_2		0x200545
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_3		0x200546
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_4		0x200547
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_5		0x200548
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_6		0x200549
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_7		0x20054A
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_8		0x20054B
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_9		0x20054C
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_10		0x20054D
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_11		0x20054E
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_12		0x20054F
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_13		0x200550
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_14		0x200551
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_15		0x200552
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_16		0x200553
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_17		0x200554
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_18		0x200555
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_19		0x200556
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_20		0x200557
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_21		0x200558
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_22		0x200559
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_23		0x20055A
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_24		0x20055B
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_25		0x20055C
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_26		0x20055D
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_27		0x20055E
> > > > > +#define HID_USAGE_SENSOR_DATA_FIELD_CUSTOM_VALUE_28		0x20055F
> > > > > +
> > > > >  #endif    
> > > >     
> >