From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-iio <linux-iio@vger.kernel.org>,
Hartmut Knaack <knaack.h@gmx.de>,
Lars-Peter Clausen <lars@metafoo.de>,
Peter Meerwald-Stadler <pmeerw@pmeerw.net>
Subject: Re: [PATCH 3/3 v3] iio: accel: bmc150-accel: Add rudimentary regulator support
Date: Sat, 28 Nov 2020 13:40:30 +0000 [thread overview]
Message-ID: <20201128134030.1dc08d21@archlinux> (raw)
In-Reply-To: <CACRpkdbP3ccrEK47jaQ=r8sYkFuXBcH=+LTKC1xz+kgXmkwomg@mail.gmail.com>
On Sat, 28 Nov 2020 12:44:26 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:
> On Sat, Nov 21, 2020 at 5:45 PM Jonathan Cameron <jic23@kernel.org> wrote:
> > On Sun, 15 Nov 2020 21:57:45 +0100
> > Linus Walleij <linus.walleij@linaro.org> wrote:
> >
> > > These Bosch accelerometers have two supplies, VDD and VDDIO.
> > > Add some rudimentary support to obtain and enable these
> > > regulators during probe() and disable them during remove()
> > > or on the errorpath.
> > >
> > > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
>
> > All looks good to me. Will leave it for a bit longer though to let
> > Rob have a chance to look at the dt binding doc.
> >
> > As ever, if it seems to have gotten lost it is probably worth
> > poking me.
>
> It's been another week and the bindings are simple enough
> I think? There has been plenty of time to review these
> bindings as they are now in v3 even, but it's a soft measure,
> I know there is usually this YAML-bot that complains if
> something is way out of line at least.
Agreed. No need to bother Rob with this one if he's busy.
It's had 2 weeks in it's final patch version.
Applied to the togreg branch of iio.git and pushed out as
testing for the autobuilders to poke at it.
Thanks,
Jonathan
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2020-11-28 22:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 20:57 [PATCH 1/3 v3] iio: accel: bmc150-accel: Add DT bindings Linus Walleij
2020-11-15 20:57 ` [PATCH 2/3 v3] iio: accel: bmc150-accel: Add support for BMA222 Linus Walleij
2020-11-15 20:57 ` [PATCH 3/3 v3] iio: accel: bmc150-accel: Add rudimentary regulator support Linus Walleij
2020-11-21 16:45 ` Jonathan Cameron
2020-11-28 11:44 ` Linus Walleij
2020-11-28 13:40 ` Jonathan Cameron [this message]
2020-12-01 19:37 ` [PATCH 1/3 v3] iio: accel: bmc150-accel: Add DT bindings Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201128134030.1dc08d21@archlinux \
--to=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linus.walleij@linaro.org \
--cc=linux-iio@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.