All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
	Lorenzo Bianconi <lorenzo.bianconi@redhat.com>,
	linux-iio <linux-iio@vger.kernel.org>,
	Denis CIOCCA <denis.ciocca@st.com>
Subject: Re: [PATCH] iio: common: st_sensors: fix possible infinite loop in st_sensors_irq_thread
Date: Sat, 28 Nov 2020 15:39:29 +0000	[thread overview]
Message-ID: <20201128153929.0e1f4419@archlinux> (raw)
In-Reply-To: <CACRpkdaAuppq8PesYRv-8Tww0saRbJu2XmYzGWnTm5Rdm-xZHg@mail.gmail.com>

On Sun, 15 Nov 2020 23:50:51 +0100
Linus Walleij <linus.walleij@linaro.org> wrote:

> On Sun, Nov 15, 2020 at 3:38 PM Lorenzo Bianconi <lorenzo@kernel.org> wrote:
> 
> > Return a boolean value in st_sensors_new_samples_available routine in
> > order to avoid an infinite loop in st_sensors_irq_thread if
> > stat_drdy.addr is not defined or stat_drdy read fails
> >
> > Fixes: 90efe05562921 ("iio: st_sensors: harden interrupt handling")
> > Reported-by: Jonathan Cameron <jic23@kernel.org>
> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>  
> 
> This looks more clear if nothing else.
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Denis,

This is in the 'obviously' correct category but I've been wrong before
so would ideally like you to you sanity check this one and Ack.

thanks,

Jonathan

> 
> Yours,
> Linus Walleij


  reply	other threads:[~2020-11-28 22:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-15 14:38 [PATCH] iio: common: st_sensors: fix possible infinite loop in st_sensors_irq_thread Lorenzo Bianconi
2020-11-15 22:50 ` Linus Walleij
2020-11-28 15:39   ` Jonathan Cameron [this message]
2020-12-03  4:06 ` Denis CIOCCA
2020-12-05 15:11   ` Jonathan Cameron
2020-12-07 17:11     ` lorenzo.bianconi
2020-12-08 10:31       ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201128153929.0e1f4419@archlinux \
    --to=jic23@kernel.org \
    --cc=denis.ciocca@st.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=lorenzo.bianconi@redhat.com \
    --cc=lorenzo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.