Re: [dpdk-dev] [PATCH v2] eal/windows: vfprintf build warning with clang

[Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>]

On Sun, 29 Nov 2020 13:00:47 +0000, Nick Connolly wrote:
> When building with clang (11.0,--buildtype=debug), eal_lcore.c
> produces a -Wformat-nonliteral warning from the vfprintf call
> in log_early.
> 
> Add __rte_format_printf annotation.
> 
> Fixes: b8a36b086625 ("eal/windows: improve CPU and NUMA node detection")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Nick Connolly <nick.connolly@mayadata.io>
> Suggested-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---
> v2:
> * Use __rte_format_printf instead of disabling the warning
> 
>  lib/librte_eal/windows/eal_lcore.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/lib/librte_eal/windows/eal_lcore.c b/lib/librte_eal/windows/eal_lcore.c
> index d5ff721e0..a85149be9 100644
> --- a/lib/librte_eal/windows/eal_lcore.c
> +++ b/lib/librte_eal/windows/eal_lcore.c
> @@ -38,6 +38,7 @@ static struct cpu_map cpu_map = { 0 };
>  
>  /* eal_create_cpu_map() is called before logging is initialized */
>  static void
> +__rte_format_printf(1, 2)
>  log_early(const char *format, ...)
>  {
>  	va_list va;

Acked-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>