From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F88CC71156 for ; Sun, 29 Nov 2020 23:08:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6539A22245 for ; Sun, 29 Nov 2020 23:08:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727991AbgK2XIf (ORCPT ); Sun, 29 Nov 2020 18:08:35 -0500 Received: from mail-wr1-f67.google.com ([209.85.221.67]:43275 "EHLO mail-wr1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726777AbgK2XIe (ORCPT ); Sun, 29 Nov 2020 18:08:34 -0500 Received: by mail-wr1-f67.google.com with SMTP id s8so13044292wrw.10 for ; Sun, 29 Nov 2020 15:08:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ff6pKCmLg5oT72OgCOHiIPYU12IbKoKvOXqEEVgg4cU=; b=BQSY1Wx1OF/kE0yEuF9Lx4nr2X8eBJWZTTBJxignI/KtQlrvbzEc+RZDzHwJTWEpKS 7VEcXjoF2LwbKMf3iV2PAKVJFNS0sMuc4KMJOohQOSlueRJnPU6YE67lqR1g/mxS/PAw pmi7DhhiPb9NZjRVVMHS62p9XJQ4EGNlJkWS4TxFeKhNIcn538aPD3RnN5BuwS1KRJeq eIcP4zbDzGW670X2HGemuGDyiSweERli4g02DjqF+NoYxf1sNArOvt0Bb8ahrGMIcenz szu4R8HZjJoMD0xKnBE2x+mrK2Q6c2aWOUdyTDAB50skbMF4qt4fvEGVyFd49ZyK3c1W 89OQ== X-Gm-Message-State: AOAM532fjcdOpk+iKv/VL8jedrsHPK3nm9e+JfLTxN6wANITCqqU2lB/ c+7qCdFdFgrJytuNeTIZKjM= X-Google-Smtp-Source: ABdhPJzHI72BcK2gh0kFjWjYjgwPhW5lYayUpFmk6eoZtDqknP6gOkv3hmwsP0YHAvHXiiV7ZOzodw== X-Received: by 2002:adf:f9c5:: with SMTP id w5mr24603230wrr.69.1606691272550; Sun, 29 Nov 2020 15:07:52 -0800 (PST) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id d2sm24831005wrn.43.2020.11.29.15.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 15:07:52 -0800 (PST) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Cc: Rob Herring , Jonathan Cameron , Jonathan Chocron , Shawn Lin , Heiko Stuebner , Zhou Wang , Lorenzo Pieralisi , Will Deacon , Robert Richter , Michal Simek , Toan Le , Michael Ellerman , Benjamin Herrenschmidt , Paul Mackerras , Thomas Petazzoni , Nicolas Saenz Julienne , Florian Fainelli , Ray Jui , Scott Branden , Jonathan Derrick , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-rockchip@lists.infradead.org, linux-rpi-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com Subject: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Date: Sun, 29 Nov 2020 23:07:42 +0000 Message-Id: <20201129230743.3006978-5-kw@linux.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201129230743.3006978-1-kw@linux.com> References: <20201129230743.3006978-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Use "void __iomem" instead "char __iomem" pointer type when working with the accessor functions (with names like readb() or writel(), etc.) to better match a given accessor function signature where commonly the address pointing to an I/O memory region would be a "void __iomem" pointer. Related: https://lwn.net/Articles/102232/ Suggested-by: Bjorn Helgaas Signed-off-by: Krzysztof Wilczyński --- drivers/pci/controller/vmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 1361a79bd1e7..59fa9a94860f 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -95,7 +95,7 @@ struct vmd_dev { struct pci_dev *dev; spinlock_t cfg_lock; - char __iomem *cfgbar; + void __iomem *cfgbar; int msix_count; struct vmd_irq_list *irqs; @@ -326,7 +326,7 @@ static void vmd_remove_irq_domain(struct vmd_dev *vmd) } } -static char __iomem *vmd_cfg_addr(struct vmd_dev *vmd, struct pci_bus *bus, +static void __iomem *vmd_cfg_addr(struct vmd_dev *vmd, struct pci_bus *bus, unsigned int devfn, int reg, int len) { unsigned int busnr_ecam = bus->number - vmd->busn_start; @@ -346,7 +346,7 @@ static int vmd_pci_read(struct pci_bus *bus, unsigned int devfn, int reg, int len, u32 *value) { struct vmd_dev *vmd = vmd_from_bus(bus); - char __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); + void __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); unsigned long flags; int ret = 0; @@ -381,7 +381,7 @@ static int vmd_pci_write(struct pci_bus *bus, unsigned int devfn, int reg, int len, u32 value) { struct vmd_dev *vmd = vmd_from_bus(bus); - char __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); + void __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); unsigned long flags; int ret = 0; -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A7EAC3E8C5 for ; Sun, 29 Nov 2020 23:08:44 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC0572084C for ; Sun, 29 Nov 2020 23:08:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tbEJ+cVz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC0572084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Wo9qoKiuFRV1sz4TeNoer/bWgQjrQ8TsbuqDP6+bf64=; b=tbEJ+cVzMiV0u7/uBtDpemxQr k8cVBLIR4YnscTr+oHNA8QQx30v6IhQ5ZpgmdFpvPGDjq/ZbGhzD7gZTZ/DLWSn+ehZYrZpEymgOJ 5M/dkfQtze8ghH0r1dJm4khWWSBQDQwt3T63Z79upnOzvGtW/mSWbkFGOFESyn1fq1LXPmxZZjCry raYgXNdKlzip4JoozQSfw9vmsclA83JFNkNrs96+pIzGjSg6DK6Kk8amVvIgqRJfNOppZvjBEaLdW UVVbWsvG8rmRm4LwN1OHgg4X17fMsJ2ecD8OahKZ56EC1UB9xce4zX7t4+pgDH0PsQ8VmbslnnKG3 wQ0fpx+kQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjVo3-0002Jl-Gp; Sun, 29 Nov 2020 23:08:35 +0000 Received: from mail-wr1-f68.google.com ([209.85.221.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjVnN-00024s-C4; Sun, 29 Nov 2020 23:07:54 +0000 Received: by mail-wr1-f68.google.com with SMTP id e7so13083407wrv.6; Sun, 29 Nov 2020 15:07:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ff6pKCmLg5oT72OgCOHiIPYU12IbKoKvOXqEEVgg4cU=; b=Izxg8Xht3CvWe1xvBIr8Rb6A17QKh5nFXMFtTYQzmi74gu/RHaBp4iVzyeXMpvcEUW JWUFOIXRPli1RFC43kiYbRG5mFZ/H+asSiR2CrjNJC1xLifm7W2/nCs1ykIaQhQi2ev/ YmrAFZvZYixqzwXfuwqjMlKIVLc7Y9dboc07LTib+B6lDY4NYMEoRnr1CSewu/V0PwMp 3IkjIu2cWyiWFqKuVTqvRqDpn6VVz1XdJ3IsAN/g0lLV/g6V0Wgw5YJ8QsjpTtRuzfpH AOttd5LEcUY5iFcC77BUHHxUpQdQq9pbPo2Hn3w8DEx4yK4nOzb1ZQJaWNs7Bx3o7CJX WW9w== X-Gm-Message-State: AOAM531g6YUBpFwygKysir9B0LwClKTxEqXSgzeSRtbYp3Fh8lstr3FX 9SviIioUYLGJsWNKJdGd5vw= X-Google-Smtp-Source: ABdhPJzHI72BcK2gh0kFjWjYjgwPhW5lYayUpFmk6eoZtDqknP6gOkv3hmwsP0YHAvHXiiV7ZOzodw== X-Received: by 2002:adf:f9c5:: with SMTP id w5mr24603230wrr.69.1606691272550; Sun, 29 Nov 2020 15:07:52 -0800 (PST) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id d2sm24831005wrn.43.2020.11.29.15.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 15:07:52 -0800 (PST) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Date: Sun, 29 Nov 2020 23:07:42 +0000 Message-Id: <20201129230743.3006978-5-kw@linux.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201129230743.3006978-1-kw@linux.com> References: <20201129230743.3006978-1-kw@linux.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201129_180753_488459_CF0AB4E3 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Benjamin Herrenschmidt , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Lorenzo Pieralisi , Michael Ellerman , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Jonathan Derrick , linux-pci@vger.kernel.org, Ray Jui , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , linux-arm-kernel@lists.infradead.org, Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org VXNlICJ2b2lkIF9faW9tZW0iIGluc3RlYWQgImNoYXIgX19pb21lbSIgcG9pbnRlciB0eXBlIHdo ZW4gd29ya2luZyB3aXRoCnRoZSBhY2Nlc3NvciBmdW5jdGlvbnMgKHdpdGggbmFtZXMgbGlrZSBy ZWFkYigpIG9yIHdyaXRlbCgpLCBldGMuKSB0bwpiZXR0ZXIgbWF0Y2ggYSBnaXZlbiBhY2Nlc3Nv ciBmdW5jdGlvbiBzaWduYXR1cmUgd2hlcmUgY29tbW9ubHkgdGhlCmFkZHJlc3MgcG9pbnRpbmcg dG8gYW4gSS9PIG1lbW9yeSByZWdpb24gd291bGQgYmUgYSAidm9pZCBfX2lvbWVtIgpwb2ludGVy LgoKUmVsYXRlZDoKICBodHRwczovL2x3bi5uZXQvQXJ0aWNsZXMvMTAyMjMyLwoKU3VnZ2VzdGVk LWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgpTaWduZWQtb2ZmLWJ5OiBL cnp5c3p0b2YgV2lsY3p5xYRza2kgPGt3QGxpbnV4LmNvbT4KLS0tCiBkcml2ZXJzL3BjaS9jb250 cm9sbGVyL3ZtZC5jIHwgOCArKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3Zt ZC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci92bWQuYwppbmRleCAxMzYxYTc5YmQxZTcuLjU5 ZmE5YTk0ODYwZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci92bWQuYworKysg Yi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3ZtZC5jCkBAIC05NSw3ICs5NSw3IEBAIHN0cnVjdCB2 bWRfZGV2IHsKIAlzdHJ1Y3QgcGNpX2RldgkJKmRldjsKIAogCXNwaW5sb2NrX3QJCWNmZ19sb2Nr OwotCWNoYXIgX19pb21lbQkJKmNmZ2JhcjsKKwl2b2lkIF9faW9tZW0JCSpjZmdiYXI7CiAKIAlp bnQgbXNpeF9jb3VudDsKIAlzdHJ1Y3Qgdm1kX2lycV9saXN0CSppcnFzOwpAQCAtMzI2LDcgKzMy Niw3IEBAIHN0YXRpYyB2b2lkIHZtZF9yZW1vdmVfaXJxX2RvbWFpbihzdHJ1Y3Qgdm1kX2RldiAq dm1kKQogCX0KIH0KIAotc3RhdGljIGNoYXIgX19pb21lbSAqdm1kX2NmZ19hZGRyKHN0cnVjdCB2 bWRfZGV2ICp2bWQsIHN0cnVjdCBwY2lfYnVzICpidXMsCitzdGF0aWMgdm9pZCBfX2lvbWVtICp2 bWRfY2ZnX2FkZHIoc3RydWN0IHZtZF9kZXYgKnZtZCwgc3RydWN0IHBjaV9idXMgKmJ1cywKIAkJ CQkgIHVuc2lnbmVkIGludCBkZXZmbiwgaW50IHJlZywgaW50IGxlbikKIHsKIAl1bnNpZ25lZCBp bnQgYnVzbnJfZWNhbSA9IGJ1cy0+bnVtYmVyIC0gdm1kLT5idXNuX3N0YXJ0OwpAQCAtMzQ2LDcg KzM0Niw3IEBAIHN0YXRpYyBpbnQgdm1kX3BjaV9yZWFkKHN0cnVjdCBwY2lfYnVzICpidXMsIHVu c2lnbmVkIGludCBkZXZmbiwgaW50IHJlZywKIAkJCWludCBsZW4sIHUzMiAqdmFsdWUpCiB7CiAJ c3RydWN0IHZtZF9kZXYgKnZtZCA9IHZtZF9mcm9tX2J1cyhidXMpOwotCWNoYXIgX19pb21lbSAq YWRkciA9IHZtZF9jZmdfYWRkcih2bWQsIGJ1cywgZGV2Zm4sIHJlZywgbGVuKTsKKwl2b2lkIF9f aW9tZW0gKmFkZHIgPSB2bWRfY2ZnX2FkZHIodm1kLCBidXMsIGRldmZuLCByZWcsIGxlbik7CiAJ dW5zaWduZWQgbG9uZyBmbGFnczsKIAlpbnQgcmV0ID0gMDsKIApAQCAtMzgxLDcgKzM4MSw3IEBA IHN0YXRpYyBpbnQgdm1kX3BjaV93cml0ZShzdHJ1Y3QgcGNpX2J1cyAqYnVzLCB1bnNpZ25lZCBp bnQgZGV2Zm4sIGludCByZWcsCiAJCQkgaW50IGxlbiwgdTMyIHZhbHVlKQogewogCXN0cnVjdCB2 bWRfZGV2ICp2bWQgPSB2bWRfZnJvbV9idXMoYnVzKTsKLQljaGFyIF9faW9tZW0gKmFkZHIgPSB2 bWRfY2ZnX2FkZHIodm1kLCBidXMsIGRldmZuLCByZWcsIGxlbik7CisJdm9pZCBfX2lvbWVtICph ZGRyID0gdm1kX2NmZ19hZGRyKHZtZCwgYnVzLCBkZXZmbiwgcmVnLCBsZW4pOwogCXVuc2lnbmVk IGxvbmcgZmxhZ3M7CiAJaW50IHJldCA9IDA7CiAKLS0gCjIuMjkuMgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkxpbnV4LXJvY2tjaGlwIG1haWxpbmcg bGlzdApMaW51eC1yb2NrY2hpcEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZy YWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcm9ja2NoaXAK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F49C64E7D for ; Sun, 29 Nov 2020 23:16:27 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0261220727 for ; Sun, 29 Nov 2020 23:16:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0261220727 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 4Ckkkw6Z8TzDqyx for ; Mon, 30 Nov 2020 10:16:24 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=gmail.com (client-ip=209.85.221.67; helo=mail-wr1-f67.google.com; envelope-from=kswilczynski@gmail.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.com Received: from mail-wr1-f67.google.com (mail-wr1-f67.google.com [209.85.221.67]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4CkkY71W2YzDrCX for ; Mon, 30 Nov 2020 10:07:55 +1100 (AEDT) Received: by mail-wr1-f67.google.com with SMTP id m6so13058130wrg.7 for ; Sun, 29 Nov 2020 15:07:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ff6pKCmLg5oT72OgCOHiIPYU12IbKoKvOXqEEVgg4cU=; b=j5UBR3WaswxgSYSdMClOPZ75eLQZ1xjMPzMq2ZdwJaStD7PBLHXqJoZEnBqsE2F3Yi 7FR5ISEWaAtf7bHTJji+WCBUuCwold2/FrzSqVBwykV2EtB77Tj+QuILvYzBTPmaweV3 8p1pJg8f5jb2pbMmI2mlv4FDnPp2VF8WEWWX5k7BlxE8F51sPYOthacOeN7f62U8wzZ2 2zKN19r6lolN/h/rZVPJHHkvsF2Ee2hYN3yz/jFhInDUkZZj/7oxfhZb3pKC8PPDr8it L0ijfDG/+fiPGIBgqmEoaYEYcQgaGCbODw69BC6Fv76srMZjqjkAtCUd3aa2WDq8OBft wZbg== X-Gm-Message-State: AOAM530lxeCi1BaXT67MnfBhwxU43WcGdk9MT9ZRNk2Nc6E/CwYb7+3H ZoijTfSGnPaUlRIv6vg71L4= X-Google-Smtp-Source: ABdhPJzHI72BcK2gh0kFjWjYjgwPhW5lYayUpFmk6eoZtDqknP6gOkv3hmwsP0YHAvHXiiV7ZOzodw== X-Received: by 2002:adf:f9c5:: with SMTP id w5mr24603230wrr.69.1606691272550; Sun, 29 Nov 2020 15:07:52 -0800 (PST) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id d2sm24831005wrn.43.2020.11.29.15.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 15:07:52 -0800 (PST) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Date: Sun, 29 Nov 2020 23:07:42 +0000 Message-Id: <20201129230743.3006978-5-kw@linux.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201129230743.3006978-1-kw@linux.com> References: <20201129230743.3006978-1-kw@linux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Lorenzo Pieralisi , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Jonathan Derrick , linux-pci@vger.kernel.org, Ray Jui , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , linux-arm-kernel@lists.infradead.org, Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" Use "void __iomem" instead "char __iomem" pointer type when working with the accessor functions (with names like readb() or writel(), etc.) to better match a given accessor function signature where commonly the address pointing to an I/O memory region would be a "void __iomem" pointer. Related: https://lwn.net/Articles/102232/ Suggested-by: Bjorn Helgaas Signed-off-by: Krzysztof Wilczyński --- drivers/pci/controller/vmd.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c index 1361a79bd1e7..59fa9a94860f 100644 --- a/drivers/pci/controller/vmd.c +++ b/drivers/pci/controller/vmd.c @@ -95,7 +95,7 @@ struct vmd_dev { struct pci_dev *dev; spinlock_t cfg_lock; - char __iomem *cfgbar; + void __iomem *cfgbar; int msix_count; struct vmd_irq_list *irqs; @@ -326,7 +326,7 @@ static void vmd_remove_irq_domain(struct vmd_dev *vmd) } } -static char __iomem *vmd_cfg_addr(struct vmd_dev *vmd, struct pci_bus *bus, +static void __iomem *vmd_cfg_addr(struct vmd_dev *vmd, struct pci_bus *bus, unsigned int devfn, int reg, int len) { unsigned int busnr_ecam = bus->number - vmd->busn_start; @@ -346,7 +346,7 @@ static int vmd_pci_read(struct pci_bus *bus, unsigned int devfn, int reg, int len, u32 *value) { struct vmd_dev *vmd = vmd_from_bus(bus); - char __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); + void __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); unsigned long flags; int ret = 0; @@ -381,7 +381,7 @@ static int vmd_pci_write(struct pci_bus *bus, unsigned int devfn, int reg, int len, u32 value) { struct vmd_dev *vmd = vmd_from_bus(bus); - char __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); + void __iomem *addr = vmd_cfg_addr(vmd, bus, devfn, reg, len); unsigned long flags; int ret = 0; -- 2.29.2 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56265C64E7B for ; Sun, 29 Nov 2020 23:10:07 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0A96D2084C for ; Sun, 29 Nov 2020 23:10:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cHzDWFBR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0A96D2084C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Ha3wlmh657/5oX39+8+vGWfx8Hoeotr1A8JhjhSECho=; b=cHzDWFBRPyAcBH6zxHjzH/XgW uYebHrNtvmHiYwlzF7IIWqc8GJP5FBJWHqK2riuwvdl50SpgJydX4fSQSwgbS9RKs+BY08nahWZMM TToTLOmGVB1Lw6rk4DvwRGgSbjwa2zstD4b741dfJ5zZehhIstuh2m8bAKsX6MtoJ1FHop9qy1Ch8 L6RDf8sL3v7+AAncGFeLisKkIeCtnEN5czu594AK5p4HFh00rEi0hXWyAQrtlona3IvkF0alxlrV5 mC4tCPkDbg5YF0i8PjMEF5lY8HRbGV0gA3ozpIvjhh6NBb6b0VW7vimo76rjiAvUGaB/N1AkCnPTB p9YYBXv+A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjVoM-0002Pu-N5; Sun, 29 Nov 2020 23:08:54 +0000 Received: from mail-wr1-f68.google.com ([209.85.221.68]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjVnN-00024s-C4; Sun, 29 Nov 2020 23:07:54 +0000 Received: by mail-wr1-f68.google.com with SMTP id e7so13083407wrv.6; Sun, 29 Nov 2020 15:07:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ff6pKCmLg5oT72OgCOHiIPYU12IbKoKvOXqEEVgg4cU=; b=Izxg8Xht3CvWe1xvBIr8Rb6A17QKh5nFXMFtTYQzmi74gu/RHaBp4iVzyeXMpvcEUW JWUFOIXRPli1RFC43kiYbRG5mFZ/H+asSiR2CrjNJC1xLifm7W2/nCs1ykIaQhQi2ev/ YmrAFZvZYixqzwXfuwqjMlKIVLc7Y9dboc07LTib+B6lDY4NYMEoRnr1CSewu/V0PwMp 3IkjIu2cWyiWFqKuVTqvRqDpn6VVz1XdJ3IsAN/g0lLV/g6V0Wgw5YJ8QsjpTtRuzfpH AOttd5LEcUY5iFcC77BUHHxUpQdQq9pbPo2Hn3w8DEx4yK4nOzb1ZQJaWNs7Bx3o7CJX WW9w== X-Gm-Message-State: AOAM531g6YUBpFwygKysir9B0LwClKTxEqXSgzeSRtbYp3Fh8lstr3FX 9SviIioUYLGJsWNKJdGd5vw= X-Google-Smtp-Source: ABdhPJzHI72BcK2gh0kFjWjYjgwPhW5lYayUpFmk6eoZtDqknP6gOkv3hmwsP0YHAvHXiiV7ZOzodw== X-Received: by 2002:adf:f9c5:: with SMTP id w5mr24603230wrr.69.1606691272550; Sun, 29 Nov 2020 15:07:52 -0800 (PST) Received: from workstation.lan ([95.155.85.46]) by smtp.gmail.com with ESMTPSA id d2sm24831005wrn.43.2020.11.29.15.07.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 29 Nov 2020 15:07:52 -0800 (PST) From: =?UTF-8?q?Krzysztof=20Wilczy=C5=84ski?= To: Bjorn Helgaas Subject: [PATCH v6 4/5] PCI: vmd: Update type of the __iomem pointers Date: Sun, 29 Nov 2020 23:07:42 +0000 Message-Id: <20201129230743.3006978-5-kw@linux.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20201129230743.3006978-1-kw@linux.com> References: <20201129230743.3006978-1-kw@linux.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201129_180753_488459_CF0AB4E3 X-CRM114-Status: GOOD ( 14.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Benjamin Herrenschmidt , Shawn Lin , Paul Mackerras , Thomas Petazzoni , Jonathan Chocron , Toan Le , Will Deacon , Rob Herring , Lorenzo Pieralisi , Michael Ellerman , Michal Simek , linux-rockchip@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, Jonathan Derrick , linux-pci@vger.kernel.org, Ray Jui , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Jonathan Cameron , linux-arm-kernel@lists.infradead.org, Scott Branden , Zhou Wang , Robert Richter , linuxppc-dev@lists.ozlabs.org, Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org VXNlICJ2b2lkIF9faW9tZW0iIGluc3RlYWQgImNoYXIgX19pb21lbSIgcG9pbnRlciB0eXBlIHdo ZW4gd29ya2luZyB3aXRoCnRoZSBhY2Nlc3NvciBmdW5jdGlvbnMgKHdpdGggbmFtZXMgbGlrZSBy ZWFkYigpIG9yIHdyaXRlbCgpLCBldGMuKSB0bwpiZXR0ZXIgbWF0Y2ggYSBnaXZlbiBhY2Nlc3Nv ciBmdW5jdGlvbiBzaWduYXR1cmUgd2hlcmUgY29tbW9ubHkgdGhlCmFkZHJlc3MgcG9pbnRpbmcg dG8gYW4gSS9PIG1lbW9yeSByZWdpb24gd291bGQgYmUgYSAidm9pZCBfX2lvbWVtIgpwb2ludGVy LgoKUmVsYXRlZDoKICBodHRwczovL2x3bi5uZXQvQXJ0aWNsZXMvMTAyMjMyLwoKU3VnZ2VzdGVk LWJ5OiBCam9ybiBIZWxnYWFzIDxiaGVsZ2Fhc0Bnb29nbGUuY29tPgpTaWduZWQtb2ZmLWJ5OiBL cnp5c3p0b2YgV2lsY3p5xYRza2kgPGt3QGxpbnV4LmNvbT4KLS0tCiBkcml2ZXJzL3BjaS9jb250 cm9sbGVyL3ZtZC5jIHwgOCArKysrLS0tLQogMSBmaWxlIGNoYW5nZWQsIDQgaW5zZXJ0aW9ucygr KSwgNCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3Zt ZC5jIGIvZHJpdmVycy9wY2kvY29udHJvbGxlci92bWQuYwppbmRleCAxMzYxYTc5YmQxZTcuLjU5 ZmE5YTk0ODYwZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9wY2kvY29udHJvbGxlci92bWQuYworKysg Yi9kcml2ZXJzL3BjaS9jb250cm9sbGVyL3ZtZC5jCkBAIC05NSw3ICs5NSw3IEBAIHN0cnVjdCB2 bWRfZGV2IHsKIAlzdHJ1Y3QgcGNpX2RldgkJKmRldjsKIAogCXNwaW5sb2NrX3QJCWNmZ19sb2Nr OwotCWNoYXIgX19pb21lbQkJKmNmZ2JhcjsKKwl2b2lkIF9faW9tZW0JCSpjZmdiYXI7CiAKIAlp bnQgbXNpeF9jb3VudDsKIAlzdHJ1Y3Qgdm1kX2lycV9saXN0CSppcnFzOwpAQCAtMzI2LDcgKzMy Niw3IEBAIHN0YXRpYyB2b2lkIHZtZF9yZW1vdmVfaXJxX2RvbWFpbihzdHJ1Y3Qgdm1kX2RldiAq dm1kKQogCX0KIH0KIAotc3RhdGljIGNoYXIgX19pb21lbSAqdm1kX2NmZ19hZGRyKHN0cnVjdCB2 bWRfZGV2ICp2bWQsIHN0cnVjdCBwY2lfYnVzICpidXMsCitzdGF0aWMgdm9pZCBfX2lvbWVtICp2 bWRfY2ZnX2FkZHIoc3RydWN0IHZtZF9kZXYgKnZtZCwgc3RydWN0IHBjaV9idXMgKmJ1cywKIAkJ CQkgIHVuc2lnbmVkIGludCBkZXZmbiwgaW50IHJlZywgaW50IGxlbikKIHsKIAl1bnNpZ25lZCBp bnQgYnVzbnJfZWNhbSA9IGJ1cy0+bnVtYmVyIC0gdm1kLT5idXNuX3N0YXJ0OwpAQCAtMzQ2LDcg KzM0Niw3IEBAIHN0YXRpYyBpbnQgdm1kX3BjaV9yZWFkKHN0cnVjdCBwY2lfYnVzICpidXMsIHVu c2lnbmVkIGludCBkZXZmbiwgaW50IHJlZywKIAkJCWludCBsZW4sIHUzMiAqdmFsdWUpCiB7CiAJ c3RydWN0IHZtZF9kZXYgKnZtZCA9IHZtZF9mcm9tX2J1cyhidXMpOwotCWNoYXIgX19pb21lbSAq YWRkciA9IHZtZF9jZmdfYWRkcih2bWQsIGJ1cywgZGV2Zm4sIHJlZywgbGVuKTsKKwl2b2lkIF9f aW9tZW0gKmFkZHIgPSB2bWRfY2ZnX2FkZHIodm1kLCBidXMsIGRldmZuLCByZWcsIGxlbik7CiAJ dW5zaWduZWQgbG9uZyBmbGFnczsKIAlpbnQgcmV0ID0gMDsKIApAQCAtMzgxLDcgKzM4MSw3IEBA IHN0YXRpYyBpbnQgdm1kX3BjaV93cml0ZShzdHJ1Y3QgcGNpX2J1cyAqYnVzLCB1bnNpZ25lZCBp bnQgZGV2Zm4sIGludCByZWcsCiAJCQkgaW50IGxlbiwgdTMyIHZhbHVlKQogewogCXN0cnVjdCB2 bWRfZGV2ICp2bWQgPSB2bWRfZnJvbV9idXMoYnVzKTsKLQljaGFyIF9faW9tZW0gKmFkZHIgPSB2 bWRfY2ZnX2FkZHIodm1kLCBidXMsIGRldmZuLCByZWcsIGxlbik7CisJdm9pZCBfX2lvbWVtICph ZGRyID0gdm1kX2NmZ19hZGRyKHZtZCwgYnVzLCBkZXZmbiwgcmVnLCBsZW4pOwogCXVuc2lnbmVk IGxvbmcgZmxhZ3M7CiAJaW50IHJldCA9IDA7CiAKLS0gCjIuMjkuMgoKCl9fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGlu ZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMu aW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK