From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E519C5519F for ; Mon, 30 Nov 2020 07:57:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0163D20709 for ; Mon, 30 Nov 2020 07:57:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726858AbgK3H5l (ORCPT ); Mon, 30 Nov 2020 02:57:41 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:51638 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726299AbgK3H5l (ORCPT ); Mon, 30 Nov 2020 02:57:41 -0500 Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 4557C20026; Mon, 30 Nov 2020 08:56:47 +0100 (CET) Date: Mon, 30 Nov 2020 08:56:45 +0100 From: Sam Ravnborg To: Peilin Ye Cc: linux-fbdev@vger.kernel.org, Vaibhav Gupta , Tetsuo Handa , dri-devel@lists.freedesktop.org, Laurent Pinchart , Jiri Slaby , Arnd Bergmann , Florian Tobias Schandinat , Evgeny Novikov , Lee Jones , Saeed Mirzamohammadi , Daniel Vetter , Thomas Winischhofer , Thomas Zimmermann , Bartlomiej Zolnierkiewicz , Jani Nikula , Aditya Pakki , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , George Kennedy , Kristoffer Ericson , Alexander Klimov , Jingoo Han , Joe Perches , Peter Rosin , Mike Rapoport Subject: Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon Message-ID: <20201130075645.GA1442147@ravnborg.org> References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-3-sam@ravnborg.org> <9fbdaff8-18af-223d-6cec-4b44aeb94fec@suse.de> <20201129111836.GA1094053@ravnborg.org> <20201130063805.GA21500@PWN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201130063805.GA21500@PWN> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=1bFr7IoaHJKwnvFcCG0A:9 a=CjuIK1q_8ugA:10 Precedence: bulk List-ID: X-Mailing-List: linux-fbdev@vger.kernel.org Hi Peilin, On Mon, Nov 30, 2020 at 01:38:05AM -0500, Peilin Ye wrote: > Hi Sam, > > On Sun, Nov 29, 2020 at 12:18:36PM +0100, Sam Ravnborg wrote: > > On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > > > But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed > > > when FBCONDEBUG is defined. Is such change what the author of this module expects? > > > > When someone goes and enable DEBUG for fbcon they are also able to > > recognize the logging, so the printing of the function name is redundant > > in this case. > > > > There is likely limited to no use for these few logging entries, but if > > they should be dropped then I expect Peilin Ye to do so as he is the > > only one doing active maintenance of fbcon lately. > > Sure, I will take another look at them. Also sorry for the delay in that > printk() -> dev_*() patch you suggested, overwhelmed by some other > things this week. Sometimes fbcon.c accesses dev structs in a pretty > weird way (e.g. registered_fb[con2fb_map[vc->vc_num]]->dev), I will get > back to it when I understand this better. Please just keep up the good work cleaning up fbcon and related stuff. This is an area that needs some love and care and there is work for many long nights yet to do. Sam From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8086DC5519F for ; Mon, 30 Nov 2020 07:56:58 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DD8DA20719 for ; Mon, 30 Nov 2020 07:56:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DD8DA20719 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ravnborg.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 361BD89F33; Mon, 30 Nov 2020 07:56:57 +0000 (UTC) Received: from asavdk3.altibox.net (asavdk3.altibox.net [109.247.116.14]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4659089F33 for ; Mon, 30 Nov 2020 07:56:55 +0000 (UTC) Received: from ravnborg.org (unknown [188.228.123.71]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 4557C20026; Mon, 30 Nov 2020 08:56:47 +0100 (CET) Date: Mon, 30 Nov 2020 08:56:45 +0100 From: Sam Ravnborg To: Peilin Ye Subject: Re: [PATCH v2 02/28] video: fbcon: Fix warnings by using pr_debug() in fbcon Message-ID: <20201130075645.GA1442147@ravnborg.org> References: <20201128224114.1033617-1-sam@ravnborg.org> <20201128224114.1033617-3-sam@ravnborg.org> <9fbdaff8-18af-223d-6cec-4b44aeb94fec@suse.de> <20201129111836.GA1094053@ravnborg.org> <20201130063805.GA21500@PWN> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201130063805.GA21500@PWN> X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=Ibmpp1ia c=1 sm=1 tr=0 a=S6zTFyMACwkrwXSdXUNehg==:117 a=S6zTFyMACwkrwXSdXUNehg==:17 a=kj9zAlcOel0A:10 a=1bFr7IoaHJKwnvFcCG0A:9 a=CjuIK1q_8ugA:10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Vaibhav Gupta , Tetsuo Handa , Daniel Vetter , dri-devel@lists.freedesktop.org, Laurent Pinchart , Lee Jones , Florian Tobias Schandinat , Evgeny Novikov , Jiri Slaby , Jani Nikula , Aditya Pakki , Alexander Klimov , Arnd Bergmann , Bartlomiej Zolnierkiewicz , Saeed Mirzamohammadi , Thomas Winischhofer , Xiaofei Tan , Nathan Chancellor , Alex Dewar , Jason Yan , Greg Kroah-Hartman , Qilong Zhang , Randy Dunlap , Gustavo Silva , George Kennedy , Kristoffer Ericson , Thomas Zimmermann , Jingoo Han , Joe Perches , Peter Rosin , Mike Rapoport Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Peilin, On Mon, Nov 30, 2020 at 01:38:05AM -0500, Peilin Ye wrote: > Hi Sam, > > On Sun, Nov 29, 2020 at 12:18:36PM +0100, Sam Ravnborg wrote: > > On Sun, Nov 29, 2020 at 07:28:08PM +0900, Tetsuo Handa wrote: > > > But replacing printk(KERN_DEBUG) with pr_debug() prevents __func__ from being printed > > > when FBCONDEBUG is defined. Is such change what the author of this module expects? > > > > When someone goes and enable DEBUG for fbcon they are also able to > > recognize the logging, so the printing of the function name is redundant > > in this case. > > > > There is likely limited to no use for these few logging entries, but if > > they should be dropped then I expect Peilin Ye to do so as he is the > > only one doing active maintenance of fbcon lately. > > Sure, I will take another look at them. Also sorry for the delay in that > printk() -> dev_*() patch you suggested, overwhelmed by some other > things this week. Sometimes fbcon.c accesses dev structs in a pretty > weird way (e.g. registered_fb[con2fb_map[vc->vc_num]]->dev), I will get > back to it when I understand this better. Please just keep up the good work cleaning up fbcon and related stuff. This is an area that needs some love and care and there is work for many long nights yet to do. Sam _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel