From: Stephen Hemminger <stephen@networkplumber.org>
To: Sarosh Arif <sarosh.arif@emumba.com>
Cc: sthemmin@microsoft.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size
Date: Mon, 30 Nov 2020 08:47:53 -0800 [thread overview]
Message-ID: <20201130084753.1b224419@hermes.local> (raw)
In-Reply-To: <20201130124719.23434-1-sarosh.arif@emumba.com>
On Mon, 30 Nov 2020 17:47:19 +0500
Sarosh Arif <sarosh.arif@emumba.com> wrote:
> - sys.exit('{} is not a valid system huge page size'.format(size))
> -
> + print('{} is not a valid system huge page size'.format(size))
> + show_valid_page_sizes(path)
> + sys.exit()
This is not the same. You should change the helper function to return
a string and do:
sys.exit('Invalid page size. Valid sizes are:', valid_page_sizes())
next prev parent reply other threads:[~2020-11-30 16:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 12:47 [dpdk-dev] [PATCH] usertools: show valid hugepage sizes if user requests an invalid hugepage size Sarosh Arif
2020-11-30 16:46 ` Stephen Hemminger
2020-11-30 16:47 ` Stephen Hemminger [this message]
2020-12-02 11:06 ` [dpdk-dev] [v2 PATCH] " Sarosh Arif
2021-02-05 18:17 ` Thomas Monjalon
2021-02-08 22:12 ` Stephen Hemminger
2021-02-09 11:34 ` Burakov, Anatoly
2021-02-10 6:16 ` [dpdk-dev] [v3 " Sarosh Arif
2021-02-10 17:41 ` Burakov, Anatoly
2021-02-11 8:20 ` [dpdk-dev] [v4 " Sarosh Arif
2021-02-11 16:26 ` Stephen Hemminger
2021-02-11 21:44 ` Thomas Monjalon
2021-02-11 23:16 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130084753.1b224419@hermes.local \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=sarosh.arif@emumba.com \
--cc=sthemmin@microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.