From: Tom Parkin <tparkin@katalix.com>
To: Guillaume Nault <gnault@redhat.com>
Cc: netdev@vger.kernel.org, jchapman@katalix.com
Subject: Re: [PATCH net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls
Date: Mon, 30 Nov 2020 09:59:27 +0000 [thread overview]
Message-ID: <20201130095926.GA4543@katalix.com> (raw)
In-Reply-To: <20201127193134.GA23450@linux.home>
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
On Fri, Nov 27, 2020 at 20:31:34 +0100, Guillaume Nault wrote:
> On Thu, Nov 26, 2020 at 12:24:25PM +0000, Tom Parkin wrote:
> > This new ioctl pair allows two ppp channels to be bridged together:
> > frames arriving in one channel are transmitted in the other channel
> > and vice versa.
>
> Thanks!
> Some comments below (mostly about locking).
Thanks for your review Guillaume. I'll work on integrating your
comments (and a fix for the build test robot warning) into a v2 series.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2020-11-30 10:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 12:24 [PATCH net-next 0/2] add ppp_generic ioctl(s) to bridge channels Tom Parkin
2020-11-26 12:24 ` [PATCH net-next 1/2] ppp: add PPPIOCBRIDGECHAN and PPPIOCUNBRIDGECHAN ioctls Tom Parkin
2020-11-26 14:51 ` kernel test robot
2020-11-26 14:51 ` kernel test robot
2020-11-27 19:31 ` Guillaume Nault
2020-11-30 9:59 ` Tom Parkin [this message]
2020-11-26 12:24 ` [PATCH net-next 2/2] docs: update ppp_generic.rst to document new ioctls Tom Parkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130095926.GA4543@katalix.com \
--to=tparkin@katalix.com \
--cc=gnault@redhat.com \
--cc=jchapman@katalix.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.