From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2924C8300F for ; Mon, 30 Nov 2020 14:29:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B1C120684 for ; Mon, 30 Nov 2020 14:29:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="GxmJyFcf" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727345AbgK3O26 (ORCPT ); Mon, 30 Nov 2020 09:28:58 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727293AbgK3O26 (ORCPT ); Mon, 30 Nov 2020 09:28:58 -0500 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 646BCC0613CF for ; Mon, 30 Nov 2020 06:28:12 -0800 (PST) Received: by mail-wm1-x32d.google.com with SMTP id h21so25395849wmb.2 for ; Mon, 30 Nov 2020 06:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=GxmJyFcfA3iyJchLIAdSSvI7E0OmfEYFUrK5pXEvNYV2KlltBpcpeUpM58TJ+pnt/Q qgLqKKXNkt0UdGY2HBZi2V34IhcYRLIzupD+6vbWa0YWE4aSGD9lx1RGkPulnFfjfEVf SGstAR+EY0GYQINJMGMwNIutwUL3HYTjiCZoLT7Y5PahWav4i3R1snqoi/FREkBfks7p rzYVnSyvEEwORgskQM4nqn4SF+Nlkf1z+iprB3iDJz9um1+Ap9MK8C2yCdoQuET5J94X ffsZQAL9/sIE//unQV6Sk5lkcRe2QvIhaBlI3PTtkX3isgFV9T3f3DPWb/9LSc7V+MIT HB+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=FMp+0NwU7ZVe10Gz1qR/4tVKs1sNDcun/pRldMa9Wl+1DW8hdPpRm3y75g15mwG3x6 JRytPzJbPTpTb4+bzwXUyCowwCW3PHGetfjxqQe3qIhGaY6whyCjetCrv79n3pWG0lep 5ML+F/aFqGBchXj/qpQfz0D1W4xwaNevvI+kIgT9YOABtw+ezDan26HxHcXCgj7Ah3sI BJxScwFdwhFzfwMPn3MQgsoKwXSEr1TI7H9fgoQen/axVJSmEMGPhfDokWfCqDltzSxH UIcevUnVR76WFkDgIOSePDWFiNdKKaDjEkXPzOYtqkm4+Dh9hf2jqUq5CHSPf+Ah8kH0 XPzQ== X-Gm-Message-State: AOAM530KjlAyFyi5LLmvP7Qz5pfpJ+tO5MHdObI2z8todHV47oel4Tu7 5dbv7pbdDPk4rdq3ZWDmtiNHyQ== X-Google-Smtp-Source: ABdhPJxD/5kmfsCYXfU9rpNA3rlWnUqI4oAwPgY2OTtUwo/7XPH2d5ATmi4f+MwHCpZoewNmRC/DsQ== X-Received: by 2002:a7b:c05a:: with SMTP id u26mr23718597wmc.159.1606746491168; Mon, 30 Nov 2020 06:28:11 -0800 (PST) Received: from debian-brgl.home (amarseille-656-1-4-167.w90-8.abo.wanadoo.fr. [90.8.158.167]) by smtp.gmail.com with ESMTPSA id p19sm29446044wrg.18.2020.11.30.06.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 06:28:10 -0800 (PST) From: Bartosz Golaszewski To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek Cc: linux-iio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Subject: [PATH v3 1/3] iio: adc: xilinx: use helper variable for &pdev->dev Date: Mon, 30 Nov 2020 15:27:57 +0100 Message-Id: <20201130142759.28216-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201130142759.28216-1-brgl@bgdev.pl> References: <20201130142759.28216-1-brgl@bgdev.pl> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Bartosz Golaszewski It's more elegant to use a helper local variable to store the address of the underlying struct device than to dereference pdev everywhere. Signed-off-by: Bartosz Golaszewski --- drivers/iio/adc/xilinx-xadc-core.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index f93c34fe5873..8494eb424b33 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -1186,6 +1186,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np, static int xadc_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; const struct of_device_id *id; struct iio_dev *indio_dev; unsigned int bipolar_mask; @@ -1195,10 +1196,10 @@ static int xadc_probe(struct platform_device *pdev) int irq; int i; - if (!pdev->dev.of_node) + if (!dev->of_node) return -ENODEV; - id = of_match_node(xadc_of_match_table, pdev->dev.of_node); + id = of_match_node(xadc_of_match_table, dev->of_node); if (!id) return -EINVAL; @@ -1206,7 +1207,7 @@ static int xadc_probe(struct platform_device *pdev) if (irq <= 0) return -ENXIO; - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*xadc)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*xadc)); if (!indio_dev) return -ENOMEM; @@ -1226,7 +1227,7 @@ static int xadc_probe(struct platform_device *pdev) indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &xadc_info; - ret = xadc_parse_dt(indio_dev, pdev->dev.of_node, &conf0); + ret = xadc_parse_dt(indio_dev, dev->of_node, &conf0); if (ret) return ret; @@ -1250,7 +1251,7 @@ static int xadc_probe(struct platform_device *pdev) } } - xadc->clk = devm_clk_get(&pdev->dev, NULL); + xadc->clk = devm_clk_get(dev, NULL); if (IS_ERR(xadc->clk)) { ret = PTR_ERR(xadc->clk); goto err_free_samplerate_trigger; @@ -1276,7 +1277,7 @@ static int xadc_probe(struct platform_device *pdev) } ret = request_irq(xadc->irq, xadc->ops->interrupt_handler, 0, - dev_name(&pdev->dev), indio_dev); + dev_name(dev), indio_dev); if (ret) goto err_clk_disable_unprepare; -- 2.29.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A30AC64E8A for ; Mon, 30 Nov 2020 14:29:48 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 99546206B6 for ; Mon, 30 Nov 2020 14:29:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AHGi5aAu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=bgdev-pl.20150623.gappssmtp.com header.i=@bgdev-pl.20150623.gappssmtp.com header.b="GxmJyFcf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 99546206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DeghFafAITrCP4aXhN1tng6N7rUAuLdNFy5oMXK+jyY=; b=AHGi5aAu5X9+7HPMClxT2FnhT XZmSAjr369T9mPV5p+FDlWK/y8Qw5Uh2fptL3bZqZ6IHbHE7rcC2DqYITgZb4PlhEg0yaRYgxuca/ pIDywRVLPmDuJ7dpKd16f5TZYjaS4yZdiy+2ang9AVbhBilch3igtsh6ZFbllRyw8a2dQVuH7RRom xWotD5rLGLHaFzl9Q1Q6tgyeLOaQ2JkPKAHmqA+v5mCWaI5mrl9+5sJidvZfEKAXvaAwE+kim9jIU aPOla2n360hqWC70HV07YRiF7vH5PPLHukEkG8Bgdp9GlGEMDWmS9iETw6pm9BoH9osyCuz3agtFu XYbE9/p3g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjkA6-0005Ry-9z; Mon, 30 Nov 2020 14:28:18 +0000 Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjkA2-0005Pq-6P for linux-arm-kernel@lists.infradead.org; Mon, 30 Nov 2020 14:28:15 +0000 Received: by mail-wm1-x336.google.com with SMTP id x22so18643412wmc.5 for ; Mon, 30 Nov 2020 06:28:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=GxmJyFcfA3iyJchLIAdSSvI7E0OmfEYFUrK5pXEvNYV2KlltBpcpeUpM58TJ+pnt/Q qgLqKKXNkt0UdGY2HBZi2V34IhcYRLIzupD+6vbWa0YWE4aSGD9lx1RGkPulnFfjfEVf SGstAR+EY0GYQINJMGMwNIutwUL3HYTjiCZoLT7Y5PahWav4i3R1snqoi/FREkBfks7p rzYVnSyvEEwORgskQM4nqn4SF+Nlkf1z+iprB3iDJz9um1+Ap9MK8C2yCdoQuET5J94X ffsZQAL9/sIE//unQV6Sk5lkcRe2QvIhaBlI3PTtkX3isgFV9T3f3DPWb/9LSc7V+MIT HB+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=oc+CRyq0MP1rGPx6qu4fJIiuXgNVzq5WpNvySKjLu6M=; b=JuO0R7d3rmaxxF2+fa4rKFoYsmq9C4c24PGv+q/usE7Bah0YJA6c6qkGcOgu+EFnZp 9eK3PHKO8oFrhv+4M/8yoy3MFS3Jq8Khe9UeNH+MKifT+rw8/OMmGZ/UY5IqQRrjwFwn 0a2J3Xlxz28wSblgYv2rlx8r/p9x77uOCQQX7QXAk1wJxdjq5pOA11u1pd4t27o2U/Y5 MChR9G88dGnYkU3hwUl+p7A5F4ygwYX6Ip+3/gKiXj8h6PmlalCCtNV+tRA8ebL0b3oo kEo75Zro4zcG+bZQZX834oJeS1es+Aio9xM8KiYk0Raoq6MxPEadp20Hzl4za+Ah+U1G yGsQ== X-Gm-Message-State: AOAM5313y7rHWEkvdCRnIEftNiyKDg8YagKSckqsTYXSY8RcfJsoX3ug GlEpR5KebzCJ5cOSze8dyi8h6g== X-Google-Smtp-Source: ABdhPJxD/5kmfsCYXfU9rpNA3rlWnUqI4oAwPgY2OTtUwo/7XPH2d5ATmi4f+MwHCpZoewNmRC/DsQ== X-Received: by 2002:a7b:c05a:: with SMTP id u26mr23718597wmc.159.1606746491168; Mon, 30 Nov 2020 06:28:11 -0800 (PST) Received: from debian-brgl.home (amarseille-656-1-4-167.w90-8.abo.wanadoo.fr. [90.8.158.167]) by smtp.gmail.com with ESMTPSA id p19sm29446044wrg.18.2020.11.30.06.28.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Nov 2020 06:28:10 -0800 (PST) From: Bartosz Golaszewski To: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald-Stadler , Michal Simek Subject: [PATH v3 1/3] iio: adc: xilinx: use helper variable for &pdev->dev Date: Mon, 30 Nov 2020 15:27:57 +0100 Message-Id: <20201130142759.28216-2-brgl@bgdev.pl> X-Mailer: git-send-email 2.29.1 In-Reply-To: <20201130142759.28216-1-brgl@bgdev.pl> References: <20201130142759.28216-1-brgl@bgdev.pl> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201130_092814_521600_EED72F7D X-CRM114-Status: GOOD ( 15.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-iio@vger.kernel.org, Bartosz Golaszewski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Bartosz Golaszewski It's more elegant to use a helper local variable to store the address of the underlying struct device than to dereference pdev everywhere. Signed-off-by: Bartosz Golaszewski --- drivers/iio/adc/xilinx-xadc-core.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/iio/adc/xilinx-xadc-core.c b/drivers/iio/adc/xilinx-xadc-core.c index f93c34fe5873..8494eb424b33 100644 --- a/drivers/iio/adc/xilinx-xadc-core.c +++ b/drivers/iio/adc/xilinx-xadc-core.c @@ -1186,6 +1186,7 @@ static int xadc_parse_dt(struct iio_dev *indio_dev, struct device_node *np, static int xadc_probe(struct platform_device *pdev) { + struct device *dev = &pdev->dev; const struct of_device_id *id; struct iio_dev *indio_dev; unsigned int bipolar_mask; @@ -1195,10 +1196,10 @@ static int xadc_probe(struct platform_device *pdev) int irq; int i; - if (!pdev->dev.of_node) + if (!dev->of_node) return -ENODEV; - id = of_match_node(xadc_of_match_table, pdev->dev.of_node); + id = of_match_node(xadc_of_match_table, dev->of_node); if (!id) return -EINVAL; @@ -1206,7 +1207,7 @@ static int xadc_probe(struct platform_device *pdev) if (irq <= 0) return -ENXIO; - indio_dev = devm_iio_device_alloc(&pdev->dev, sizeof(*xadc)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*xadc)); if (!indio_dev) return -ENOMEM; @@ -1226,7 +1227,7 @@ static int xadc_probe(struct platform_device *pdev) indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->info = &xadc_info; - ret = xadc_parse_dt(indio_dev, pdev->dev.of_node, &conf0); + ret = xadc_parse_dt(indio_dev, dev->of_node, &conf0); if (ret) return ret; @@ -1250,7 +1251,7 @@ static int xadc_probe(struct platform_device *pdev) } } - xadc->clk = devm_clk_get(&pdev->dev, NULL); + xadc->clk = devm_clk_get(dev, NULL); if (IS_ERR(xadc->clk)) { ret = PTR_ERR(xadc->clk); goto err_free_samplerate_trigger; @@ -1276,7 +1277,7 @@ static int xadc_probe(struct platform_device *pdev) } ret = request_irq(xadc->irq, xadc->ops->interrupt_handler, 0, - dev_name(&pdev->dev), indio_dev); + dev_name(dev), indio_dev); if (ret) goto err_clk_disable_unprepare; -- 2.29.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel