From: Johan Hovold <johan@kernel.org>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Jiri Slaby <jirislaby@kernel.org>,
"Mychaela N . Falconia" <falcon@freecalypso.org>,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Johan Hovold <johan@kernel.org>
Subject: [PATCH 3/5] USB: serial: add sysfs attribute to suppress ready signalling on open
Date: Mon, 30 Nov 2020 16:37:40 +0100 [thread overview]
Message-ID: <20201130153742.9163-4-johan@kernel.org> (raw)
In-Reply-To: <20201130153742.9163-1-johan@kernel.org>
Add a nordy sysfs attribute to suppress raising the modem-control lines
on open to signal DTE readiness.
This can be use to prevent undesirable side-effects on open for
applications where the DTR and RTS lines are used for non-standard
purposes such as generating power-on and reset pulses.
Signed-off-by: Johan Hovold <johan@kernel.org>
---
drivers/usb/serial/bus.c | 38 ++++++++++++++++++++++++++++++++++++--
1 file changed, 36 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/serial/bus.c b/drivers/usb/serial/bus.c
index eb0195cf37dd..37bbeab6666e 100644
--- a/drivers/usb/serial/bus.c
+++ b/drivers/usb/serial/bus.c
@@ -35,6 +35,40 @@ static int usb_serial_device_match(struct device *dev,
return 0;
}
+static ssize_t nordy_show(struct device *dev, struct device_attribute *attr,
+ char *buf)
+{
+ struct usb_serial_port *port = dev_get_drvdata(dev);
+
+ return sprintf(buf, "%d\n", tty_port_nordy(&port->port));
+}
+
+static ssize_t nordy_store(struct device *dev, struct device_attribute *attr,
+ const char *buf, size_t count)
+{
+ struct usb_serial_port *port = dev_get_drvdata(dev);
+ unsigned int val;
+ int ret;
+
+ ret = kstrtouint(buf, 0, &val);
+ if (ret)
+ return ret;
+
+ if (val > 1)
+ return -EINVAL;
+
+ tty_port_set_nordy(&port->port, val);
+
+ return count;
+}
+static DEVICE_ATTR_RW(nordy);
+
+static struct attribute *tty_attrs[] = {
+ &dev_attr_nordy.attr,
+ NULL
+};
+ATTRIBUTE_GROUPS(tty);
+
static int usb_serial_device_probe(struct device *dev)
{
struct usb_serial_driver *driver;
@@ -60,8 +94,8 @@ static int usb_serial_device_probe(struct device *dev)
}
minor = port->minor;
- tty_dev = tty_port_register_device(&port->port, usb_serial_tty_driver,
- minor, dev);
+ tty_dev = tty_port_register_device_attr(&port->port,
+ usb_serial_tty_driver, minor, dev, port, tty_groups);
if (IS_ERR(tty_dev)) {
retval = PTR_ERR(tty_dev);
goto err_port_remove;
--
2.26.2
next prev parent reply other threads:[~2020-11-30 15:38 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 15:37 [PATCH 0/5] tty: add flag to suppress ready signalling on open Johan Hovold
2020-11-30 15:37 ` [PATCH 1/5] tty: add port " Johan Hovold
2020-11-30 23:36 ` Mychaela Falconia
2020-12-01 5:49 ` Jiri Slaby
2020-12-01 7:09 ` Mychaela Falconia
2020-12-01 7:16 ` Jiri Slaby
2020-12-01 8:46 ` Johan Hovold
2020-11-30 15:37 ` [PATCH 2/5] serial: core: add sysfs attribute " Johan Hovold
2020-11-30 18:27 ` Andy Shevchenko
2020-12-01 8:21 ` Johan Hovold
2020-12-01 10:55 ` Andy Shevchenko
2020-12-01 11:05 ` Johan Hovold
2020-12-01 11:19 ` Andy Shevchenko
2020-12-01 13:22 ` Johan Hovold
2020-12-01 13:49 ` Andy Shevchenko
2020-12-01 17:43 ` Johan Hovold
2020-12-01 16:44 ` Greg Kroah-Hartman
2020-12-01 17:24 ` Johan Hovold
2020-11-30 15:37 ` Johan Hovold [this message]
2020-11-30 18:29 ` [PATCH 3/5] USB: serial: " Andy Shevchenko
2020-11-30 15:37 ` [PATCH 4/5] USB: serial: ftdi_sio: pass port to quirk port_probe functions Johan Hovold
2020-11-30 15:37 ` [PATCH 5/5] USB: serial: ftdi_sio: add support for FreeCalypso DUART28C adapter Johan Hovold
2020-12-01 6:54 ` Jiri Slaby
2020-12-01 8:55 ` Johan Hovold
2020-11-30 21:22 ` [PATCH 0/5] tty: add flag to suppress ready signalling on open Mychaela Falconia
2020-12-01 7:14 ` Jiri Slaby
2020-12-01 7:18 ` Mychaela Falconia
2020-12-02 11:48 ` Johan Hovold
2020-12-04 6:58 ` Jiri Slaby
2020-12-08 9:30 ` Johan Hovold
2020-12-01 8:40 ` Johan Hovold
2020-12-01 10:48 ` Andy Shevchenko
2020-12-01 10:58 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201130153742.9163-4-johan@kernel.org \
--to=johan@kernel.org \
--cc=falcon@freecalypso.org \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.