All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
	linux@armlinux.org.uk, nicolas.ferre@microchip.com,
	alexandre.belloni@bootlin.com, ludovic.desroches@microchip.com,
	tony@atomide.com, mripard@kernel.org, wens@csie.org,
	jernej.skrabec@siol.net, thierry.reding@gmail.com,
	jonathanh@nvidia.com, catalin.marinas@arm.com, will@kernel.org,
	tsbogend@alpha.franken.de, James.Bottomley@hansenpartnership.com,
	deller@gmx.de, mpe@ellerman.id.au, benh@kernel.crashing.org,
	paulus@samba.org, lee.jones@linaro.org, emil.l.velikov@gmail.com,
	daniel.thompson@linaro.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org,
	linux-tegra@vger.kernel.org, linux-mips@vger.kernel.org,
	linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 0/5] drop unused BACKLIGHT_GENERIC option
Date: Mon, 30 Nov 2020 22:16:00 +0100	[thread overview]
Message-ID: <20201130211600.GA1779005@ravnborg.org> (raw)
In-Reply-To: <20201130202501.GA32878@kozik-lap>

Hi Krzysztof,
On Mon, Nov 30, 2020 at 10:25:01PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Nov 30, 2020 at 08:11:33PM +0100, Sam Ravnborg wrote:
> > On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> > > Since the removal of generic_bl driver from the source tree in commit
> > > 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> > > unused") BACKLIGHT_GENERIC config option became obsolete as well and
> > > therefore subject to clean-up from all configuration files.
> > > 
> > > This series introduces patches to address this removal, separated by
> > > architectures in the kernel tree.
> > > 
> > > Andrey Zhizhikin (5):
> > >   ARM: configs: drop unused BACKLIGHT_GENERIC option
> > >   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
> > >   MIPS: configs: drop unused BACKLIGHT_GENERIC option
> > >   parisc: configs: drop unused BACKLIGHT_GENERIC option
> > >   powerpc/configs: drop unused BACKLIGHT_GENERIC option
> > 
> > For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
> > savedefconfig / cp defconfig ... run now and then - this will remove
> > all such symbols.
> 
> savedefconfig can be tricky because of risk of loosing options:
> 1. it will remove options which became the default or became selected,
> 2. later when the default is changed or selecting option is removed, the
>    first option from #1 will not be brought back.
> 
> This was already for example with DEBUG_FS and the conclusion that time
> was - do not run savedefconfig automatically.
> 
> Therefore if some symbol(s) can be safely removed, patch is welcomed.

Thanks for letting me know, I have missed that discussion and
was obviously not aware.
I already acked'ed the patches and hope the soc people will pick them
up.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: alexandre.belloni@bootlin.com, tony@atomide.com,
	linux-kernel@vger.kernel.org,
	James.Bottomley@hansenpartnership.com, thierry.reding@gmail.com,
	paulus@samba.org, lee.jones@linaro.org,
	daniel.thompson@linaro.org, linux-omap@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	deller@gmx.de, linux@armlinux.org.uk, jonathanh@nvidia.com,
	ludovic.desroches@microchip.com, catalin.marinas@arm.com,
	linux-mips@vger.kernel.org, will@kernel.org, mripard@kernel.org,
	Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
	linux-tegra@vger.kernel.org, wens@csie.org,
	linux-arm-kernel@lists.infradead.org, jernej.skrabec@siol.net,
	tsbogend@alpha.franken.de, linux-parisc@vger.kernel.org,
	emil.l.velikov@gmail.com, nicolas.ferre@microchip.com,
	Olof Johansson <olof@lixom.net>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/5] drop unused BACKLIGHT_GENERIC option
Date: Mon, 30 Nov 2020 22:16:00 +0100	[thread overview]
Message-ID: <20201130211600.GA1779005@ravnborg.org> (raw)
In-Reply-To: <20201130202501.GA32878@kozik-lap>

Hi Krzysztof,
On Mon, Nov 30, 2020 at 10:25:01PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Nov 30, 2020 at 08:11:33PM +0100, Sam Ravnborg wrote:
> > On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> > > Since the removal of generic_bl driver from the source tree in commit
> > > 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> > > unused") BACKLIGHT_GENERIC config option became obsolete as well and
> > > therefore subject to clean-up from all configuration files.
> > > 
> > > This series introduces patches to address this removal, separated by
> > > architectures in the kernel tree.
> > > 
> > > Andrey Zhizhikin (5):
> > >   ARM: configs: drop unused BACKLIGHT_GENERIC option
> > >   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
> > >   MIPS: configs: drop unused BACKLIGHT_GENERIC option
> > >   parisc: configs: drop unused BACKLIGHT_GENERIC option
> > >   powerpc/configs: drop unused BACKLIGHT_GENERIC option
> > 
> > For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
> > savedefconfig / cp defconfig ... run now and then - this will remove
> > all such symbols.
> 
> savedefconfig can be tricky because of risk of loosing options:
> 1. it will remove options which became the default or became selected,
> 2. later when the default is changed or selecting option is removed, the
>    first option from #1 will not be brought back.
> 
> This was already for example with DEBUG_FS and the conclusion that time
> was - do not run savedefconfig automatically.
> 
> Therefore if some symbol(s) can be safely removed, patch is welcomed.

Thanks for letting me know, I have missed that discussion and
was obviously not aware.
I already acked'ed the patches and hope the soc people will pick them
up.

	Sam

WARNING: multiple messages have this Message-ID (diff)
From: Sam Ravnborg <sam@ravnborg.org>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: alexandre.belloni@bootlin.com, tony@atomide.com,
	benh@kernel.crashing.org, linux-kernel@vger.kernel.org,
	James.Bottomley@hansenpartnership.com, thierry.reding@gmail.com,
	paulus@samba.org, lee.jones@linaro.org,
	daniel.thompson@linaro.org, linux-omap@vger.kernel.org,
	Arnd Bergmann <arnd@arndb.de>,
	mpe@ellerman.id.au, deller@gmx.de, linux@armlinux.org.uk,
	jonathanh@nvidia.com, ludovic.desroches@microchip.com,
	catalin.marinas@arm.com, linux-mips@vger.kernel.org,
	will@kernel.org, mripard@kernel.org,
	Andrey Zhizhikin <andrey.zhizhikin@leica-geosystems.com>,
	linux-tegra@vger.kernel.org, wens@csie.org,
	linux-arm-kernel@lists.infradead.org, jernej.skrabec@siol.net,
	tsbogend@alpha.franken.de, linux-parisc@vger.kernel.org,
	emil.l.velikov@gmail.com, Olof Johansson <olof@lixom.net>,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 0/5] drop unused BACKLIGHT_GENERIC option
Date: Mon, 30 Nov 2020 22:16:00 +0100	[thread overview]
Message-ID: <20201130211600.GA1779005@ravnborg.org> (raw)
In-Reply-To: <20201130202501.GA32878@kozik-lap>

Hi Krzysztof,
On Mon, Nov 30, 2020 at 10:25:01PM +0200, Krzysztof Kozlowski wrote:
> On Mon, Nov 30, 2020 at 08:11:33PM +0100, Sam Ravnborg wrote:
> > On Mon, Nov 30, 2020 at 03:21:32PM +0000, Andrey Zhizhikin wrote:
> > > Since the removal of generic_bl driver from the source tree in commit
> > > 7ecdea4a0226 ("backlight: generic_bl: Remove this driver as it is
> > > unused") BACKLIGHT_GENERIC config option became obsolete as well and
> > > therefore subject to clean-up from all configuration files.
> > > 
> > > This series introduces patches to address this removal, separated by
> > > architectures in the kernel tree.
> > > 
> > > Andrey Zhizhikin (5):
> > >   ARM: configs: drop unused BACKLIGHT_GENERIC option
> > >   arm64: defconfig: drop unused BACKLIGHT_GENERIC option
> > >   MIPS: configs: drop unused BACKLIGHT_GENERIC option
> > >   parisc: configs: drop unused BACKLIGHT_GENERIC option
> > >   powerpc/configs: drop unused BACKLIGHT_GENERIC option
> > 
> > For defconfigs I expect arch maintainers to do a make xxxdefconfig / make
> > savedefconfig / cp defconfig ... run now and then - this will remove
> > all such symbols.
> 
> savedefconfig can be tricky because of risk of loosing options:
> 1. it will remove options which became the default or became selected,
> 2. later when the default is changed or selecting option is removed, the
>    first option from #1 will not be brought back.
> 
> This was already for example with DEBUG_FS and the conclusion that time
> was - do not run savedefconfig automatically.
> 
> Therefore if some symbol(s) can be safely removed, patch is welcomed.

Thanks for letting me know, I have missed that discussion and
was obviously not aware.
I already acked'ed the patches and hope the soc people will pick them
up.

	Sam

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-11-30 21:17 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-30 15:21 [PATCH 0/5] drop unused BACKLIGHT_GENERIC option Andrey Zhizhikin
2020-11-30 15:21 ` Andrey Zhizhikin
2020-11-30 15:21 ` [PATCH 1/5] ARM: configs: " Andrey Zhizhikin
2020-11-30 15:21   ` Andrey Zhizhikin
2020-11-30 15:37   ` Alexandre Belloni
2020-11-30 15:37     ` Alexandre Belloni
2020-11-30 15:37     ` Alexandre Belloni
2020-11-30 18:52   ` Krzysztof Kozlowski
2020-11-30 18:52     ` Krzysztof Kozlowski
2020-11-30 18:52     ` Krzysztof Kozlowski
2020-11-30 19:50     ` ZHIZHIKIN Andrey
2020-11-30 19:50       ` ZHIZHIKIN Andrey
2020-11-30 19:50       ` ZHIZHIKIN Andrey
2020-12-01 14:40       ` Catalin Marinas
2020-12-01 14:40         ` Catalin Marinas
2020-12-01 14:40         ` Catalin Marinas
2020-12-01 15:41         ` Alexandre Belloni
2020-12-01 15:41           ` Alexandre Belloni
2020-12-01 15:41           ` Alexandre Belloni
2020-12-01 15:50           ` Arnd Bergmann
2020-12-01 15:50             ` Arnd Bergmann
2020-12-01 15:50             ` Arnd Bergmann
2020-12-01 19:48             ` ZHIZHIKIN Andrey
2020-12-01 19:48               ` ZHIZHIKIN Andrey
2020-12-01 19:48               ` ZHIZHIKIN Andrey
2020-12-01 20:44               ` Arnd Bergmann
2020-12-01 20:44                 ` Arnd Bergmann
2020-12-01 20:44                 ` Arnd Bergmann
2020-12-01 21:18             ` Krzysztof Kozlowski
2020-12-01 21:18               ` Krzysztof Kozlowski
2020-12-01 21:18               ` Krzysztof Kozlowski
2020-11-30 15:21 ` [PATCH 2/5] arm64: defconfig: " Andrey Zhizhikin
2020-11-30 15:21   ` Andrey Zhizhikin
2020-11-30 18:53   ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-11-30 15:21 ` [PATCH 3/5] MIPS: configs: " Andrey Zhizhikin
2020-11-30 15:21   ` Andrey Zhizhikin
2020-11-30 18:53   ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-11-30 15:21 ` [PATCH 4/5] parisc: " Andrey Zhizhikin
2020-11-30 15:21   ` Andrey Zhizhikin
2020-11-30 18:53   ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-11-30 15:21 ` [PATCH 5/5] powerpc/configs: " Andrey Zhizhikin
2020-11-30 15:21   ` Andrey Zhizhikin
2020-11-30 18:53   ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-11-30 18:53     ` Krzysztof Kozlowski
2020-12-01  0:46   ` Michael Ellerman
2020-12-01  0:46     ` Michael Ellerman
2020-11-30 19:11 ` [PATCH 0/5] " Sam Ravnborg
2020-11-30 19:11   ` Sam Ravnborg
2020-11-30 19:11   ` Sam Ravnborg
2020-11-30 19:56   ` ZHIZHIKIN Andrey
2020-11-30 19:56     ` ZHIZHIKIN Andrey
2020-11-30 19:56     ` ZHIZHIKIN Andrey
2020-11-30 20:25   ` Krzysztof Kozlowski
2020-11-30 20:25     ` Krzysztof Kozlowski
2020-11-30 20:25     ` Krzysztof Kozlowski
2020-11-30 21:16     ` Sam Ravnborg [this message]
2020-11-30 21:16       ` Sam Ravnborg
2020-11-30 21:16       ` Sam Ravnborg
2020-12-01 10:05 ` Daniel Thompson
2020-12-01 10:05   ` Daniel Thompson
2020-12-01 10:05   ` Daniel Thompson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201130211600.GA1779005@ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=James.Bottomley@hansenpartnership.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=andrey.zhizhikin@leica-geosystems.com \
    --cc=arnd@arndb.de \
    --cc=benh@kernel.crashing.org \
    --cc=catalin.marinas@arm.com \
    --cc=daniel.thompson@linaro.org \
    --cc=deller@gmx.de \
    --cc=emil.l.velikov@gmail.com \
    --cc=jernej.skrabec@siol.net \
    --cc=jonathanh@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=lee.jones@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mips@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-parisc@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=ludovic.desroches@microchip.com \
    --cc=mpe@ellerman.id.au \
    --cc=mripard@kernel.org \
    --cc=nicolas.ferre@microchip.com \
    --cc=olof@lixom.net \
    --cc=paulus@samba.org \
    --cc=thierry.reding@gmail.com \
    --cc=tony@atomide.com \
    --cc=tsbogend@alpha.franken.de \
    --cc=wens@csie.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.