From: kernel test robot <lkp@intel.com>
To: kbuild@lists.01.org
Subject: Re: [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes()
Date: Tue, 01 Dec 2020 01:43:29 +0800 [thread overview]
Message-ID: <202012010135.F6EVBwrK-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 3390 bytes --]
CC: kbuild-all(a)lists.01.org
In-Reply-To: <20201130133129.1024662-7-djrscally@gmail.com>
References: <20201130133129.1024662-7-djrscally@gmail.com>
TO: Daniel Scally <djrscally@gmail.com>
TO: linux-kernel(a)vger.kernel.org
TO: linux-acpi(a)vger.kernel.org
TO: linux-gpio(a)vger.kernel.org
TO: linux-i2c(a)vger.kernel.org
TO: linux-media(a)vger.kernel.org
TO: devel(a)acpica.org
CC: rjw(a)rjwysocki.net
CC: lenb(a)kernel.org
CC: gregkh(a)linuxfoundation.org
CC: mika.westerberg(a)linux.intel.com
Hi Daniel,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linuxtv-media/master]
[also build test WARNING on driver-core/driver-core-testing pm/linux-next v5.10-rc6 next-20201130]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/0day-ci/linux/commits/Daniel-Scally/Add-functionality-to-ipu3-cio2-driver-allowing-software_node-connections-to-sensors-on-platforms-designed-for-Windows/20201130-214014
base: git://linuxtv.org/media_tree.git master
:::::: branch date: 4 hours ago
:::::: commit date: 4 hours ago
config: i386-randconfig-m021-20201130 (attached as .config)
compiler: gcc-9 (Debian 9.3.0-15) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
smatch warnings:
drivers/base/swnode.c:785 software_node_unregister_node_group() error: uninitialized symbol 'i'.
vim +/i +785 drivers/base/swnode.c
02094d54870590a Andy Shevchenko 2020-04-08 771
02094d54870590a Andy Shevchenko 2020-04-08 772 /**
02094d54870590a Andy Shevchenko 2020-04-08 773 * software_node_unregister_node_group - Unregister a group of software nodes
02094d54870590a Andy Shevchenko 2020-04-08 774 * @node_group: NULL terminated array of software node pointers to be unregistered
02094d54870590a Andy Shevchenko 2020-04-08 775 *
02094d54870590a Andy Shevchenko 2020-04-08 776 * Unregister multiple software nodes at once.
02094d54870590a Andy Shevchenko 2020-04-08 777 */
02094d54870590a Andy Shevchenko 2020-04-08 778 void software_node_unregister_node_group(const struct software_node **node_group)
02094d54870590a Andy Shevchenko 2020-04-08 779 {
02094d54870590a Andy Shevchenko 2020-04-08 780 unsigned int i;
02094d54870590a Andy Shevchenko 2020-04-08 781
02094d54870590a Andy Shevchenko 2020-04-08 782 if (!node_group)
02094d54870590a Andy Shevchenko 2020-04-08 783 return;
02094d54870590a Andy Shevchenko 2020-04-08 784
7c7577c82672f0a Daniel Scally 2020-11-30 @785 while (node_group[i]->name)
7c7577c82672f0a Daniel Scally 2020-11-30 786 i++;
7c7577c82672f0a Daniel Scally 2020-11-30 787
7c7577c82672f0a Daniel Scally 2020-11-30 788 while (i--)
9dcbac84244f32e Andy Shevchenko 2020-06-22 789 software_node_unregister(node_group[i]);
02094d54870590a Andy Shevchenko 2020-04-08 790 }
02094d54870590a Andy Shevchenko 2020-04-08 791 EXPORT_SYMBOL_GPL(software_node_unregister_node_group);
02094d54870590a Andy Shevchenko 2020-04-08 792
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 32286 bytes --]
next reply other threads:[~2020-11-30 17:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-30 17:43 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2020-11-30 13:31 [PATCH 00/18] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows Daniel Scally
2020-11-30 13:31 ` [PATCH 06/18] software_node: amend software_node_unregister_node_group() to perform unregistration of array in reverse order to be consistent with software_node_unregister_nodes() Daniel Scally
2020-11-30 16:17 ` Laurent Pinchart
2020-11-30 17:47 ` Andy Shevchenko
2020-12-02 10:04 ` Dan Scally
2020-11-30 17:19 ` kernel test robot
2020-11-30 17:19 ` kernel test robot
2020-12-01 18:18 ` Dan Carpenter
2020-12-01 18:18 ` Dan Carpenter
2020-12-01 18:18 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012010135.F6EVBwrK-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.