From: Jason Gunthorpe <jgg@ziepe.ca>
To: Weihang Li <liweihang@huawei.com>
Cc: dledford@redhat.com, leon@kernel.org, linux-rdma@vger.kernel.org,
linuxarm@huawei.com
Subject: Re: [PATCH for-next] RDMA/hns: Move capability flags of QP and CQ to hns-abi.h
Date: Tue, 1 Dec 2020 09:43:41 -0400 [thread overview]
Message-ID: <20201201134341.GD5487@ziepe.ca> (raw)
In-Reply-To: <1606829024-51856-1-git-send-email-liweihang@huawei.com>
On Tue, Dec 01, 2020 at 09:23:44PM +0800, Weihang Li wrote:
> diff --git a/include/uapi/rdma/hns-abi.h b/include/uapi/rdma/hns-abi.h
> index 9ec85f7..2dd5fa07 100644
> +++ b/include/uapi/rdma/hns-abi.h
> @@ -43,6 +43,10 @@ struct hns_roce_ib_create_cq {
> __u32 reserved;
> };
>
> +enum hns_roce_cq_cap_flags {
> + HNS_ROCE_CQ_FLAG_RECORD_DB = BIT(0),
> +};
> +
> struct hns_roce_ib_create_cq_resp {
> __aligned_u64 cqn; /* Only 32 bits used, 64 for compat */
> __aligned_u64 cap_flags;
> @@ -69,6 +73,12 @@ struct hns_roce_ib_create_qp {
> __aligned_u64 sdb_addr;
> };
>
> +enum hns_roce_qp_cap_flags {
> + HNS_ROCE_QP_CAP_RQ_RECORD_DB = BIT(0),
> + HNS_ROCE_QP_CAP_SQ_RECORD_DB = BIT(1),
> + HNS_ROCE_QP_CAP_OWNER_DB = BIT(2),
> +};
Don't use BIT in uapi headers
Jason
next prev parent reply other threads:[~2020-12-01 13:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 13:23 [PATCH for-next] RDMA/hns: Move capability flags of QP and CQ to hns-abi.h Weihang Li
2020-12-01 13:43 ` Jason Gunthorpe [this message]
2020-12-02 1:09 ` liweihang
2020-12-01 16:11 ` kernel test robot
2020-12-01 16:11 ` kernel test robot
2020-12-01 19:37 ` kernel test robot
2020-12-01 19:37 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201134341.GD5487@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=dledford@redhat.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=liweihang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.