From: Brother Matthew De Angelis <matthew.v.deangelis@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] Staging: rtl8723bs/core fix brace coding style issue in rtw_ioctl_set.c.
Date: Tue, 01 Dec 2020 21:49:15 +0000 [thread overview]
Message-ID: <20201201214915.GA397311@a> (raw)
Fix a brace warning found by the checkpatch.pl tool at line 178.
WARNING: braces {} are not necessary for any arm of this statement.
Signed-off-by: Brother Matthew De Angelis <matthew.v.deangelis@gmail.com>
---
drivers/staging/rtl8723bs/core/rtw_ioctl_set.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
index 3adeca6f20ec..a7aa689ef4d4 100644
--- a/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
+++ b/drivers/staging/rtl8723bs/core/rtw_ioctl_set.c
@@ -175,11 +175,10 @@ u8 rtw_set_802_11_bssid(struct adapter *padapter, u8 *bssid)
DBG_871X("Set BSSID under fw_state = 0x%08x\n", get_fwstate(pmlmepriv));
- if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) = true) {
+ if (check_fwstate(pmlmepriv, _FW_UNDER_SURVEY) = true)
goto handle_tkip_countermeasure;
- } else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) = true) {
+ else if (check_fwstate(pmlmepriv, _FW_UNDER_LINKING) = true)
goto release_mlme_lock;
- }
if (check_fwstate(pmlmepriv, _FW_LINKED|WIFI_ADHOC_MASTER_STATE) = true) {
RT_TRACE(_module_rtl871x_ioctl_set_c_, _drv_info_, ("set_bssid: _FW_LINKED||WIFI_ADHOC_MASTER_STATE\n"));
--
2.25.1
My apologies, I meant to sent this.
Would a patch like this be worth Greg's time?
next reply other threads:[~2020-12-01 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 21:49 Brother Matthew De Angelis [this message]
2020-12-02 6:42 ` [PATCH] Staging: rtl8723bs/core fix brace coding style issue in rtw_ioctl_set.c Dan Carpenter
2020-12-02 8:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201201214915.GA397311@a \
--to=matthew.v.deangelis@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.