From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0225301463732186700==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] kernel[v2]: fix ifnullfree.cocci warnings Date: Wed, 02 Dec 2020 16:05:25 +0800 Message-ID: <20201202080525.GA22671@9017113e4702> In-Reply-To: <202012021616.gPrU53Bb-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============0225301463732186700== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org TO: Yuan Liu CC: "Qin, Chao" CC: Yonghua Huang CC: "Michael S. Tsirkin" CC: "Greg Kroah-Hartman" CC: kvm(a)vger.kernel.org CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/uio/uio_pci_generic.c:247:2-7: WARNING: NULL check before some free= ing functions is not needed. drivers/uio/uio_pci_generic.c:264:2-7: WARNING: NULL check before some free= ing functions is not needed. NULL check before some freeing functions is not needed. Based on checkpatch warning "kfree(NULL) is safe this check is probably not required" and kfreeaddr.cocci by Julia Lawall. Generated by: scripts/coccinelle/free/ifnullfree.cocci Fixes: 709a04896cb6 ("kernel[v2]: extend uio driver to supports msix") CC: Yuan Liu Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://github.com/intel/linux-intel-lts.git 5.4/yocto head: 709a04896cb6ab56a8ce54575f2cc4d346d71dea commit: 709a04896cb6ab56a8ce54575f2cc4d346d71dea [11/11] kernel[v2]: extend= uio driver to supports msix :::::: branch date: 6 days ago :::::: commit date: 6 days ago Please take the patch only if it's a positive warning. Thanks! uio_pci_generic.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) --- a/drivers/uio/uio_pci_generic.c +++ b/drivers/uio/uio_pci_generic.c @@ -243,8 +243,7 @@ static int probe(struct pci_dev *pdev, = err_register: #ifdef CONFIG_PCI_MSI - if (gdev->msix_info.entries !=3D NULL) - kfree(gdev->msix_info.entries); + kfree(gdev->msix_info.entries); #endif kfree(gdev); err_alloc: @@ -260,8 +259,7 @@ static void remove(struct pci_dev *pdev) uio_unregister_device(&gdev->info); pci_disable_device(pdev); #ifdef CONFIG_PCI_MSI - if (gdev->msix_info.entries !=3D NULL) - kfree(gdev->msix_info.entries); + kfree(gdev->msix_info.entries); #endif kfree(gdev); } --===============0225301463732186700==--