From: Krzysztof Kozlowski <krzk@kernel.org>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: linux-rtc@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH 2/2] rtc: s3c: Remove dead code related to periodic tick handling
Date: Wed, 2 Dec 2020 14:56:18 +0200 [thread overview]
Message-ID: <20201202125618.GC36340@kozik-lap> (raw)
In-Reply-To: <6f29a418-6a96-4b4b-c2c4-3722f3ad9895@samsung.com>
On Wed, Dec 02, 2020 at 01:54:32PM +0100, Marek Szyprowski wrote:
> Hi Krzysztof,
>
> On 02.12.2020 13:49, Krzysztof Kozlowski wrote:
> > On Wed, Dec 02, 2020 at 12:13:18PM +0100, Marek Szyprowski wrote:
> >> Support for periodic tick interrupts has been moved from the RTC class to
> >> the HR-timers long time ago. Then it has been removed from this driver by
> >> commits 80d4bb515b78 ("RTC: Cleanup rtc_class_ops->irq_set_state") and
> >> 696160fec162 ("RTC: Cleanup rtc_class_ops->irq_set_freq()"). They however
> >> did not remove all the code related to the tick handling. Do it now then.
> >>
> > Update also the bindings (one IRQ less), please.
> >
> > Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
>
> Well, in theory bindings describe the hardware not the drivers. Hardware
> is still capable of triggering the periodic tick interrupt. It is just a
> Linux kernel policy not to use it at all...
Good point. It will however mean that all DTS (including new) will still
have to provide the tick IRQ. I am fine with this.
Best regards,
Krzysztof
next prev parent reply other threads:[~2020-12-02 12:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20201202111328eucas1p25b7a68b4fe94addf6088cc3ad4bedcf1@eucas1p2.samsung.com>
2020-12-02 11:13 ` [PATCH 1/2] rtc: s3c: Disable all enable (RTC, tick) bits in the probe Marek Szyprowski
2020-12-02 11:13 ` [PATCH 2/2] rtc: s3c: Remove dead code related to periodic tick handling Marek Szyprowski
2020-12-02 12:49 ` Krzysztof Kozlowski
2020-12-02 12:54 ` Marek Szyprowski
2020-12-02 12:56 ` Krzysztof Kozlowski [this message]
2020-12-02 12:38 ` [PATCH 1/2] rtc: s3c: Disable all enable (RTC, tick) bits in the probe Krzysztof Kozlowski
2020-12-03 22:52 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202125618.GC36340@kozik-lap \
--to=krzk@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.