From: Lukas Straub <lukasstraub2@web.de>
To: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
Cc: "Kevin Wolf" <kwolf@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
qemu-block <qemu-block@nongnu.org>,
"Juan Quintela" <quintela@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
qemu-devel <qemu-devel@nongnu.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Max Reitz" <mreitz@redhat.com>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v11 2/7] block/nbd.c: Add yank feature
Date: Wed, 2 Dec 2020 13:34:36 +0100 [thread overview]
Message-ID: <20201202133436.45df98f4@luklap> (raw)
In-Reply-To: <aa30fc7e-5817-6986-54a7-56731e8c043f@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
On Wed, 2 Dec 2020 15:18:48 +0300
Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com> wrote:
> 15.11.2020 14:36, Lukas Straub wrote:
> > Register a yank function which shuts down the socket and sets
> > s->state = NBD_CLIENT_QUIT. This is the same behaviour as if an
> > error occured.
> >
> > Signed-off-by: Lukas Straub<lukasstraub2@web.de>
> > Acked-by: Stefan Hajnoczi<stefanha@redhat.com>
>
> Hi! Could I ask, what's the reason for qatomic_load_acquire access to s->state? Is there same bug fixed? Or is it related somehow to new feature?
>
Hi,
This is for the new feature, as the yank function runs in a separate thread.
Regards,
Lukas Straub
--
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-02 12:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-15 11:35 [PATCH v11 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu Lukas Straub
2020-11-15 11:36 ` [PATCH v11 1/7] Introduce yank feature Lukas Straub
2020-12-01 20:43 ` Eric Blake
2020-12-01 21:05 ` Eric Blake
2020-11-15 11:36 ` [PATCH v11 2/7] block/nbd.c: Add " Lukas Straub
2020-12-01 20:50 ` Eric Blake
2020-12-02 12:18 ` Vladimir Sementsov-Ogievskiy
2020-12-02 12:34 ` Lukas Straub [this message]
2020-11-15 11:36 ` [PATCH v11 3/7] chardev/char-socket.c: " Lukas Straub
2020-11-15 11:36 ` [PATCH v11 4/7] migration: " Lukas Straub
2020-11-15 11:36 ` [PATCH v11 5/7] io/channel-tls.c: make qio_channel_tls_shutdown thread-safe Lukas Straub
2020-11-15 11:36 ` [PATCH v11 6/7] io: Document qmp oob suitability of qio_channel_shutdown and io_shutdown Lukas Straub
2020-11-15 11:36 ` [PATCH v11 7/7] tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test Lukas Straub
2020-12-01 16:34 ` [PATCH v11 0/7] Introduce 'yank' oob qmp command to recover from hanging qemu Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202133436.45df98f4@luklap \
--to=lukasstraub2@web.de \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=kwolf@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=vsementsov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.