From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFD90C64E7B for ; Wed, 2 Dec 2020 16:26:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69A4521D7A for ; Wed, 2 Dec 2020 16:26:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387435AbgLBQ0e (ORCPT ); Wed, 2 Dec 2020 11:26:34 -0500 Received: from verein.lst.de ([213.95.11.211]:54909 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726670AbgLBQ0e (ORCPT ); Wed, 2 Dec 2020 11:26:34 -0500 Received: by verein.lst.de (Postfix, from userid 2407) id E9AAF67373; Wed, 2 Dec 2020 17:25:52 +0100 (CET) Date: Wed, 2 Dec 2020 17:25:52 +0100 From: Christoph Hellwig To: Hannes Reinecke Cc: "Martin K. Petersen" , James Bottomley , Christoph Hellwig , linux-scsi@vger.kernel.org Subject: Re: [PATCH 15/34] aacraid: avoid setting message byte on completion Message-ID: <20201202162552.GJ32254@lst.de> References: <20201202115249.37690-1-hare@suse.de> <20201202115249.37690-16-hare@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201202115249.37690-16-hare@suse.de> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: linux-scsi@vger.kernel.org On Wed, Dec 02, 2020 at 12:52:30PM +0100, Hannes Reinecke wrote: > The aacraid controller is a RAID controller, and the driver will > never see any SCSI messages. Plus it's quite pointless to set > the message byte if the host byte is already set, as the latter > takes precedence during error recovery. > So drop the message byte values for the final result. Looks good, Reviewed-by: Christoph Hellwig