From: Jarkko Sakkinen <jarkko@kernel.org>
To: Joe Perches <joe@perches.com>
Cc: trix@redhat.com, dhowells@redhat.com, keyrings@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] keys: remove trailing semicolon in macro definition
Date: Wed, 2 Dec 2020 18:45:55 +0200 [thread overview]
Message-ID: <20201202164555.GB91162@kernel.org> (raw)
In-Reply-To: <d9e5515497f5215294cf79bec973155d0132f25e.camel@perches.com>
On Sat, Nov 28, 2020 at 09:30:44PM -0800, Joe Perches wrote:
> On Sun, 2020-11-29 at 06:45 +0200, Jarkko Sakkinen wrote:
> > On Fri, Nov 27, 2020 at 11:15:43AM -0800, trix@redhat.com wrote:
> > > From: Tom Rix <trix@redhat.com>
> > >
> > > The macro use will already have a semicolon.
> > >
> > > Signed-off-by: Tom Rix <trix@redhat.com>
> >
> > I'm in-between whether this is worth of merging. The commit message
> > does not help with that decision too much.
>
> It seems worthy of merging to me modulo whatver improvement is desired in
> the commit message.
>
> There are 3 existing uses of request_key_net. All have a trailing semicolon.
> There is 1 existing use of request_key_net_rcu. It has a trailing semicolon.
>
> No object change should occur.
OK, makes sense.
Acked-by: Jarkko Sakkinen <jarkko@kernel.org>
/Jarkko
next prev parent reply other threads:[~2020-12-02 16:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 19:15 [PATCH] keys: remove trailing semicolon in macro definition trix
2020-11-29 4:45 ` Jarkko Sakkinen
2020-11-29 5:30 ` Joe Perches
2020-12-02 16:45 ` Jarkko Sakkinen [this message]
2020-11-30 8:58 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201202164555.GB91162@kernel.org \
--to=jarkko@kernel.org \
--cc=dhowells@redhat.com \
--cc=joe@perches.com \
--cc=keyrings@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trix@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.