From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Wed, 02 Dec 2020 18:20:32 +0000 Subject: Re: [PATCH] ath11k: Fix an error handling path Message-Id: <20201202182032.6D184C43462@smtp.codeaurora.org> List-Id: References: <20201122173943.1366167-1-christophe.jaillet@wanadoo.fr> In-Reply-To: <20201122173943.1366167-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christophe JAILLET Cc: davem@davemloft.net, kuba@kernel.org, gseset@codeaurora.org, mkenna@codeaurora.org, slakkavalli@datto.com, gsamin@codeaurora.org, pradeepc@codeaurora.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Christophe JAILLET wrote: > If 'kzalloc' fails, we must return an error code. > > While at it, remove a useless initialization of 'err' which could hide the > issue. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Christophe JAILLET > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e7bcc145bcd0 ath11k: Fix an error handling path -- https://patchwork.kernel.org/project/linux-wireless/patch/20201122173943.1366167-1-christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 53888C64E7C for ; Wed, 2 Dec 2020 18:22:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 032BE221FC for ; Wed, 2 Dec 2020 18:22:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387748AbgLBSVg (ORCPT ); Wed, 2 Dec 2020 13:21:36 -0500 Received: from m42-5.mailgun.net ([69.72.42.5]:59605 "EHLO m42-5.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726283AbgLBSVg (ORCPT ); Wed, 2 Dec 2020 13:21:36 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1606933272; h=Date: Message-Id: Cc: To: References: In-Reply-To: From: Subject: Content-Transfer-Encoding: MIME-Version: Content-Type: Sender; bh=6hHiBut5tc4rK79Dvrfs9gsxeC4FD3wiqw/uG0yPHFQ=; b=nSjpiZu6UwdBUFx52neOmAKUQkvc1EiUx21KpsP8Vwoxdr1uHxxvTCsZMJXcGB9sZV6gMJSk Ai+Ngo2KRCSJv+t6Io4SYSp/rTFJWmW47+Tqs0ijKGkhk8AMdaS/3w0JVhT0753ZLhV9HzY+ /Cxu8JRPFGQsvGkMNG2H+9WNIis= X-Mailgun-Sending-Ip: 69.72.42.5 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 5fc7daf08d03b22a5a806569 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 02 Dec 2020 18:20:32 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 6D184C43462; Wed, 2 Dec 2020 18:20:32 +0000 (UTC) Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id B55C5C433ED; Wed, 2 Dec 2020 18:20:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org B55C5C433ED Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] ath11k: Fix an error handling path From: Kalle Valo In-Reply-To: <20201122173943.1366167-1-christophe.jaillet@wanadoo.fr> References: <20201122173943.1366167-1-christophe.jaillet@wanadoo.fr> To: Christophe JAILLET Cc: davem@davemloft.net, kuba@kernel.org, gseset@codeaurora.org, mkenna@codeaurora.org, slakkavalli@datto.com, gsamin@codeaurora.org, pradeepc@codeaurora.org, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Christophe JAILLET User-Agent: pwcli/0.1.0-git (https://github.com/kvalo/pwcli/) Python/3.5.2 Message-Id: <20201202182032.6D184C43462@smtp.codeaurora.org> Date: Wed, 2 Dec 2020 18:20:32 +0000 (UTC) Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Christophe JAILLET wrote: > If 'kzalloc' fails, we must return an error code. > > While at it, remove a useless initialization of 'err' which could hide the > issue. > > Fixes: d5c65159f289 ("ath11k: driver for Qualcomm IEEE 802.11ax devices") > Signed-off-by: Christophe JAILLET > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. e7bcc145bcd0 ath11k: Fix an error handling path -- https://patchwork.kernel.org/project/linux-wireless/patch/20201122173943.1366167-1-christophe.jaillet@wanadoo.fr/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches