From: Todd Zullinger <tmz@pobox.com>
To: "brian m. carlson" <sandals@crustytoothpaste.net>,
"Arnout Engelen" <arnout@bzzt.net>,
git@vger.kernel.org, "Martin Ågren" <martin.agren@gmail.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH] doc: make HTML manual reproducible
Date: Wed, 2 Dec 2020 21:00:59 -0500 [thread overview]
Message-ID: <20201203020059.GY748@pobox.com> (raw)
In-Reply-To: <X8gnItjchqX4wwmt@camp.crustytoothpaste.net>
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
brian m. carlson wrote:
> On 2020-12-02 at 16:07:55, Todd Zullinger wrote:
>> Indeed. Is it worth mentioning this at all in INSTALL?
>> Something like:
>>
>> - The minimum supported version of docbook-xsl is 1.74.
>> + The minimum supported version of docbook-xsl is 1.74. For consistent
>> + IDs in the HTML version of the user-manual, 1.79.1 or newer is
>> + necessary.
>>
>> perhaps?
>
> I don't know that that's even necessary. Anyone doing reproducible
> builds is already aware of the required versions in order to do a
> reproducible build, and I don't think the average user is going to be
> super interested.
>
> We can if you feel strongly about it, but I don't personally see it as a
> big deal.
Nah, I definitely don't feel strongly about it. I debated
the same point you made -- that those most likely to care
about the feature would likely know the versions (perhaps
painfully) well.
This is a nice change that, conveniently, has all pros and
no cons, it seems.
I suppose we'd ideally look for a v2 with --stringparam
replaced with --param as you noted upthread?
And maybe an updated commit message to note that it requires
docbook-xsl 1.79.1 to be effective, but older versions
gracefully ignore the option? That may be helpful to a
future reader who wonders why the requirement wasn't raised.
--
Todd
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 543 bytes --]
next prev parent reply other threads:[~2020-12-03 2:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-01 9:50 [PATCH] doc: make HTML manual reproducible Arnout Engelen
2020-12-01 15:41 ` Todd Zullinger
2020-12-01 19:18 ` Martin Ågren
2020-12-02 1:54 ` Jeff King
2020-12-01 19:27 ` Junio C Hamano
2020-12-01 19:57 ` Martin Ågren
2020-12-02 0:36 ` brian m. carlson
2020-12-02 16:07 ` Todd Zullinger
2020-12-02 22:35 ` Junio C Hamano
2020-12-02 23:45 ` brian m. carlson
2020-12-03 1:33 ` Junio C Hamano
2020-12-03 2:00 ` Todd Zullinger [this message]
2020-12-03 2:31 ` Re* " Junio C Hamano
2020-12-03 8:07 ` Arnout Engelen
2020-12-02 0:41 ` brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203020059.GY748@pobox.com \
--to=tmz@pobox.com \
--cc=arnout@bzzt.net \
--cc=git@vger.kernel.org \
--cc=martin.agren@gmail.com \
--cc=peff@peff.net \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.