From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E62D2C64E7A for ; Thu, 3 Dec 2020 04:08:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 84C0721D91 for ; Thu, 3 Dec 2020 04:08:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728104AbgLCEIk (ORCPT ); Wed, 2 Dec 2020 23:08:40 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:35532 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726071AbgLCEIk (ORCPT ); Wed, 2 Dec 2020 23:08:40 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kkfuQ-009yfM-NI; Thu, 03 Dec 2020 05:07:58 +0100 Date: Thu, 3 Dec 2020 05:07:58 +0100 From: Andrew Lunn To: Grant Edwards Cc: netdev@vger.kernel.org Subject: Re: net: macb: fail when there's no PHY Message-ID: <20201203040758.GC2333853@lunn.ch> References: <66c0a032-4d20-69f1-deb4-6c65af6ec740@gmail.com> <6a9c1d4a-ed73-3074-f9fa-158c697c7bfe@gmail.com> <20201202183531.GJ2324545@lunn.ch> <20201202211134.GM2324545@lunn.ch> <57728908-1ae3-cbe9-8721-81f06ab688b8@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > So I can avoid my local hack to macb_main.c by doing a doing a local > hack to macb_main.c? User space drivers were never supported in any meaningful way. The IOCTL call is basically there for mii-tool, and nothing much more. The way to avoid your local hack is to move your drivers into the kernel, along side all the other drivers for devices on MDIO busses. Andrew