From: Christoph Hellwig <hch@lst.de>
To: ira.weiny@intel.com
Cc: fstests@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Eric Sandeen <sandeen@redhat.com>,
linux-kernel@vger.kernel.org,
"Darrick J. Wong" <darrick.wong@oracle.com>,
Dan Williams <dan.j.williams@intel.com>,
Dave Chinner <david@fromorbit.com>,
"Theodore Y. Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.cz>,
Jeff Moyer <jmoyer@redhat.com>,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org,
David Howells <dhowells@redhat.com>
Subject: Re: [PATCH] common/rc: Fix _check_s_dax()
Date: Thu, 3 Dec 2020 09:15:56 +0100 [thread overview]
Message-ID: <20201203081556.GA15306@lst.de> (raw)
In-Reply-To: <20201202214145.1563433-1-ira.weiny@intel.com>
On Wed, Dec 02, 2020 at 01:41:45PM -0800, ira.weiny@intel.com wrote:
> From: Ira Weiny <ira.weiny@intel.com>
>
> There is a conflict with the user visible statx bits 'mount root' and
> 'dax'. The kernel is changing the dax bit to correct this conflict.[1]
>
> Adjust _check_s_dax() to use the new bit. Because DAX tests do not run
> on root mounts, STATX_ATTR_MOUNT_ROOT should always be 0, therefore we
> can allow either bit to indicate DAX and cover any kernel which may be
> running.
>
> [1] https://lore.kernel.org/lkml/3e28d2c7-fbe5-298a-13ba-dcd8fd504666@redhat.com/
>
> Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> ---
>
> I went ahead and used Christoph's suggestion regarding using both bits.
That wasn't my suggestion. I think we should always error out when
the bit value shared with STATX_ATTR_MOUNT_ROOT is seen. Because that
means the kernel is not using or fixed ABI we agreed to use going
forward.
next prev parent reply other threads:[~2020-12-03 8:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 21:41 [PATCH] common/rc: Fix _check_s_dax() ira.weiny
2020-12-02 21:46 ` [PATCH V2] " ira.weiny
2020-12-04 1:45 ` [PATCH V3] " ira.weiny
2020-12-04 9:47 ` Christoph Hellwig
2020-12-03 8:15 ` Christoph Hellwig [this message]
2020-12-03 17:55 ` [PATCH] " Eric Sandeen
2020-12-03 18:08 ` Christoph Hellwig
2020-12-04 1:44 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203081556.GA15306@lst.de \
--to=hch@lst.de \
--cc=dan.j.williams@intel.com \
--cc=darrick.wong@oracle.com \
--cc=david@fromorbit.com \
--cc=dhowells@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=ira.weiny@intel.com \
--cc=jack@suse.cz \
--cc=jmoyer@redhat.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.