From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1232C64E7B for ; Thu, 3 Dec 2020 08:24:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9DE9321741 for ; Thu, 3 Dec 2020 08:24:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388408AbgLCIXr convert rfc822-to-8bit (ORCPT ); Thu, 3 Dec 2020 03:23:47 -0500 Received: from mail-ed1-f65.google.com ([209.85.208.65]:35769 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387627AbgLCIXr (ORCPT ); Thu, 3 Dec 2020 03:23:47 -0500 Received: by mail-ed1-f65.google.com with SMTP id u19so1161217edx.2; Thu, 03 Dec 2020 00:23:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vjNuER/19Tth1CpYQD6/JuQrBM7KYytXToe4a5pm5bs=; b=TUdEm0mzUb/j6jtP4tF7lnSYExxuLHk22V7uUF7npsfdSLJ3Qt6/n0632W6/M9SWyF huvtGghqYONsYjo2vKxp84NthsIiG5btRt6N11suOxGe0k/hkJo0fhRSiovicr5Cu6Sb YDgU/nbVnzvpP2xyL01Cu11fS7uO9ZgNpcycyB+6Wi6U80fqQTkXn2OmC5DoHeUYiB8z ZSD0BWn8BF3xAQT8jR9h8Q9ETmX0adml/T0nPcryJZjZ5ddhjEF0j20CuqLbOT3qHPpO GVyy5zX27LMIa/h+TT4WDnVWwfgemVsoXgZ+7Dzl56W5r+djU0j3NOf4zH763vhiXLzi 46og== X-Gm-Message-State: AOAM533tQZ7xflU+UurIiQvvK/c5AWEVNvOVoLuA+ZXS+NeOmAVb3NvU JgL8JE/BovaufbcJz2Gu0X62BzqCWRk= X-Google-Smtp-Source: ABdhPJz6lZzwkNjzmCsEkSEnUZPUn+YcmrfwxtsRWn50uOV9TtVgHVpnwr8KdR2bIkFqh8i07rs9Mg== X-Received: by 2002:a50:f40e:: with SMTP id r14mr1712818edm.5.1606983784224; Thu, 03 Dec 2020 00:23:04 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id c12sm630568edw.55.2020.12.03.00.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 00:23:03 -0800 (PST) Date: Thu, 3 Dec 2020 10:23:01 +0200 From: Krzysztof Kozlowski To: Timon =?utf-8?B?QsOkdHo=?= Cc: Sebastian Reichel , Chanwoo Choi , MyungJoo Ham , Kukjin Kim , Rob Herring , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "devicetree@vger.kernel.org" , "~postmarketos/upstreaming@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht> Subject: Re: [PATCH 3/3] ARM: dts: exynos: Fix charging regulator voltage and current for i9100 Message-ID: <20201203082301.GA3999@kozik-lap> References: <20201202203516.43053-1-timon.baetz@protonmail.com> <20201202203516.43053-3-timon.baetz@protonmail.com> <20201202220430.GB135888@kozik-lap> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8BIT In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Thu, Dec 03, 2020 at 05:46:03AM +0000, Timon Bätz wrote: > On Wednesday, December 2, 2020 11:04 PM, Krzysztof Kozlowski wrote: > > > On Wed, Dec 02, 2020 at 09:07:28PM +0000, Timon Baetz wrote: > > > > > Set CHARGER current and CHARGER_CV voltage according to Galaxy S2 kernel > > > fork. > > > > > > Signed-off-by: Timon Baetz timon.baetz@protonmail.com > > > > > > ------------------------------------------------------ > > > > > > arch/arm/boot/dts/exynos4210-i9100.dts | 8 ++++---- > > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > diff --git a/arch/arm/boot/dts/exynos4210-i9100.dts b/arch/arm/boot/dts/exynos4210-i9100.dts > > > index 9f8d927e0d21..2700d53ea01b 100644 > > > --- a/arch/arm/boot/dts/exynos4210-i9100.dts > > > +++ b/arch/arm/boot/dts/exynos4210-i9100.dts > > > @@ -558,14 +558,14 @@ safe2_sreg: ESAFEOUT2 { > > > > > > charger_reg: CHARGER { > > > regulator-name = "CHARGER"; > > > > > > > > > - regulator-min-microamp = <60000>; > > > > > > > > > - regulator-max-microamp = <2580000>; > > > > > > > > > > > > - regulator-min-microamp = <200000>; > > > > > > > > > - regulator-max-microamp = <950000>; > > > }; > > > > > > chargercv_reg: CHARGER_CV { > > > regulator-name = "CHARGER_CV"; > > > > > > > > > > > > - regulator-min-microvolt = <3800000>; > > > > > > > > > - regulator-max-microvolt = <4100000>; > > > > > > > > > > > > - regulator-min-microvolt = <4200000>; > > > > > > > > > - regulator-max-microvolt = <4200000>; > > > > > > > > > > I am looking at my sources of Android 3.0 for GT-I9100 but I cannot find > > charger voltages for it. Where did you find it? > > > > Best regards, > > Krzysztof > > Thanks all the feedback Krzysztof, > > Voltage is set in the charger probe function of the downstream kernel fork: https://github.com/LineageOS/android_kernel_samsung_smdk4412/blob/lineage-17.0/drivers/power/max8997_charger_u1.c#L390-L391 You need to fix your email client to wrap lines. The fork cannot be used as a reference because of poor quality of explanations for origins of the code. The commit which added 4.2 V is described as "samsung update 1" which basically means nothing. If at least it was "drop sources of GT-I9105"... but in this form it is useless. For the things we are not sure how they should be implemented, we sometimes accept the reason "vendor sources do like this". However Lineage or any other fork are not vendor sources. Therefore you need to provide a valid explanation for this voltage change. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-20.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3631C63777 for ; Thu, 3 Dec 2020 08:24:43 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A66721527 for ; Thu, 3 Dec 2020 08:24:43 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A66721527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+Zq1gMydCzg85OFBnFufGTLzvvETF77xmiw6tYDMhjg=; b=ggowTZlAciIxmvsOjHGSSd33t ekjqVWb+FnUqxWncx8iKgcPjOTb1A9orWTIdaPPN8AXONlfPOU+rpdWxj3ZdV5TPuJDlI9PdQTqPj yd1NxQS58uHgLUSfLAb0b3KIb98VuMZpJl88Clh6vfiu/7WcjqclBmWT6HcYrJWPQLNUn/4PrI5Ji 40RWK3Xvr5WnYEdN7N4lV9I6PdbfbmuZ3LO8i054qg6XJYVqq4LggLLpR74Fk/RA4QJyZvQPAhqMR aCtJoOqLJX9xVghcLjWxC71PU3qRT2LugsQn6gC++yf1RnrmkigXVejII4LoAEaNxowQF79MuMBkU bI/ANXU5w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkjtM-00038r-9p; Thu, 03 Dec 2020 08:23:08 +0000 Received: from mail-ed1-f65.google.com ([209.85.208.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kkjtJ-00038N-Jc for linux-arm-kernel@lists.infradead.org; Thu, 03 Dec 2020 08:23:06 +0000 Received: by mail-ed1-f65.google.com with SMTP id r5so1119537eda.12 for ; Thu, 03 Dec 2020 00:23:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=vjNuER/19Tth1CpYQD6/JuQrBM7KYytXToe4a5pm5bs=; b=BKCvgnPTZJM9SdflWUASe/gjJ8y6ITMNuMbTVeRar0VSG4QoFRtDFNINLmPlBsC3MW GDuj7kCKPoY/zmprzLx8+spEbrtHwFFFH8+sHwmwndT0DdCcsBwTBXuxsADsotV4EySA EJJ2rUB4BQ+KYVvNwxAMITt1HGmsRct/VS8+bh7L5wH0RKPdlWpZ1+s+MwAMVMIa7xDj m6H5tP/T03c+6adqv5hEtMGtr2Pvb+1+7nlNnh5/RdtvCfoZqjUKp2WKYSQU6CZPmrum /7iY7uMG/oOx8klbE77jnhohTC0GR3a82FRFqkJI/rDfDHvPsPEcyORl8059f+EpOQIb pzcQ== X-Gm-Message-State: AOAM5339Yt/9cOgFxsN9HWdeQYSaAzP11Q2kDUBYLouBOFvYlRC8xjxK ae5OpXtZ3EUBwRw+Jy4pCbU= X-Google-Smtp-Source: ABdhPJz6lZzwkNjzmCsEkSEnUZPUn+YcmrfwxtsRWn50uOV9TtVgHVpnwr8KdR2bIkFqh8i07rs9Mg== X-Received: by 2002:a50:f40e:: with SMTP id r14mr1712818edm.5.1606983784224; Thu, 03 Dec 2020 00:23:04 -0800 (PST) Received: from kozik-lap (adsl-84-226-167-205.adslplus.ch. [84.226.167.205]) by smtp.googlemail.com with ESMTPSA id c12sm630568edw.55.2020.12.03.00.23.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 00:23:03 -0800 (PST) Date: Thu, 3 Dec 2020 10:23:01 +0200 From: Krzysztof Kozlowski To: Timon =?utf-8?B?QsOkdHo=?= Subject: Re: [PATCH 3/3] ARM: dts: exynos: Fix charging regulator voltage and current for i9100 Message-ID: <20201203082301.GA3999@kozik-lap> References: <20201202203516.43053-1-timon.baetz@protonmail.com> <20201202203516.43053-3-timon.baetz@protonmail.com> <20201202220430.GB135888@kozik-lap> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201203_032305_687628_046ACAD1 X-CRM114-Status: GOOD ( 22.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "devicetree@vger.kernel.org" , "linux-samsung-soc@vger.kernel.org" , "linux-pm@vger.kernel.org" , Sebastian Reichel , Rob Herring , "linux-kernel@vger.kernel.org" , Chanwoo Choi , Kukjin Kim , MyungJoo Ham , "linux-arm-kernel@lists.infradead.org" , "~postmarketos/upstreaming@lists.sr.ht" <~postmarketos/upstreaming@lists.sr.ht> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVGh1LCBEZWMgMDMsIDIwMjAgYXQgMDU6NDY6MDNBTSArMDAwMCwgVGltb24gQsOkdHogd3Jv dGU6Cj4gT24gV2VkbmVzZGF5LCBEZWNlbWJlciAyLCAyMDIwIDExOjA0IFBNLCBLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+IHdyb3RlOgo+IAo+ID4gT24gV2VkLCBEZWMgMDIs IDIwMjAgYXQgMDk6MDc6MjhQTSArMDAwMCwgVGltb24gQmFldHogd3JvdGU6Cj4gPgo+ID4gPiBT ZXQgQ0hBUkdFUiBjdXJyZW50IGFuZCBDSEFSR0VSX0NWIHZvbHRhZ2UgYWNjb3JkaW5nIHRvIEdh bGF4eSBTMiBrZXJuZWwKPiA+ID4gZm9yay4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogVGlt b24gQmFldHogdGltb24uYmFldHpAcHJvdG9ubWFpbC5jb20KPiA+ID4KPiA+ID4gLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCj4gPiA+Cj4gPiA+ IGFyY2gvYXJtL2Jvb3QvZHRzL2V4eW5vczQyMTAtaTkxMDAuZHRzIHwgOCArKysrLS0tLQo+ID4g PiAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQo+ID4gPiBk aWZmIC0tZ2l0IGEvYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNDIxMC1pOTEwMC5kdHMgYi9hcmNo L2FybS9ib290L2R0cy9leHlub3M0MjEwLWk5MTAwLmR0cwo+ID4gPiBpbmRleCA5ZjhkOTI3ZTBk MjEuLjI3MDBkNTNlYTAxYiAxMDA2NDQKPiA+ID4gLS0tIGEvYXJjaC9hcm0vYm9vdC9kdHMvZXh5 bm9zNDIxMC1pOTEwMC5kdHMKPiA+ID4gKysrIGIvYXJjaC9hcm0vYm9vdC9kdHMvZXh5bm9zNDIx MC1pOTEwMC5kdHMKPiA+ID4gQEAgLTU1OCwxNCArNTU4LDE0IEBAIHNhZmUyX3NyZWc6IEVTQUZF T1VUMiB7Cj4gPiA+Cj4gPiA+ICAgICAgIAljaGFyZ2VyX3JlZzogQ0hBUkdFUiB7Cj4gPiA+ICAg ICAgIAkJcmVndWxhdG9yLW5hbWUgPSAiQ0hBUkdFUiI7Cj4gPiA+Cj4gPiA+Cj4gPiA+IC0gICAg ICAgCQlyZWd1bGF0b3ItbWluLW1pY3JvYW1wID0gPDYwMDAwPjsKPiA+ID4KPiA+ID4KPiA+ID4g LSAgICAgICAJCXJlZ3VsYXRvci1tYXgtbWljcm9hbXAgPSA8MjU4MDAwMD47Cj4gPiA+Cj4gPiA+ Cj4gPiA+Cj4gPiA+IC0gICAgICAgCQlyZWd1bGF0b3ItbWluLW1pY3JvYW1wID0gPDIwMDAwMD47 Cj4gPiA+Cj4gPiA+Cj4gPiA+IC0gICAgICAgCQlyZWd1bGF0b3ItbWF4LW1pY3JvYW1wID0gPDk1 MDAwMD47Cj4gPiA+ICAgICAgICAgCX07Cj4gPiA+Cj4gPiA+ICAgICAgICAgCWNoYXJnZXJjdl9y ZWc6IENIQVJHRVJfQ1Ygewo+ID4gPiAgICAgICAgIAkJcmVndWxhdG9yLW5hbWUgPSAiQ0hBUkdF Ul9DViI7Cj4gPiA+Cj4gPiA+Cj4gPiA+Cj4gPiA+IC0gICAgICAgCQlyZWd1bGF0b3ItbWluLW1p Y3Jvdm9sdCA9IDwzODAwMDAwPjsKPiA+ID4KPiA+ID4KPiA+ID4gLSAgICAgICAJCXJlZ3VsYXRv ci1tYXgtbWljcm92b2x0ID0gPDQxMDAwMDA+Owo+ID4gPgo+ID4gPgo+ID4gPgo+ID4gPiAtICAg ICAgIAkJcmVndWxhdG9yLW1pbi1taWNyb3ZvbHQgPSA8NDIwMDAwMD47Cj4gPiA+Cj4gPiA+Cj4g PiA+IC0gICAgICAgCQlyZWd1bGF0b3ItbWF4LW1pY3Jvdm9sdCA9IDw0MjAwMDAwPjsKPiA+ID4K PiA+ID4KPiA+Cj4gPiBJIGFtIGxvb2tpbmcgYXQgbXkgc291cmNlcyBvZiBBbmRyb2lkIDMuMCBm b3IgR1QtSTkxMDAgYnV0IEkgY2Fubm90IGZpbmQKPiA+IGNoYXJnZXIgdm9sdGFnZXMgZm9yIGl0 LiBXaGVyZSBkaWQgeW91IGZpbmQgaXQ/Cj4gPgo+ID4gQmVzdCByZWdhcmRzLAo+ID4gS3J6eXN6 dG9mCj4gCj4gVGhhbmtzIGFsbCB0aGUgZmVlZGJhY2sgS3J6eXN6dG9mLAo+IAo+IFZvbHRhZ2Ug aXMgc2V0IGluIHRoZSBjaGFyZ2VyIHByb2JlIGZ1bmN0aW9uIG9mIHRoZSBkb3duc3RyZWFtIGtl cm5lbCBmb3JrOiBodHRwczovL2dpdGh1Yi5jb20vTGluZWFnZU9TL2FuZHJvaWRfa2VybmVsX3Nh bXN1bmdfc21kazQ0MTIvYmxvYi9saW5lYWdlLTE3LjAvZHJpdmVycy9wb3dlci9tYXg4OTk3X2No YXJnZXJfdTEuYyNMMzkwLUwzOTEKCllvdSBuZWVkIHRvIGZpeCB5b3VyIGVtYWlsIGNsaWVudCB0 byB3cmFwIGxpbmVzLgoKVGhlIGZvcmsgY2Fubm90IGJlIHVzZWQgYXMgYSByZWZlcmVuY2UgYmVj YXVzZSBvZiBwb29yIHF1YWxpdHkgb2YKZXhwbGFuYXRpb25zIGZvciBvcmlnaW5zIG9mIHRoZSBj b2RlLgoKVGhlIGNvbW1pdCB3aGljaCBhZGRlZCA0LjIgViBpcyBkZXNjcmliZWQgYXMgInNhbXN1 bmcgdXBkYXRlIDEiIHdoaWNoCmJhc2ljYWxseSBtZWFucyBub3RoaW5nLiBJZiBhdCBsZWFzdCBp dCB3YXMgImRyb3Agc291cmNlcyBvZgpHVC1JOTEwNSIuLi4gYnV0IGluIHRoaXMgZm9ybSBpdCBp cyB1c2VsZXNzLgoKRm9yIHRoZSB0aGluZ3Mgd2UgYXJlIG5vdCBzdXJlIGhvdyB0aGV5IHNob3Vs ZCBiZSBpbXBsZW1lbnRlZCwgd2UKc29tZXRpbWVzIGFjY2VwdCB0aGUgcmVhc29uICJ2ZW5kb3Ig c291cmNlcyBkbyBsaWtlIHRoaXMiLiBIb3dldmVyIExpbmVhZ2UKb3IgYW55IG90aGVyIGZvcmsg YXJlIG5vdCB2ZW5kb3Igc291cmNlcy4KClRoZXJlZm9yZSB5b3UgbmVlZCB0byBwcm92aWRlIGEg dmFsaWQgZXhwbGFuYXRpb24gZm9yIHRoaXMgdm9sdGFnZQpjaGFuZ2UuCgpCZXN0IHJlZ2FyZHMs CktyenlzenRvZgoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMu aW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZv L2xpbnV4LWFybS1rZXJuZWwK