From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: "zhangyi (F)" <yi.zhang@huawei.com>
Cc: xiakaixu1987@gmail.com, linux-ext4@vger.kernel.org,
adilger.kernel@dilger.ca, Kaixu Xia <kaixuxia@tencent.com>
Subject: Re: [PATCH] ext4: remove redundant operation that set bh to NULL
Date: Thu, 3 Dec 2020 09:15:57 -0500 [thread overview]
Message-ID: <20201203141557.GG441757@mit.edu> (raw)
In-Reply-To: <2677070f-f994-f20d-115b-55922d172da6@huawei.com>
On Wed, Oct 21, 2020 at 09:10:18AM +0800, zhangyi (F) wrote:
> On 2020/10/20 19:41, xiakaixu1987@gmail.com wrote:
> > From: Kaixu Xia <kaixuxia@tencent.com>
> >
> > The out_fail branch path don't release the bh and the second bh is
> > valid only in the for statement, so we don't need to set them to NULL.
> >
> > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
>
> Thanks for the patch. It looks good to me.
> Reviewed-by: zhangyi (F) <yi.zhang@huawei.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2020-12-03 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-20 11:41 [PATCH] ext4: remove redundant operation that set bh to NULL xiakaixu1987
2020-10-21 1:10 ` zhangyi (F)
2020-12-03 14:15 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201203141557.GG441757@mit.edu \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=kaixuxia@tencent.com \
--cc=linux-ext4@vger.kernel.org \
--cc=xiakaixu1987@gmail.com \
--cc=yi.zhang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.