From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1kkq7r-0004OU-Bg for mharc-grub-devel@gnu.org; Thu, 03 Dec 2020 10:02:31 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:45830) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kkq7l-0004N3-Jy for grub-devel@gnu.org; Thu, 03 Dec 2020 10:02:25 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:39052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.90_1) (envelope-from ) id 1kkq7j-0001yS-6Z for grub-devel@gnu.org; Thu, 03 Dec 2020 10:02:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1607007739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IOZjPow9tdHd8UIQvVELD638aL1O3ucUm/cZHd9HYqc=; b=NZuOtGmv1AS76fybG8G0dV15f/iigjIOe+26aS1cOVHcQp2SnI5IdipyREffQ2Oa27+JM1 fIbMCIz7/5rG8WV2vIu0pe/GP91vMDgim5ucjmgedWNvI6gT3xmINEbuWCgjQUgCcpm7yd g5+MkvR2DApJxLxoHmVp5zQKAyPvONw= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-527-Re6NCAfxPxSJYds7DjAUjg-1; Thu, 03 Dec 2020 10:02:18 -0500 X-MC-Unique: Re6NCAfxPxSJYds7DjAUjg-1 Received: by mail-wm1-f72.google.com with SMTP id o203so1425499wmo.3 for ; Thu, 03 Dec 2020 07:02:18 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IOZjPow9tdHd8UIQvVELD638aL1O3ucUm/cZHd9HYqc=; b=FXeOQ+8OsA6YUQGB1Ch1jRlglFLHvnxMN41A+n7WvViKjqq4VT0aViEcbnhy6rZcps xDBN96YXG3W8hs4rRiJaXacTOmctAjBfPKm8Xma1A+BLTWVhtJutKWlrQq7htyajuM70 Xp6m7n49/nPIL7RO53245R6zhXViLOaO2KPWdVZiQ+uMz8nymNMIux8ij9zntuerj4sx SMPf4fV+OXoK5vHHicKsGkGvyvWjO7+emTwr7fcO6yzqrSGFiL8oi2iPbDdyVIFDguqF 7q1leaBnssb17ewfuznSDNTPuGbOQEBZ4W/YoDV66QrNngqbTO5oHuys/TS9utu5T/T7 YemA== X-Gm-Message-State: AOAM532zaIin7IHkc3nHtmlNXFHvmiemyI8sWsd5mys5HcvXtKaO2Kgc yN3uuDLlGxCyLtXDXhaBX1GB4EFcY3lfNgWhgBmxaL5N+eXT9DJ+vNLC+CWffpasb9AHjwmJuS5 eRvyBvy8ZDl6ANlBqrLHXaXQisphDB2xYU6dGXVgmBvNY9SVaDpReXgsZU7CmMA== X-Received: by 2002:a05:600c:288:: with SMTP id 8mr3874580wmk.106.1607007736697; Thu, 03 Dec 2020 07:02:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyk6fjA4jw/Eqm4FKo9kUVaKeHoi9uLogX9QBXBfj6rSRn5ZEBI3xDIJWq3N0twzK58QVCD8Q== X-Received: by 2002:a05:600c:288:: with SMTP id 8mr3874552wmk.106.1607007736499; Thu, 03 Dec 2020 07:02:16 -0800 (PST) Received: from minerva.redhat.com ([92.176.231.106]) by smtp.gmail.com with ESMTPSA id n128sm1896759wmb.46.2020.12.03.07.02.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Dec 2020 07:02:15 -0800 (PST) From: Javier Martinez Canillas To: grub-devel@gnu.org Cc: Ignat Korchagin , Michael Chang , Peter Jones , Marco A Benatto , Leif Lindholm , Daniel Kiper , Javier Martinez Canillas Subject: [PATCH 1/9] i386: Don't include in coreboot and ieee1275 startup.S Date: Thu, 3 Dec 2020 16:01:42 +0100 Message-Id: <20201203150151.848077-2-javierm@redhat.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201203150151.848077-1-javierm@redhat.com> References: <20201203150151.848077-1-javierm@redhat.com> MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=javierm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Received-SPF: pass client-ip=216.205.24.124; envelope-from=javierm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -35 X-Spam_score: -3.6 X-Spam_bar: --- X-Spam_report: (-3.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-1.495, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Dec 2020 15:02:26 -0000 Nothing defined in the header file is used in the assembly code but it may lead to build errors if some headers are included through this and contains definitions that are not recognized by the assembler, e.g.: ../include/grub/types.h: Assembler messages: ../include/grub/types.h:76: Error: no such instruction: `typedef signed char grub_int8_t' ../include/grub/types.h:77: Error: no such instruction: `typedef short grub_int16_t' ../include/grub/types.h:78: Error: no such instruction: `typedef int grub_int32_t' Signed-off-by: Javier Martinez Canillas --- grub-core/kern/i386/coreboot/startup.S | 1 - grub-core/kern/i386/ieee1275/startup.S | 1 - 2 files changed, 2 deletions(-) diff --git a/grub-core/kern/i386/coreboot/startup.S b/grub-core/kern/i386/coreboot/startup.S index c8486548de0..df6adbabb5b 100644 --- a/grub-core/kern/i386/coreboot/startup.S +++ b/grub-core/kern/i386/coreboot/startup.S @@ -18,7 +18,6 @@ #include #include -#include #include #include #include diff --git a/grub-core/kern/i386/ieee1275/startup.S b/grub-core/kern/i386/ieee1275/startup.S index 245583bdb71..62cf348e014 100644 --- a/grub-core/kern/i386/ieee1275/startup.S +++ b/grub-core/kern/i386/ieee1275/startup.S @@ -18,7 +18,6 @@ #include #include -#include #include #include -- 2.28.0