Re: [RFC PATCH v2 2/6] power: supply: add sw-gauge for SOC estimation and CC correction

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3094 bytes --]

Hi Matti,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on 09162bc32c880a791c6c0668ce0745cf7958f576]

url:    https://github.com/0day-ci/linux/commits/Matti-Vaittinen/power-supply-Add-some-fuel-gauge-logic/20201204-205731
base:    09162bc32c880a791c6c0668ce0745cf7958f576
config: mips-allyesconfig (attached as .config)
compiler: mips-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/d7d68650b1fb6da80b5ba5953454bae6bbe420da
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Matti-Vaittinen/power-supply-Add-some-fuel-gauge-logic/20201204-205731
        git checkout d7d68650b1fb6da80b5ba5953454bae6bbe420da
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=mips 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/power/supply/power_supply_swgauge.c: In function 'adjust_cc_full':
>> drivers/power/supply/power_supply_swgauge.c:341:6: warning: variable 'ret' set but not used [-Wunused-but-set-variable]
     341 |  int ret, from_full_uah = 0;
         |      ^~~
   drivers/power/supply/power_supply_swgauge.c: In function 'compute_soc_by_cc':
>> drivers/power/supply/power_supply_swgauge.c:642:3: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
     642 |   ;
         |   ^
   drivers/power/supply/power_supply_swgauge.c: At top level:
   drivers/power/supply/power_supply_swgauge.c:818:6: warning: no previous prototype for 'stop_gauge_thread' [-Wmissing-prototypes]
     818 | void stop_gauge_thread(struct task_struct *k)
         |      ^~~~~~~~~~~~~~~~~

vim +/ret +341 drivers/power/supply/power_supply_swgauge.c

   338	
   339	static int adjust_cc_full(struct sw_gauge *sw)
   340	{
 > 341		int ret, from_full_uah = 0;
   342		int full_uah = sw->designed_cap;
   343	
   344		if (sw->ops.get_uah_from_full)
   345			ret = sw->ops.get_uah_from_full(sw, &from_full_uah);
   346	
   347		full_uah -= from_full_uah;
   348	
   349		/*
   350		 * ROHM algorithm adjusts CC here based on designed capacity and not
   351		 * based on age/temperature corrected capacity. This helps avoiding
   352		 * CC dropping below zero when we estimate aging/temperature impact
   353		 * badly. It also allows to keep the estimated SOC in the sw-gauge
   354		 * so that all IC drivers do not need to care about it - at least
   355		 * in theory. But most importantly - this approach is tested on the
   356		 * field :)
   357		 */
   358		return sw->ops.update_cc_uah(sw, full_uah);
   359	}
   360	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 69135 bytes --]