All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: walimisdev@gmail.com
Cc: dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path
Date: Sun, 6 Dec 2020 09:43:37 -0800	[thread overview]
Message-ID: <20201206094337.37cf321b@hermes.local> (raw)
In-Reply-To: <20201206173114.3954124-1-walimisdev@gmail.com>

On Mon,  7 Dec 2020 01:31:14 +0800
walimisdev@gmail.com wrote:

> From: Wang Liming <walimisdev@gmail.com>
> 
> Remove redundant "nr_hugepages" words from mlx4 and mlx5 doc.
> 
> Signed-off-by: Wang Liming <walimisdev@gmail.com>
> ---
>  doc/guides/nics/mlx4.rst | 2 +-
>  doc/guides/nics/mlx5.rst | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst
> index 354c2bb82..b40954e88 100644
> --- a/doc/guides/nics/mlx4.rst
> +++ b/doc/guides/nics/mlx4.rst
> @@ -405,7 +405,7 @@ devices managed by librte_net_mlx4.
>  
>  #. Request huge pages::
>  
> -      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
> +      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
>  
>  #. Start testpmd with basic parameters::
>  
> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
> index 3bda0f841..afefe6a3a 100644
> --- a/doc/guides/nics/mlx5.rst
> +++ b/doc/guides/nics/mlx5.rst
> @@ -1594,7 +1594,7 @@ ConnectX-4/ConnectX-5/ConnectX-6/BlueField devices managed by librte_net_mlx5.
>  
>  #. Request huge pages::
>  
> -      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages/nr_hugepages
> +      echo 1024 > /sys/kernel/mm/hugepages/hugepages-2048kB/nr_hugepages
>  
>  #. Start testpmd with basic parameters::
>  

Could we change the drivers to refer to the existing hugepages script
rather than doing "roll your own"

  reply	other threads:[~2020-12-06 17:43 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-06 17:31 [dpdk-dev] [PATCH] doc: fix wrong hugepages setting path walimisdev
2020-12-06 17:43 ` Stephen Hemminger [this message]
2021-02-11 18:19   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201206094337.37cf321b@hermes.local \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=walimisdev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.