RE:[xenomai patch with kernel 5.4.77] Error building the kernel

RE:[xenomai patch with kernel 5.4.77] Error building the kernel

[Mohamed Irfanulla Mohamed Abdulla]

Hello,

I performed the installation of xenomai 3.1 with kernel 5.4.77 and
ipipe-core-5.4.77-x86-2.patch on a ubuntu 20.04 machine.

I encounter this error during the build.

  GEN     usr/initramfs_data.cpio
  AS      usr/initramfs_data.o
  AR      usr/built-in.a
  CC      kernel/cgroup/cgroup.o
arch/x86/xenomai/thread.c: In function ‘xnarch_leave_root’:
arch/x86/xenomai/thread.c:475:2: error: too many arguments to function
‘switch_fpu_finish’
  switch_fpu_finish(&current->thread.fpu, smp_processor_id());
  ^
In file included from arch/x86/xenomai/include/asm/xenomai/wrappers.h:44:0,
                 from include/xenomai/cobalt/kernel/timer.h:28,
                 from include/xenomai/cobalt/kernel/thread.h:27,
                 from arch/x86/xenomai/thread.c:25:
./arch/x86/include/asm/fpu/internal.h:594:20: note: declared here
 static inline void switch_fpu_finish(struct fpu *new_fpu)
                    ^
scripts/Makefile.build:265: recipe for target 'arch/x86/xenomai/thread.o'
failed
make[1]: *** [arch/x86/xenomai/thread.o] Error 1
make[1]: *** Waiting for unfinished jobs....
  CC      kernel/cgroup/rstat.o
Makefile:1729: recipe for target 'arch/x86/xenomai' failed
make: *** [arch/x86/xenomai] Error 2
make: *** Waiting for unfinished jobs....
  CC      init/do_mounts_md.o
  CC      kernel/debug/kdb/kdb_io.o

Thank you for your suggestions on the config and fix.

Irfan

Re: [xenomai patch with kernel 5.4.77] Error building the kernel

[florian.bezdeka]

On Mon, 2020-11-30 at 11:49 +0100, Mohamed Irfanulla Mohamed Abdulla
via Xenomai wrote:
> Hello,
> 
> I performed the installation of xenomai 3.1 with kernel 5.4.77 and
> ipipe-core-5.4.77-x86-2.patch on a ubuntu 20.04 machine.
> 
> I encounter this error during the build.
> 
>   GEN     usr/initramfs_data.cpio
>   AS      usr/initramfs_data.o
>   AR      usr/built-in.a
>   CC      kernel/cgroup/cgroup.o
> arch/x86/xenomai/thread.c: In function ‘xnarch_leave_root’:
> arch/x86/xenomai/thread.c:475:2: error: too many arguments to function
> ‘switch_fpu_finish’
>   switch_fpu_finish(&current->thread.fpu, smp_processor_id());

The signature of switch_fpu_finish changed in 5.2. The second parameter
has been removed. 

Please check that you are using the right branch. The calling code in
arch/x86/xenomai/thread.c looks correct (and is located at a different
line!):
                                         
#if LINUX_VERSION_CODE >= KERNEL_VERSION(5,2,0)                       
        switch_fpu_finish(&current->thread.fpu);                      
#else                                                                 
        switch_fpu_finish(&current->thread.fpu, smp_processor_id());  
#endif

>   ^
> In file included from arch/x86/xenomai/include/asm/xenomai/wrappers.h:44:0,
>                  from include/xenomai/cobalt/kernel/timer.h:28,
>                  from include/xenomai/cobalt/kernel/thread.h:27,
>                  from arch/x86/xenomai/thread.c:25:
> ./arch/x86/include/asm/fpu/internal.h:594:20: note: declared here
>  static inline void switch_fpu_finish(struct fpu *new_fpu)
>                     ^
> scripts/Makefile.build:265: recipe for target 'arch/x86/xenomai/thread.o'
> failed
> make[1]: *** [arch/x86/xenomai/thread.o] Error 1
> make[1]: *** Waiting for unfinished jobs....
>   CC      kernel/cgroup/rstat.o
> Makefile:1729: recipe for target 'arch/x86/xenomai' failed
> make: *** [arch/x86/xenomai] Error 2
> make: *** Waiting for unfinished jobs....
>   CC      init/do_mounts_md.o
>   CC      kernel/debug/kdb/kdb_io.o
> 
> Thank you for your suggestions on the config and fix.
> 
> Irfan

Re: [xenomai patch with kernel 5.4.77] Error building the kernel

[florian.bezdeka]

On Mon, 2020-11-30 at 12:16 +0100, Mohamed Irfanulla Mohamed Abdulla
wrote:
> Thank you for your reply. 
> I find that I use the wrong branch. Could you please suggest a good
> branch that I can use?
> 

I'm quite new to the Xenomai project, so don't trust me ;-)

The problem you are facing was "fixed" in commit 
608c23297c4d ("cobalt/x86: Account for FPU changes in kernel 5.2") 
which is part of the "next" branch.

It looks like kernels >= 5.2 are not supported in official releases /
branches yet.

> On Mon, Nov 30, 2020 at 12:00 PM florian.bezdeka@siemens.com <
> florian.bezdeka@siemens.com> wrote:
> > 
> > 
> > 
> > On Mon, 2020-11-30 at 11:49 +0100, Mohamed Irfanulla Mohamed
> > Abdulla
> > via Xenomai wrote:
> > > Hello,
> > > 
> > > I performed the installation of xenomai 3.1 with kernel 5.4.77
> > and
> > > ipipe-core-5.4.77-x86-2.patch on a ubuntu 20.04 machine.
> > > 
> > > I encounter this error during the build.
> > > 
> > >   GEN     usr/initramfs_data.cpio
> > >   AS      usr/initramfs_data.o
> > >   AR      usr/built-in.a
> > >   CC      kernel/cgroup/cgroup.o
> > > arch/x86/xenomai/thread.c: In function ‘xnarch_leave_root’:
> > > arch/x86/xenomai/thread.c:475:2: error: too many arguments to
> > function
> > > ‘switch_fpu_finish’
> > >   switch_fpu_finish(&current->thread.fpu, smp_processor_id());
> > 
> > The signature of switch_fpu_finish changed in 5.2. The second
> > parameter
> > has been removed. 
> > 
> > Please check that you are using the right branch. The calling code
> > in
> > arch/x86/xenomai/thread.c looks correct (and is located at a
> > different
> > line!):
> > 
> > #if LINUX_VERSION_CODE >= KERNEL_VERSION(5,2,0)                   
> >    
> >         switch_fpu_finish(&current->thread.fpu);                   
> >   
> > #else                                                             
> >    
> >         switch_fpu_finish(&current->thread.fpu,
> > smp_processor_id());  
> > #endif
> > 
> > >   ^
> > > In file included from
> > arch/x86/xenomai/include/asm/xenomai/wrappers.h:44:0,
> > >                  from include/xenomai/cobalt/kernel/timer.h:28,
> > >                  from include/xenomai/cobalt/kernel/thread.h:27,
> > >                  from arch/x86/xenomai/thread.c:25:
> > > ./arch/x86/include/asm/fpu/internal.h:594:20: note: declared here
> > >  static inline void switch_fpu_finish(struct fpu *new_fpu)
> > >                     ^
> > > scripts/Makefile.build:265: recipe for target
> > 'arch/x86/xenomai/thread.o'
> > > failed
> > > make[1]: *** [arch/x86/xenomai/thread.o] Error 1
> > > make[1]: *** Waiting for unfinished jobs....
> > >   CC      kernel/cgroup/rstat.o
> > > Makefile:1729: recipe for target 'arch/x86/xenomai' failed
> > > make: *** [arch/x86/xenomai] Error 2
> > > make: *** Waiting for unfinished jobs....
> > >   CC      init/do_mounts_md.o
> > >   CC      kernel/debug/kdb/kdb_io.o
> > > 
> > > Thank you for your suggestions on the config and fix.
> > > 
> > > Irfan
> > 

Re: [xenomai patch with kernel 5.4.77] Error building the kernel

[Jan Kiszka]

On 30.11.20 13:41, florian.bezdeka--- via Xenomai wrote:
> On Mon, 2020-11-30 at 12:16 +0100, Mohamed Irfanulla Mohamed Abdulla
> wrote:
>> Thank you for your reply. 
>> I find that I use the wrong branch. Could you please suggest a good
>> branch that I can use?
>>
> 
> I'm quite new to the Xenomai project, so don't trust me ;-)
> 
> The problem you are facing was "fixed" in commit 
> 608c23297c4d ("cobalt/x86: Account for FPU changes in kernel 5.2") 
> which is part of the "next" branch.
> 
> It looks like kernels >= 5.2 are not supported in official releases /
> branches yet.

Correct. Next 3.1.x release will include that. Until then you need a
version from git.

Jan

-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Re: [xenomai patch with kernel 5.4.77] Error building the kernel

[Mohamed Irfanulla Mohamed Abdulla]

Hi,

Thank you for your reply. I encountered another error.

Kernel: arch/x86/boot/bzImage is ready  (#1)
ERROR: "__ipipe_dispatch_irq" [drivers/pinctrl/intel/pinctrl-intel.ko]
undefined!
make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
make: *** [Makefile:1319: modules] Error 2

Is it good to exclude CONFIG_PINCTRL?

Thanks,

On Mon, Nov 30, 2020 at 2:27 PM Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 30.11.20 13:41, florian.bezdeka--- via Xenomai wrote:
> > On Mon, 2020-11-30 at 12:16 +0100, Mohamed Irfanulla Mohamed Abdulla
> > wrote:
> >> Thank you for your reply.
> >> I find that I use the wrong branch. Could you please suggest a good
> >> branch that I can use?
> >>
> >
> > I'm quite new to the Xenomai project, so don't trust me ;-)
> >
> > The problem you are facing was "fixed" in commit
> > 608c23297c4d ("cobalt/x86: Account for FPU changes in kernel 5.2")
> > which is part of the "next" branch.
> >
> > It looks like kernels >= 5.2 are not supported in official releases /
> > branches yet.
>
> Correct. Next 3.1.x release will include that. Until then you need a
> version from git.
>
> Jan
>
> --
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>

Re: [xenomai patch with kernel 5.4.77] Error building the kernel

[Jan Kiszka]

On 04.12.20 16:13, Mohamed Irfanulla Mohamed Abdulla wrote:
> Hi,
> 
> Thank you for your reply. I encountered another error.
> 
> Kernel: arch/x86/boot/bzImage is ready  (#1)
> ERROR: "__ipipe_dispatch_irq" [drivers/pinctrl/intel/pinctrl-intel.ko]
> undefined!
> make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> make: *** [Makefile:1319: modules] Error 2
> 
> Is it good to exclude CONFIG_PINCTRL?

Only if you do not need that. But there might be cases where this cannot
be off.

Fino, could you have a look?

Jan

> 
> Thanks,
> 
> On Mon, Nov 30, 2020 at 2:27 PM Jan Kiszka <jan.kiszka@siemens.com
> <mailto:jan.kiszka@siemens.com>> wrote:
> 
>     On 30.11.20 13:41, florian.bezdeka--- via Xenomai wrote:
>     > On Mon, 2020-11-30 at 12:16 +0100, Mohamed Irfanulla Mohamed Abdulla
>     > wrote:
>     >> Thank you for your reply. 
>     >> I find that I use the wrong branch. Could you please suggest a good
>     >> branch that I can use?
>     >>
>     >
>     > I'm quite new to the Xenomai project, so don't trust me ;-)
>     >
>     > The problem you are facing was "fixed" in commit
>     > 608c23297c4d ("cobalt/x86: Account for FPU changes in kernel 5.2")
>     > which is part of the "next" branch.
>     >
>     > It looks like kernels >= 5.2 are not supported in official releases /
>     > branches yet.
> 
>     Correct. Next 3.1.x release will include that. Until then you need a
>     version from git.
> 
>     Jan
> 
>     -- 
>     Siemens AG, T RDA IOT
>     Corporate Competence Center Embedded Linux
> 


-- 
Siemens AG, T RDA IOT
Corporate Competence Center Embedded Linux

Re: [xenomai patch with kernel 5.4.77] Error building the kernel

[Fino Meng]

On Mon, Dec 07, 2020 at 07:52:45AM +0100, Jan Kiszka via Xenomai wrote:
> On 04.12.20 16:13, Mohamed Irfanulla Mohamed Abdulla wrote:
> > Hi,
> > 
> > Thank you for your reply. I encountered another error.
> > 
> > Kernel: arch/x86/boot/bzImage is ready  (#1)
> > ERROR: "__ipipe_dispatch_irq" [drivers/pinctrl/intel/pinctrl-intel.ko]
> > undefined!
> > make[1]: *** [scripts/Makefile.modpost:94: __modpost] Error 1
> > make: *** [Makefile:1319: modules] Error 2
> > 
> > Is it good to exclude CONFIG_PINCTRL?
> 
> Only if you do not need that. But there might be cases where this cannot
> be off.
> 
> Fino, could you have a look?
> 
> Jan
> 

the error is compiler&&linker cannot find __ipipe_dispatch_irq when
building pinctrl-intel.ko,
change pinctrl-intel.ko to built-in but not module should solve the
issue.

a dirty fix is export this function:
+EXPORT_SYMBOL_GPL(__ipipe_dispatch_irq);

I will try if can give a clean fix of this issue.

BR fino

> > 
> > Thanks,
> > 
> > On Mon, Nov 30, 2020 at 2:27 PM Jan Kiszka <jan.kiszka@siemens.com
> > <mailto:jan.kiszka@siemens.com>> wrote:
> > 
> >     On 30.11.20 13:41, florian.bezdeka--- via Xenomai wrote:
> >     > On Mon, 2020-11-30 at 12:16 +0100, Mohamed Irfanulla Mohamed Abdulla
> >     > wrote:
> >     >> Thank you for your reply. 
> >     >> I find that I use the wrong branch. Could you please suggest a good
> >     >> branch that I can use?
> >     >>
> >     >
> >     > I'm quite new to the Xenomai project, so don't trust me ;-)
> >     >
> >     > The problem you are facing was "fixed" in commit
> >     > 608c23297c4d ("cobalt/x86: Account for FPU changes in kernel 5.2")
> >     > which is part of the "next" branch.
> >     >
> >     > It looks like kernels >= 5.2 are not supported in official releases /
> >     > branches yet.
> > 
> >     Correct. Next 3.1.x release will include that. Until then you need a
> >     version from git.
> > 
> >     Jan
> > 
> >     -- 
> >     Siemens AG, T RDA IOT
> >     Corporate Competence Center Embedded Linux
> > 
> 
> 
> -- 
> Siemens AG, T RDA IOT
> Corporate Competence Center Embedded Linux
>