From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sakari Ailus Date: Mon, 07 Dec 2020 13:14:47 +0000 Subject: Re: [PATCH] media: i2c: ov02a10: fix an uninitialized return Message-Id: <20201207131446.GA852@paasikivi.fi.intel.com> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Dongchun Zhu , Mauro Carvalho Chehab , Andy Shevchenko , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Hi Dan, On Mon, Dec 07, 2020 at 04:00:29PM +0300, Dan Carpenter wrote: > The "ret" variable isn't set on the no-op path where we are setting to > on/off and it's in the on or off state already. > > Fixes: 91807efbe8ec ("media: i2c: add OV02A10 image sensor driver") > Signed-off-by: Dan Carpenter Thanks for the patch. This issue has been fixed by another patch here: -- Kind regards, Sakari Ailus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 791EEC4361B for ; Mon, 7 Dec 2020 13:16:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 458DF23339 for ; Mon, 7 Dec 2020 13:16:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725804AbgLGNQg (ORCPT ); Mon, 7 Dec 2020 08:16:36 -0500 Received: from mga11.intel.com ([192.55.52.93]:15383 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725550AbgLGNQg (ORCPT ); Mon, 7 Dec 2020 08:16:36 -0500 IronPort-SDR: 9MJvIj5UBPmY/Sp8++NTNgCA5eUo7FYiR7OeWtem8n/mKWG6X/BymJjaoqlG9+ZEaXRIinzPBm 9hJ/kX8fXBCw== X-IronPort-AV: E=McAfee;i="6000,8403,9827"; a="170186434" X-IronPort-AV: E=Sophos;i="5.78,399,1599548400"; d="scan'208";a="170186434" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 05:14:51 -0800 IronPort-SDR: 7X7gGi9e8OQvv5SmocmK0RyRyYCsQgWRDAKF27hovQ57aeLlK9gxzfJaFq1eufj+8RYPoMtfN/ y3sxxtDmxvFw== X-IronPort-AV: E=Sophos;i="5.78,399,1599548400"; d="scan'208";a="407138115" Received: from paasikivi.fi.intel.com ([10.237.72.42]) by orsmga001-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Dec 2020 05:14:49 -0800 Received: by paasikivi.fi.intel.com (Postfix, from userid 1000) id 0C56D20901; Mon, 7 Dec 2020 15:14:47 +0200 (EET) Date: Mon, 7 Dec 2020 15:14:47 +0200 From: Sakari Ailus To: Dan Carpenter Cc: Dongchun Zhu , Mauro Carvalho Chehab , Andy Shevchenko , linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] media: i2c: ov02a10: fix an uninitialized return Message-ID: <20201207131446.GA852@paasikivi.fi.intel.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Dan, On Mon, Dec 07, 2020 at 04:00:29PM +0300, Dan Carpenter wrote: > The "ret" variable isn't set on the no-op path where we are setting to > on/off and it's in the on or off state already. > > Fixes: 91807efbe8ec ("media: i2c: add OV02A10 image sensor driver") > Signed-off-by: Dan Carpenter Thanks for the patch. This issue has been fixed by another patch here: -- Kind regards, Sakari Ailus