From: kernel test robot <lkp@intel.com>
To: kbuild-all@lists.01.org
Subject: [chrome-os:chromeos-5.4 14/121] drivers/remoteproc/qcom_sysmon.c:554:27: warning: Uninitialized variable: acked
Date: Mon, 07 Dec 2020 19:52:21 +0800 [thread overview]
Message-ID: <202012071919.DoanAa4n-lkp@intel.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1774 bytes --]
tree: https://chromium.googlesource.com/chromiumos/third_party/kernel chromeos-5.4
head: d2eadaa20e1688b9c0de94471c60262b1bc38d41
commit: 9f25020575a9accfc8746d32258b86c9e3ea982a [14/121] FROMGIT: remoteproc: sysmon: Expose the shutdown result
compiler: aarch64-linux-gcc (GCC) 9.3.0
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
"cppcheck warnings: (new ones prefixed by >>)"
>> drivers/remoteproc/qcom_sysmon.c:554:27: warning: Uninitialized variable: acked [uninitvar]
sysmon->shutdown_acked = acked;
^
vim +554 drivers/remoteproc/qcom_sysmon.c
528
529 static void sysmon_stop(struct rproc_subdev *subdev, bool crashed)
530 {
531 struct qcom_sysmon *sysmon = container_of(subdev, struct qcom_sysmon, subdev);
532 struct sysmon_event event = {
533 .subsys_name = sysmon->name,
534 .ssr_event = SSCTL_SSR_EVENT_BEFORE_SHUTDOWN
535 };
536 bool acked;
537
538 sysmon->shutdown_acked = false;
539
540 mutex_lock(&sysmon->state_lock);
541 sysmon->state = SSCTL_SSR_EVENT_BEFORE_SHUTDOWN;
542 blocking_notifier_call_chain(&sysmon_notifiers, 0, (void *)&event);
543 mutex_unlock(&sysmon->state_lock);
544
545 /* Don't request graceful shutdown if we've crashed */
546 if (crashed)
547 return;
548
549 if (sysmon->ssctl_version)
550 acked = ssctl_request_shutdown(sysmon);
551 else if (sysmon->ept)
552 acked = sysmon_request_shutdown(sysmon);
553
> 554 sysmon->shutdown_acked = acked;
555 }
556
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org
reply other threads:[~2020-12-07 11:52 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202012071919.DoanAa4n-lkp@intel.com \
--to=lkp@intel.com \
--cc=kbuild-all@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.