From: Al Viro <viro@zeniv.linux.org.uk>
To: Pavel Begunkov <asml.silence@gmail.com>
Cc: linux-kernel@vger.kernel.org, Jens Axboe <axboe@kernel.dk>
Subject: Re: [RFC] exit: do exit_task_work() before shooting off mm
Date: Tue, 8 Dec 2020 01:37:22 +0000 [thread overview]
Message-ID: <20201208013722.GG3579531@ZenIV.linux.org.uk> (raw)
In-Reply-To: <abab9af4e0d26358538a45a2826650e9cefd2924.1606961931.git.asml.silence@gmail.com>
On Thu, Dec 03, 2020 at 02:30:46AM +0000, Pavel Begunkov wrote:
> Handle task works and lock it earlier before it starts killing off
> task's resources like mm. io_uring makes use of it a lot and it'd
> nicer to have all added task_work finding tasks in a consistent state.
>
> Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
> ---
>
> Would it be correct? I clearly don't know all the exit invariants, but
> can't find any users relying on task_works in-between.
You've just gotten rid of exit_task_work() anywhere after exit_files().
And exit_mm() can trigger the final fput() just as easily as exit_files().
IOW, you have just made the effect of final close on exit() completely
asynchronous.
NAK.
next prev parent reply other threads:[~2020-12-08 1:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 2:30 [RFC] exit: do exit_task_work() before shooting off mm Pavel Begunkov
2020-12-08 1:37 ` Al Viro [this message]
2020-12-08 3:00 ` Pavel Begunkov
2020-12-20 12:50 ` Pavel Begunkov
2020-12-20 13:58 ` Oleg Nesterov
2020-12-20 14:42 ` Pavel Begunkov
2020-12-14 14:51 ` [exit] 80fae08355: stderr.mount:/fs/sda1:/dev/sda1_already_mounted_or_mount_point_busy kernel test robot
2020-12-14 14:51 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208013722.GG3579531@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=asml.silence@gmail.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.