From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E97BC4167B for ; Tue, 8 Dec 2020 23:45:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 004A023A5A for ; Tue, 8 Dec 2020 23:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728899AbgLHXpV (ORCPT ); Tue, 8 Dec 2020 18:45:21 -0500 Received: from mail-oo1-f68.google.com ([209.85.161.68]:43277 "EHLO mail-oo1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725906AbgLHXpV (ORCPT ); Tue, 8 Dec 2020 18:45:21 -0500 Received: by mail-oo1-f68.google.com with SMTP id h10so27296ooi.10; Tue, 08 Dec 2020 15:45:05 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2KQe3ieI4VGx3q64G5WEEcvcuIvQWP0JOsj4euuGCD4=; b=OrX9GHZvCfHAknB9P2X54ECdmKgSGpFoTcORlCVnCS23nW4ulRdLJgNSKmKAPCF6Or 5v5fZaoWNGKtKQIemtgLsSVm1qZ+ikbWtNIaehq+j9n+06cBg60J2cnBGV/kWZfhEx/L bYzI6R+RU/gxho/Y0ulweO8L7dMYt3+WZB74NqNZjI8+YLhg/7UxEnbcusLXGHoaCsZp hTrWo94vNTBItCLC4B0YqBLKn5aeGE0IgRDzUF56f4piBWWvj7BwyGuU5VQBw2t3Wyuy JsFjOF0xeC2+zFk7yxYZudwq6m2eG1Jb0KghqeQziv/8Zm4CSxr+5BP2j8PUB5E9Kyyh dd+g== X-Gm-Message-State: AOAM531zIxo6IxMD6HGYh9d4/MblUTrEWZpmF+H0iI5qkGKravAF+F+r Vikj5mnbeA1UiYmgnI+XQy+OdKqGYw== X-Google-Smtp-Source: ABdhPJyAVXhvxZdVU1wfFlHBFF7RuBp3jz769lshkAFJpz5/IO3/3ARnwahnkYM01JE3/w3Me5Gluw== X-Received: by 2002:a4a:8606:: with SMTP id v6mr367244ooh.37.1607471080259; Tue, 08 Dec 2020 15:44:40 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y35sm81148otb.5.2020.12.08.15.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 15:44:39 -0800 (PST) Received: (nullmailer pid 3339100 invoked by uid 1000); Tue, 08 Dec 2020 23:44:37 -0000 Date: Tue, 8 Dec 2020 17:44:37 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Lorenzo Pieralisi , Bjorn Helgaas , linux-pci@vger.kernel.org, devicetree@vger.kernel.org, Florian Fainelli , Nicolas Saenz Julienne , Philipp Zabel , linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, bcm-kernel-feedback-list@broadcom.com, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V2 1/2] dt-bindings: PCI: brcmstb: add BCM4908 binding Message-ID: <20201208234437.GA3334335@robh.at.kernel.org> References: <20201130083223.32594-1-zajec5@gmail.com> <20201130083223.32594-2-zajec5@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201130083223.32594-2-zajec5@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Mon, Nov 30, 2020 at 09:32:22AM +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > BCM4908 is a SoC family with PCIe controller sharing design with the one > for STB. BCM4908 has different power management and memory controller so > few tweaks are required. > > PERST# signal on BCM4908 is handled by an external MISC block so it > needs specifying a reset phandle. > > Signed-off-by: Rafał Miłecki > Acked-by: Florian Fainelli > --- > .../bindings/pci/brcm,stb-pcie.yaml | 30 +++++++++++++++++-- > 1 file changed, 28 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > index 807694b4f41f..d3ab9e22f97c 100644 > --- a/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/brcm,stb-pcie.yaml > @@ -14,6 +14,7 @@ properties: > items: > - enum: > - brcm,bcm2711-pcie # The Raspberry Pi 4 > + - brcm,bcm4908-pcie > - brcm,bcm7211-pcie # Broadcom STB version of RPi4 > - brcm,bcm7278-pcie # Broadcom 7278 Arm > - brcm,bcm7216-pcie # Broadcom 7216 Arm > @@ -64,8 +65,6 @@ properties: > aspm-no-l0s: true > > resets: > - description: for "brcm,bcm7216-pcie", must be a valid reset > - phandle pointing to the RESCAL reset controller provider node. > $ref: "/schemas/types.yaml#/definitions/phandle" This should really just be 'maxItems: 1'. 'resets' already has a type. > > reset-names: > @@ -98,12 +97,39 @@ required: > > allOf: > - $ref: /schemas/pci/pci-bus.yaml# > + - if: > + properties: > + compatible: > + contains: > + const: brcm,bcm4908-pcie > + then: > + properties: > + resets: > + items: > + - description: reset controller handling the PERST# signal > + > + reset-names: > + items: > + - const: perst > + > + required: > + - resets > + - reset-names > - if: > properties: > compatible: > contains: > const: brcm,bcm7216-pcie > then: > + properties: > + resets: > + items: > + - description: phandle pointing to the RESCAL reset controller > + > + reset-names: > + items: > + - const: rescal > + > required: > - resets > - reset-names > -- > 2.26.2 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ACAA9C4361B for ; Tue, 8 Dec 2020 23:45:52 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 65FD3238EE for ; Tue, 8 Dec 2020 23:45:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 65FD3238EE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=2ReIzQmAVQbHD/nGjm80A2/vGT8vc/St/rr0H2Gg9HU=; b=yy7reXVPEbW6HMxSnko2o/JnB P82dJcSztPQ+bnEOmwNj6zeMX+N99c1cenyJFjwuKtSNJ6EQcopK4Lpj5vX9yizI5DP7FNZdusdfx 9AaMYj7aiNZfEiSW0lHNALL//Hfs5+wa5UeMrxpNJNyKovRbSjkNUXme6zTXjfJUinR7z9ucU+wMK OsR0ONCkA8uRBZhAPr830AeTcLMvIKaZPPZJ0lkypavu8uOGkk8Igji2pkCLN+GUUu32XnZ5WtS2T wJMXsbi98ZIQsdx2hX8eFCy2jWDLWyvRle7/Y39MmmeVh9u29UkyGo8m9qMH7HB3t4qUpwOCJoHFM L0hhbpCTg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmmex-0005Fq-PN; Tue, 08 Dec 2020 23:44:43 +0000 Received: from mail-oo1-f65.google.com ([209.85.161.65]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kmmev-0005FA-3L; Tue, 08 Dec 2020 23:44:41 +0000 Received: by mail-oo1-f65.google.com with SMTP id s1so36593oon.2; Tue, 08 Dec 2020 15:44:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=2KQe3ieI4VGx3q64G5WEEcvcuIvQWP0JOsj4euuGCD4=; b=aEpl/e8AejW8LLsdxTltGo6IfKOFAP0aRBtqTo792FMOoXvL4cbw0HRQqWEU82kviD lqijG+Ev5M08Eb8pNimUTIB3H2J8u6xZ3ye/26+AvZAuA9eSixJIhhJtHfTzWR/hzhbU tX9CeGHklRsCBfA+64lCemlhoh0wpvp/42GEMofBNoHm0rHfhtli4ZdjofvTFvuqkpWt LwJHYHiSNbtG/kB9JzFoBNMOpQmQndn1ppF/fNzjBBccC+jsHdTYo2x+Jw35GKG9XrGq /j726S+nAZp2wEn0pclJrN/KspR42P2gyVAy10TJgo0AdSMUe/yXmnUmMhJHtwbw0ZBl ERfg== X-Gm-Message-State: AOAM5332e5O85DNCvNpD+ay9shpR2L+QibCBB+qodBsBX41CHnq5pHH+ hhfa6SR0uD2eKKs4QkchLQ== X-Google-Smtp-Source: ABdhPJyAVXhvxZdVU1wfFlHBFF7RuBp3jz769lshkAFJpz5/IO3/3ARnwahnkYM01JE3/w3Me5Gluw== X-Received: by 2002:a4a:8606:: with SMTP id v6mr367244ooh.37.1607471080259; Tue, 08 Dec 2020 15:44:40 -0800 (PST) Received: from xps15 (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id y35sm81148otb.5.2020.12.08.15.44.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Dec 2020 15:44:39 -0800 (PST) Received: (nullmailer pid 3339100 invoked by uid 1000); Tue, 08 Dec 2020 23:44:37 -0000 Date: Tue, 8 Dec 2020 17:44:37 -0600 From: Rob Herring To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Subject: Re: [PATCH V2 1/2] dt-bindings: PCI: brcmstb: add BCM4908 binding Message-ID: <20201208234437.GA3334335@robh.at.kernel.org> References: <20201130083223.32594-1-zajec5@gmail.com> <20201130083223.32594-2-zajec5@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201130083223.32594-2-zajec5@gmail.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201208_184441_177287_32A49F0C X-CRM114-Status: GOOD ( 18.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Lorenzo Pieralisi , linux-pci@vger.kernel.org, =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, linux-rpi-kernel@lists.infradead.org, Philipp Zabel , Bjorn Helgaas , Nicolas Saenz Julienne Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBOb3YgMzAsIDIwMjAgYXQgMDk6MzI6MjJBTSArMDEwMCwgUmFmYcWCIE1pxYJlY2tp IHdyb3RlOgo+IEZyb206IFJhZmHFgiBNacWCZWNraSA8cmFmYWxAbWlsZWNraS5wbD4KPiAKPiBC Q000OTA4IGlzIGEgU29DIGZhbWlseSB3aXRoIFBDSWUgY29udHJvbGxlciBzaGFyaW5nIGRlc2ln biB3aXRoIHRoZSBvbmUKPiBmb3IgU1RCLiBCQ000OTA4IGhhcyBkaWZmZXJlbnQgcG93ZXIgbWFu YWdlbWVudCBhbmQgbWVtb3J5IGNvbnRyb2xsZXIgc28KPiBmZXcgdHdlYWtzIGFyZSByZXF1aXJl ZC4KPiAKPiBQRVJTVCMgc2lnbmFsIG9uIEJDTTQ5MDggaXMgaGFuZGxlZCBieSBhbiBleHRlcm5h bCBNSVNDIGJsb2NrIHNvIGl0Cj4gbmVlZHMgc3BlY2lmeWluZyBhIHJlc2V0IHBoYW5kbGUuCj4g Cj4gU2lnbmVkLW9mZi1ieTogUmFmYcWCIE1pxYJlY2tpIDxyYWZhbEBtaWxlY2tpLnBsPgo+IEFj a2VkLWJ5OiBGbG9yaWFuIEZhaW5lbGxpIDxmLmZhaW5lbGxpQGdtYWlsLmNvbT4KPiAtLS0KPiAg Li4uL2JpbmRpbmdzL3BjaS9icmNtLHN0Yi1wY2llLnlhbWwgICAgICAgICAgIHwgMzAgKysrKysr KysrKysrKysrKystLQo+ICAxIGZpbGUgY2hhbmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMiBkZWxl dGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp bmdzL3BjaS9icmNtLHN0Yi1wY2llLnlhbWwgYi9Eb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmlu ZGluZ3MvcGNpL2JyY20sc3RiLXBjaWUueWFtbAo+IGluZGV4IDgwNzY5NGI0ZjQxZi4uZDNhYjll MjJmOTdjIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9w Y2kvYnJjbSxzdGItcGNpZS55YW1sCj4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL3BjaS9icmNtLHN0Yi1wY2llLnlhbWwKPiBAQCAtMTQsNiArMTQsNyBAQCBwcm9wZXJ0 aWVzOgo+ICAgICAgaXRlbXM6Cj4gICAgICAgIC0gZW51bToKPiAgICAgICAgICAgIC0gYnJjbSxi Y20yNzExLXBjaWUgIyBUaGUgUmFzcGJlcnJ5IFBpIDQKPiArICAgICAgICAgIC0gYnJjbSxiY200 OTA4LXBjaWUKPiAgICAgICAgICAgIC0gYnJjbSxiY203MjExLXBjaWUgIyBCcm9hZGNvbSBTVEIg dmVyc2lvbiBvZiBSUGk0Cj4gICAgICAgICAgICAtIGJyY20sYmNtNzI3OC1wY2llICMgQnJvYWRj b20gNzI3OCBBcm0KPiAgICAgICAgICAgIC0gYnJjbSxiY203MjE2LXBjaWUgIyBCcm9hZGNvbSA3 MjE2IEFybQo+IEBAIC02NCw4ICs2NSw2IEBAIHByb3BlcnRpZXM6Cj4gICAgYXNwbS1uby1sMHM6 IHRydWUKPiAgCj4gICAgcmVzZXRzOgo+IC0gICAgZGVzY3JpcHRpb246IGZvciAiYnJjbSxiY203 MjE2LXBjaWUiLCBtdXN0IGJlIGEgdmFsaWQgcmVzZXQKPiAtICAgICAgcGhhbmRsZSBwb2ludGlu ZyB0byB0aGUgUkVTQ0FMIHJlc2V0IGNvbnRyb2xsZXIgcHJvdmlkZXIgbm9kZS4KPiAgICAgICRy ZWY6ICIvc2NoZW1hcy90eXBlcy55YW1sIy9kZWZpbml0aW9ucy9waGFuZGxlIgoKVGhpcyBzaG91 bGQgcmVhbGx5IGp1c3QgYmUgJ21heEl0ZW1zOiAxJy4gJ3Jlc2V0cycgYWxyZWFkeSBoYXMgYSB0 eXBlLgoKPiAgCj4gICAgcmVzZXQtbmFtZXM6Cj4gQEAgLTk4LDEyICs5NywzOSBAQCByZXF1aXJl ZDoKPiAgCj4gIGFsbE9mOgo+ICAgIC0gJHJlZjogL3NjaGVtYXMvcGNpL3BjaS1idXMueWFtbCMK PiArICAtIGlmOgo+ICsgICAgICBwcm9wZXJ0aWVzOgo+ICsgICAgICAgIGNvbXBhdGlibGU6Cj4g KyAgICAgICAgICBjb250YWluczoKPiArICAgICAgICAgICAgY29uc3Q6IGJyY20sYmNtNDkwOC1w Y2llCj4gKyAgICB0aGVuOgo+ICsgICAgICBwcm9wZXJ0aWVzOgo+ICsgICAgICAgIHJlc2V0czoK PiArICAgICAgICAgIGl0ZW1zOgo+ICsgICAgICAgICAgICAtIGRlc2NyaXB0aW9uOiByZXNldCBj b250cm9sbGVyIGhhbmRsaW5nIHRoZSBQRVJTVCMgc2lnbmFsCj4gKwo+ICsgICAgICAgIHJlc2V0 LW5hbWVzOgo+ICsgICAgICAgICAgaXRlbXM6Cj4gKyAgICAgICAgICAgIC0gY29uc3Q6IHBlcnN0 Cj4gKwo+ICsgICAgICByZXF1aXJlZDoKPiArICAgICAgICAtIHJlc2V0cwo+ICsgICAgICAgIC0g cmVzZXQtbmFtZXMKPiAgICAtIGlmOgo+ICAgICAgICBwcm9wZXJ0aWVzOgo+ICAgICAgICAgIGNv bXBhdGlibGU6Cj4gICAgICAgICAgICBjb250YWluczoKPiAgICAgICAgICAgICAgY29uc3Q6IGJy Y20sYmNtNzIxNi1wY2llCj4gICAgICB0aGVuOgo+ICsgICAgICBwcm9wZXJ0aWVzOgo+ICsgICAg ICAgIHJlc2V0czoKPiArICAgICAgICAgIGl0ZW1zOgo+ICsgICAgICAgICAgICAtIGRlc2NyaXB0 aW9uOiBwaGFuZGxlIHBvaW50aW5nIHRvIHRoZSBSRVNDQUwgcmVzZXQgY29udHJvbGxlcgo+ICsK PiArICAgICAgICByZXNldC1uYW1lczoKPiArICAgICAgICAgIGl0ZW1zOgo+ICsgICAgICAgICAg ICAtIGNvbnN0OiByZXNjYWwKPiArCj4gICAgICAgIHJlcXVpcmVkOgo+ICAgICAgICAgIC0gcmVz ZXRzCj4gICAgICAgICAgLSByZXNldC1uYW1lcwo+IC0tIAo+IDIuMjYuMgo+IAoKX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBt YWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9s aXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=