From: Lee Jones <lee.jones@linaro.org>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Jonathan Corbet <corbet@lwn.net>, Jens Axboe <axboe@kernel.dk>,
Viresh Kumar <vireshk@kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Dan Williams <dan.j.williams@intel.com>,
Vinod Koul <vkoul@kernel.org>, David Miller <davem@davemloft.net>,
Ion Badulescu <ionut@badula.org>,
Jakub Kicinski <kuba@kernel.org>,
Lino Sanfilippo <LinoSanfilippo@gmx.de>,
Christian Lamparter <chunkeey@googlemail.com>,
Kalle Valo <kvalo@codeaurora.org>,
Luis Chamberlain <mcgrof@kernel.org>,
Adam Radford <aradford@gmail.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
James Smart <james.smart@broadcom.com>,
Dick Kennedy <dick.kennedy@broadcom.com>,
Nilesh Javali <njavali@marvell.com>,
GR-QLogic-Storage-Upstream@marvell.com,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jirislaby@kernel.org>,
Peter Chen <Peter.Chen@nxp.com>, Felipe Balbi <balbi@kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
linux-doc@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org, dmaengine@vger.kernel.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
linux-parisc@vger.kernel.org,
linux-wireless <linux-wireless@vger.kernel.org>,
SCSI development list <linux-scsi@vger.kernel.org>,
linux-serial@vger.kernel.org,
Linux USB Mailing List <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] PCI: Remove pci_try_set_mwi
Date: Wed, 9 Dec 2020 09:22:24 +0000 [thread overview]
Message-ID: <20201209092224.GU4801@dell> (raw)
In-Reply-To: <4d535d35-6c8c-2bd8-812b-2b53194ce0ec@gmail.com>
On Wed, 09 Dec 2020, Heiner Kallweit wrote:
> pci_set_mwi() and pci_try_set_mwi() do exactly the same, just that the
> former one is declared as __must_check. However also some callers of
> pci_set_mwi() have a comment that it's an optional feature. I don't
> think there's much sense in this separation and the use of
> __must_check. Therefore remove pci_try_set_mwi() and remove the
> __must_check attribute from pci_set_mwi().
> I don't expect either function to be used in new code anyway.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
> ---
> patch applies on top of pci/misc for v5.11
> ---
> Documentation/PCI/pci.rst | 5 +----
> drivers/ata/pata_cs5530.c | 2 +-
> drivers/ata/sata_mv.c | 2 +-
> drivers/dma/dw/pci.c | 2 +-
> drivers/dma/hsu/pci.c | 2 +-
> drivers/ide/cs5530.c | 2 +-
> drivers/mfd/intel-lpss-pci.c | 2 +-
Acked-by: Lee Jones <lee.jones@linaro.org>
> drivers/net/ethernet/adaptec/starfire.c | 2 +-
> drivers/net/ethernet/alacritech/slicoss.c | 2 +-
> drivers/net/ethernet/dec/tulip/tulip_core.c | 5 +----
> drivers/net/ethernet/sun/cassini.c | 4 ++--
> drivers/net/wireless/intersil/p54/p54pci.c | 2 +-
> .../intersil/prism54/islpci_hotplug.c | 3 +--
> .../wireless/realtek/rtl818x/rtl8180/dev.c | 2 +-
> drivers/pci/pci.c | 19 -------------------
> drivers/scsi/3w-9xxx.c | 4 ++--
> drivers/scsi/3w-sas.c | 4 ++--
> drivers/scsi/csiostor/csio_init.c | 2 +-
> drivers/scsi/lpfc/lpfc_init.c | 2 +-
> drivers/scsi/qla2xxx/qla_init.c | 8 ++++----
> drivers/scsi/qla2xxx/qla_mr.c | 2 +-
> drivers/tty/serial/8250/8250_lpss.c | 2 +-
> drivers/usb/chipidea/ci_hdrc_pci.c | 2 +-
> drivers/usb/gadget/udc/amd5536udc_pci.c | 2 +-
> drivers/usb/gadget/udc/net2280.c | 2 +-
> drivers/usb/gadget/udc/pch_udc.c | 2 +-
> include/linux/pci.h | 5 ++---
> 27 files changed, 33 insertions(+), 60 deletions(-)
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2020-12-09 9:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 8:31 [PATCH] PCI: Remove pci_try_set_mwi Heiner Kallweit
2020-12-09 8:40 ` Kalle Valo
2020-12-09 9:03 ` Vinod Koul
2020-12-09 9:20 ` Peter Chen
2020-12-09 9:22 ` Lee Jones [this message]
2020-12-09 10:59 ` Andy Shevchenko
2020-12-09 11:02 ` Andy Shevchenko
2021-03-26 21:26 ` Bjorn Helgaas
2021-03-26 21:42 ` Andy Shevchenko
2021-03-26 21:55 ` Bjorn Helgaas
2021-03-27 23:04 ` Heiner Kallweit
2021-03-28 19:58 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209092224.GU4801@dell \
--to=lee.jones@linaro.org \
--cc=GR-QLogic-Storage-Upstream@marvell.com \
--cc=LinoSanfilippo@gmx.de \
--cc=Peter.Chen@nxp.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aradford@gmail.com \
--cc=axboe@kernel.dk \
--cc=balbi@kernel.org \
--cc=bhelgaas@google.com \
--cc=chunkeey@googlemail.com \
--cc=corbet@lwn.net \
--cc=dan.j.williams@intel.com \
--cc=davem@davemloft.net \
--cc=dick.kennedy@broadcom.com \
--cc=dmaengine@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hkallweit1@gmail.com \
--cc=ionut@badula.org \
--cc=james.smart@broadcom.com \
--cc=jejb@linux.ibm.com \
--cc=jirislaby@kernel.org \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mcgrof@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=njavali@marvell.com \
--cc=vireshk@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.