From: "Michael S. Tsirkin" <mst@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: marcandre.lureau@redhat.com, qemu-devel@nongnu.org,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v2 6/8] libvhost-user: check memfd API
Date: Wed, 9 Dec 2020 13:08:34 -0500 [thread overview]
Message-ID: <20201209130729-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20201202142753.GH655829@stefanha-x1.localdomain>
On Wed, Dec 02, 2020 at 02:27:53PM +0000, Stefan Hajnoczi wrote:
> On Wed, Nov 25, 2020 at 02:06:38PM +0400, marcandre.lureau@redhat.com wrote:
> > From: Marc-André Lureau <marcandre.lureau@redhat.com>
> >
> > Do not compile potentially panicking code, instead check memfd API is
> > present during configure time.
> >
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> > ---
> > subprojects/libvhost-user/libvhost-user.c | 6 ------
> > subprojects/libvhost-user/meson.build | 12 ++++++++++++
> > 2 files changed, 12 insertions(+), 6 deletions(-)
>
> Runtime checks are useful in environments where the QEMU and kernel
> version are not matched. In other words, if QEMU can be built against
> new kernel headers and launched on an old kernel then it needs to handle
> ENOSYS. But in some cases this situation is unlikely and we can stick to
> static feature checks. I'm not sure if it matters here, so...
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
It's a good point, and given this patch also made build fail on a bunch
of systems, I dropped it.
--
MST
next prev parent reply other threads:[~2020-12-09 18:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-25 10:06 [PATCH v2 0/8] libvhost-user: make it a subproject (was: "lower dependency on QEMU headers") marcandre.lureau
2020-11-25 10:06 ` [PATCH v2 1/8] libvhost-user: replace qemu/bswap.h with glibc endian.h marcandre.lureau
2020-12-02 14:20 ` Stefan Hajnoczi
2020-11-25 10:06 ` [PATCH v2 2/8] libvhost-user: replace qemu/memfd.h usage marcandre.lureau
2020-12-02 14:20 ` Stefan Hajnoczi
2020-11-25 10:06 ` [PATCH v2 3/8] libvhost-user: remove qemu/compiler.h usage marcandre.lureau
2020-12-02 14:20 ` Stefan Hajnoczi
2020-11-25 10:06 ` [PATCH v2 4/8] libvhost-user: drop qemu/osdep.h dependency marcandre.lureau
2020-12-02 14:20 ` Stefan Hajnoczi
2020-11-25 10:06 ` [PATCH v2 5/8] libvhost-user: make it a meson subproject marcandre.lureau
2020-12-02 14:25 ` Stefan Hajnoczi
2020-11-25 10:06 ` [PATCH v2 6/8] libvhost-user: check memfd API marcandre.lureau
2020-12-02 14:27 ` Stefan Hajnoczi
2020-12-09 18:08 ` Michael S. Tsirkin [this message]
2020-11-25 10:06 ` [PATCH v2 7/8] libvhost-user: add a simple link test without glib marcandre.lureau
2020-12-02 14:28 ` Stefan Hajnoczi
2020-11-25 10:06 ` [PATCH v2 8/8] .gitlab-ci: add build-libvhost-user marcandre.lureau
2020-12-02 14:28 ` Stefan Hajnoczi
2020-12-02 14:49 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209130729-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.