From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 311A5C4361B for ; Thu, 10 Dec 2020 11:34:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D4E9B23D57 for ; Thu, 10 Dec 2020 11:34:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732556AbgLJLeb (ORCPT ); Thu, 10 Dec 2020 06:34:31 -0500 Received: from mga11.intel.com ([192.55.52.93]:16536 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727149AbgLJLeU (ORCPT ); Thu, 10 Dec 2020 06:34:20 -0500 IronPort-SDR: Ut5zoj7FwXankmGOR28pGzamW8iKEI6CDyEtWseIw0vPFnA+M0OGmj1Ud6x6RjRFQ6N5zFcdmU xWhJtSytqjKw== X-IronPort-AV: E=McAfee;i="6000,8403,9830"; a="170732060" X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="170732060" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 03:32:34 -0800 IronPort-SDR: VSPww2xSyJ1jwgHSm10TH7YLDBIp3WPatk1kyCCNsdQsg+yEziz23pdrbr38sDHAgUxN2OHgCt 6Su7XgnD1GIw== X-IronPort-AV: E=Sophos;i="5.78,408,1599548400"; d="scan'208";a="319024823" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Dec 2020 03:32:32 -0800 Received: from andy by smile with local (Exim 4.94) (envelope-from ) id 1knKCU-00DP8D-Hr; Thu, 10 Dec 2020 13:33:34 +0200 Date: Thu, 10 Dec 2020 13:33:34 +0200 From: Andy Shevchenko To: Marco Felsch Cc: Dmitry Torokhov , linux-input@vger.kernel.org, Philipp Zabel , Simon Budig , linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: edt-ft5x06 - consolidate handling of number of electrodes Message-ID: <20201210113334.GD4077@smile.fi.intel.com> References: <20201210100803.bfohc5fglvrwrtcz@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201210100803.bfohc5fglvrwrtcz@pengutronix.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org On Thu, Dec 10, 2020 at 11:08:03AM +0100, Marco Felsch wrote: > On 20-12-09 15:09, Dmitry Torokhov wrote: ... > > case EV_FT: > > reg_addr->reg_threshold = EV_REGISTER_THRESHOLD; > > + reg_addr->reg_report_rate = NO_REGISTER; > > reg_addr->reg_gain = EV_REGISTER_GAIN; > > reg_addr->reg_offset = NO_REGISTER; > > reg_addr->reg_offset_x = EV_REGISTER_OFFSET_X; > > reg_addr->reg_offset_y = EV_REGISTER_OFFSET_Y; > > reg_addr->reg_num_x = NO_REGISTER; > > reg_addr->reg_num_y = NO_REGISTER; > > - reg_addr->reg_report_rate = NO_REGISTER; > > break; > > Nit: > Unrelated change. I guess the motive is to get these assignments consistent between the cases. Documentation actually allows this kind of modifications of code in one change when them are toughly related. -- With Best Regards, Andy Shevchenko