All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonsoo Kim <js1304@gmail.com>
To: Yu Zhao <yuzhao@google.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	Vlastimil Babka <vbabka@suse.cz>,
	linux-mm@kvack.org
Subject: Re: [PATCH] mm: don't SetPageWorkingset unconditionally during swapin
Date: Thu, 10 Dec 2020 21:06:44 +0900	[thread overview]
Message-ID: <20201210120554.GA19730@js1304-desktop> (raw)
In-Reply-To: <20201209012400.1771150-1-yuzhao@google.com>

On Tue, Dec 08, 2020 at 06:24:00PM -0700, Yu Zhao wrote:
> We are capable of SetPageWorkingset based on refault distances after
> commit aae466b0052e ("mm/swap: implement workingset detection for anonymous LRU")
> This is done by workingset_refault(), which is right above the
> unconditional SetPageWorkingset deleted by this patch.
> 
> The unconditional SetPageWorkingset miscategorizes pages that are
> read ahead or never belonged to the working set (e.g., tmpfs pages
> accessed by fd). When those pages are swapped in (after they were
> swapped out) for the first time, they skew PSI (when using
> async swap). When this happens again, depending on their refault
> distances, they might skew workingset_restore_anon counter in
> addition to PSI because their shadows say they were part of the
> working set.
> 
> Signed-off-by: Yu Zhao <yuzhao@google.com>

Acked-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Thanks


      parent reply	other threads:[~2020-12-10 12:06 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-09  1:24 [PATCH] mm: don't SetPageWorkingset unconditionally during swapin Yu Zhao
2020-12-09  9:18 ` Vlastimil Babka
2020-12-10 11:21   ` Johannes Weiner
2020-12-10 22:44     ` Yu Zhao
2020-12-14 16:09     ` Michal Hocko
2020-12-14 23:12       ` [PATCH] mm/swap: " Yu Zhao
2020-12-10 10:47 ` [PATCH] mm: " Johannes Weiner
2020-12-10 12:06 ` Joonsoo Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201210120554.GA19730@js1304-desktop \
    --to=js1304@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hannes@cmpxchg.org \
    --cc=linux-mm@kvack.org \
    --cc=vbabka@suse.cz \
    --cc=yuzhao@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.