From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B4B2C4361B for ; Thu, 10 Dec 2020 13:50:43 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E93923119 for ; Thu, 10 Dec 2020 13:50:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E93923119 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38422 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1knMLB-00046e-37 for qemu-devel@archiver.kernel.org; Thu, 10 Dec 2020 08:50:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36262) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knLLl-0004vl-Ci for qemu-devel@nongnu.org; Thu, 10 Dec 2020 07:47:14 -0500 Received: from 1.mo52.mail-out.ovh.net ([178.32.96.117]:39126) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1knLLj-0008TF-8d for qemu-devel@nongnu.org; Thu, 10 Dec 2020 07:47:13 -0500 Received: from mxplan5.mail.ovh.net (unknown [10.108.1.249]) by mo52.mail-out.ovh.net (Postfix) with ESMTPS id 4318321B178; Thu, 10 Dec 2020 13:47:07 +0100 (CET) Received: from kaod.org (37.59.142.98) by DAG8EX1.mxp5.local (172.16.2.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2044.4; Thu, 10 Dec 2020 13:47:06 +0100 Authentication-Results: garm.ovh; auth=pass (GARM-98R002484774bf-3e38-4c97-a087-06a5157e2c5e, 7F90A86A4359BCD1ACB0618936AE64BD6AD86209) smtp.auth=groug@kaod.org Date: Thu, 10 Dec 2020 13:47:05 +0100 From: Greg Kurz To: Paolo Bonzini Subject: Re: [PATCH 1/1] spapr.c: set a 'kvm-type' default value instead of relying on NULL Message-ID: <20201210134705.6adaf940@bahia.lan> In-Reply-To: References: <20201208134536.1012045-1-danielhb413@gmail.com> <20201208153309.78825861@bahia.lan> <20201210033736.GK2555@yekko.fritz.box> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [37.59.142.98] X-ClientProxiedBy: DAG9EX2.mxp5.local (172.16.2.82) To DAG8EX1.mxp5.local (172.16.2.71) X-Ovh-Tracer-GUID: 5273a86c-4857-47db-8b3e-7c31262ac0ff X-Ovh-Tracer-Id: 1786240205325179299 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedujedrudektddggeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuqfggjfdpvefjgfevmfevgfenuceurghilhhouhhtmecuhedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepfffhvffukfgjfhfogggtgfhisehtjeertdertddvnecuhfhrohhmpefirhgvghcumfhurhiiuceoghhrohhugheskhgrohgurdhorhhgqeenucggtffrrghtthgvrhhnpeefuddtieejjeevheekieeltefgleetkeetheettdeifeffvefhffelffdtfeeljeenucfkpheptddrtddrtddrtddpfeejrdehledrudegvddrleeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepmhigphhlrghnhedrmhgrihhlrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpehgrhhouhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdqphhptgesnhhonhhgnhhurdhorhhg Received-SPF: pass client-ip=178.32.96.117; envelope-from=groug@kaod.org; helo=1.mo52.mail-out.ovh.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Henrique Barboza , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, David Gibson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, 10 Dec 2020 13:34:59 +0100 Paolo Bonzini wrote: > To sum up everything: > LGTM > diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c > index 2d5aeeb45a..61f0963916 100644 > --- a/hw/ppc/spapr.c > +++ b/hw/ppc/spapr.c > @@ -3028,11 +3028,11 @@ static int spapr_kvm_type(MachineState *machine, > const char *vm_type) > return 0; > } > > - if (!strcmp(vm_type, "HV")) { > + if (!g_ascii_strcasecmp(vm_type, "hv")) { > return 1; > } > > - if (!strcmp(vm_type, "PR")) { > + if (!g_ascii_strcasecmp(vm_type, "pr")) { > return 2; > } > > @@ -3132,16 +3132,6 @@ static char *spapr_get_kvm_type(Object *obj, > Error **errp) > { > SpaprMachineState *spapr = SPAPR_MACHINE(obj); > > - /* > - * In case the user didn't set 'kvm-type', return DEFAULT_KVM_TYPE > - * instead of NULL. This allows us to be more predictable with what > - * is expected to happen in spapr_kvm_type(), since we can stop relying > - * on receiving a 'NULL' parameter as a valid input there. > - */ > - if (!spapr->kvm_type) { > - return g_strdup(DEFAULT_KVM_TYPE); > - } > - > return g_strdup(spapr->kvm_type); > } > > @@ -3294,11 +3284,13 @@ static void spapr_instance_init(Object *obj) > > spapr->htab_fd = -1; > spapr->use_hotplug_event_source = true; > + > + spapr->kvm_type = g_strdup(DEFAULT_KVM_TYPE); > object_property_add_str(obj, "kvm-type", > spapr_get_kvm_type, spapr_set_kvm_type); > object_property_set_description(obj, "kvm-type", > - "Specifies the KVM virtualization > mode (HV, PR)." > - " If not specified, defaults to any > available KVM" > + "Specifies the KVM virtualization > mode (hv, pr, auto)." > + " auto is the default and allows > any available KVM" > " module loaded in the host. In > case both kvm_hv" > " and kvm_pr are loaded, kvm_hv > takes precedence."); >