From: David Gibson <david@gibson.dropbear.id.au>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, groug@kaod.org
Subject: Re: [PATCH v3 0/1] spapr.c: set a 'kvm-type' default value instead of relying on NULL
Date: Fri, 11 Dec 2020 11:21:05 +1100 [thread overview]
Message-ID: <20201211002105.GA4874@yekko.fritz.box> (raw)
In-Reply-To: <6d8cac99-68e1-61bf-e270-b0287b8d48fa@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1904 bytes --]
On Thu, Dec 10, 2020 at 05:51:41PM +0100, Paolo Bonzini wrote:
> On 10/12/20 15:55, Daniel Henrique Barboza wrote:
> > changes from v2, all proposed by Greg:
> > * Handle 'NULL' value as default mode fallback in spapr_kvm_type()
> > * Do not allow for 'AUTO' to be a valid mode in spapr_kvm_type()
> > * Initialize 'spapr->kvm_type' in spapr_instance_init() like Paolo
> > proposed. This will spare us from changing spapr_get_kvm_type()
> > altogether.
> > v2 link: https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg02623.html
> >
> >
> > This patch addresses an issue that happens with the pseries machine after
> > testing Paolo's patch [1]:
> >
> > $ sudo ./ppc64-softmmu/qemu-system-ppc64 -nographic -nodefaults -machine pseries --enable-kvm
> > qemu-system-ppc64: Unknown kvm-type specified ''
> >
> > The reason lies on how qemu_opt_get() and object_property_get_str() works
> > when there is no 'kvm-type' specified. We were conting on receiving NULL
> > for kvm-type, but the latter will use a blank string "". Instead on relying
> > on NULL, let's expose the already existing 'auto' kvm-type mode to the users
> > and use that as default.
> >
> > [1] https://lists.gnu.org/archive/html/qemu-devel/2020-12/msg00471.html
> >
> > Daniel Henrique Barboza (1):
> > spapr.c: set a 'kvm-type' default value instead of relying on NULL
> >
> > hw/ppc/spapr.c | 21 +++++++++++++++++----
> > 1 file changed, 17 insertions(+), 4 deletions(-)
> >
>
> Will queue, thanks!
I've also put it into my ppc-for-6.0 tree, which I plan to send a PR
for shortly. I guess it should be an easy conflict to resolve, so I
don't think that will be a problem.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-12-11 1:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-10 14:55 [PATCH v3 0/1] spapr.c: set a 'kvm-type' default value instead of relying on NULL Daniel Henrique Barboza
2020-12-10 14:55 ` [PATCH v3 1/1] " Daniel Henrique Barboza
2020-12-10 15:13 ` Greg Kurz
2020-12-10 16:51 ` [PATCH v3 0/1] " Paolo Bonzini
2020-12-11 0:21 ` David Gibson [this message]
2020-12-11 15:46 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211002105.GA4874@yekko.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=danielhb413@gmail.com \
--cc=groug@kaod.org \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.