From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 11 Dec 2020 14:04:59 +0000 Subject: Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add() Message-Id: <20201211140459.GR2767@kadam> List-Id: References: <20201211110157.GA527186@ravnborg.org> In-Reply-To: <20201211110157.GA527186@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Sam Ravnborg Cc: Neil Armstrong , David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding On Fri, Dec 11, 2020 at 12:01:57PM +0100, Sam Ravnborg wrote: > Hi Dan, > > I assume your nice tooling found this buggy. Yeah. Passing a valid pointer to PTR_ERR(). regards, dan carpenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C152EC433FE for ; Fri, 11 Dec 2020 14:05:27 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A04E23ECD for ; Fri, 11 Dec 2020 14:05:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A04E23ECD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A64B56EE0D; Fri, 11 Dec 2020 14:05:26 +0000 (UTC) Received: from aserp2120.oracle.com (aserp2120.oracle.com [141.146.126.78]) by gabe.freedesktop.org (Postfix) with ESMTPS id 292DF6EE0D for ; Fri, 11 Dec 2020 14:05:25 +0000 (UTC) Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BBDs8X4005083; Fri, 11 Dec 2020 14:05:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=M6pFORZ33vQuSMmmHvuKYfGD6U+3RAeesD2mMi7SKF0=; b=TerDr4e6DP7CPuqGfGeI7jdlmDocLqQgN5Q/IJeNdnp/CMJj1BTZdJXlFa/cCkCbVCzO zV2Xo30/bNl9tVS81cgk/QGP2WZR2nIvEiBP/07LnC7CEPA/fiVOxuTgpi8dNbufaXhG QjR4ZlUMJ2cAF9Z39FQj29Wd7h7hAQdIcxgSFIEl3cmtxvQrBGIiEyts7j46jfwXM8Mb REJHZmPTEh56XQY4X8QOmIu6kVV0P5wb8V5jOTtq6eirz892Q7GAorD5ZtqTa73upgQH 4YUvOVRflvEMxT8EK+xmzLL0S84IvPlvGY77f1FhDBG+oDx76nhLQxL0/8p709Fa96Ue XQ== Received: from userp3030.oracle.com (userp3030.oracle.com [156.151.31.80]) by aserp2120.oracle.com with ESMTP id 35825mjrjs-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 11 Dec 2020 14:05:17 +0000 Received: from pps.filterd (userp3030.oracle.com [127.0.0.1]) by userp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 0BBDtsAH072495; Fri, 11 Dec 2020 14:05:16 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3030.oracle.com with ESMTP id 358m53yedy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 11 Dec 2020 14:05:16 +0000 Received: from abhmp0018.oracle.com (abhmp0018.oracle.com [141.146.116.24]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 0BBE59k5024821; Fri, 11 Dec 2020 14:05:09 GMT Received: from kadam (/102.36.221.92) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 11 Dec 2020 06:05:09 -0800 Date: Fri, 11 Dec 2020 17:04:59 +0300 From: Dan Carpenter To: Sam Ravnborg Subject: Re: [PATCH] drm/panel: khadas: Fix error code in khadas_ts050_panel_add() Message-ID: <20201211140459.GR2767@kadam> References: <20201211110157.GA527186@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20201211110157.GA527186@ravnborg.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9831 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 suspectscore=0 bulkscore=0 malwarescore=0 phishscore=0 adultscore=0 mlxlogscore=852 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012110090 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9831 signatures=668683 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 adultscore=0 bulkscore=0 phishscore=0 mlxlogscore=882 clxscore=1015 priorityscore=1501 mlxscore=0 spamscore=0 lowpriorityscore=0 malwarescore=0 impostorscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2012110090 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Thierry Reding Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Fri, Dec 11, 2020 at 12:01:57PM +0100, Sam Ravnborg wrote: > Hi Dan, > > I assume your nice tooling found this buggy. Yeah. Passing a valid pointer to PTR_ERR(). regards, dan carpenter _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel