From: Lee Jones <lee.jones@linaro.org>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Zheng Yongjun <zhengyongjun3@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon
Date: Fri, 11 Dec 2020 14:45:53 +0000 [thread overview]
Message-ID: <20201211144553.GF5029@dell> (raw)
In-Reply-To: <10351cc41c244d9a8cfa6a8fb8f502c3@AcuMS.aculab.com>
On Fri, 11 Dec 2020, David Laight wrote:
> From: Lee Jones
> > Sent: 11 December 2020 13:11
> ...
> > > Nowt wrong with commas.
> >
> > Well you learn something new every day!
> >
> > > Why not go the other way.
> > > Convert almost all the ; to , and delete most of the { } in
> > > if and for statements (etc).
> >
> > Sorry, I don't understand. Please elaborate/provide an example.
>
> You can (largely) replace:
> if (...) {
> xxx;
> yyy;
> }
> zzz;
> With
> if (...)
> xxx,
> yyy;
> zzz;
>
> Saves a vertical line....
> You may need to replace some 'if' by ?: to avoid the terminating ;
No, please don't do any of that.
The current patch is fine.
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
prev parent reply other threads:[~2020-12-11 15:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 11:14 bikeshed: [PATCH -next] mfd: rave-sp: convert comma to semicolon David Laight
2020-12-11 13:10 ` Lee Jones
2020-12-11 13:15 ` David Laight
2020-12-11 14:45 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201211144553.GF5029@dell \
--to=lee.jones@linaro.org \
--cc=David.Laight@ACULAB.COM \
--cc=linux-kernel@vger.kernel.org \
--cc=zhengyongjun3@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.