From: Vinod Koul <vkoul@kernel.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Krishna Manikandan <mkrishn@codeaurora.org>,
linux-arm-msm@vger.kernel.org, kalyan_t@codeaurora.org,
tanmay@codeaurora.org, abhinavk@codeaurora.org,
robdclark@gmail.com, bjorn.andersson@linaro.org,
rnayak@codeaurora.org, dianders@chromium.org,
sibis@codeaurora.org
Subject: Re: [PATCH v9 1/2] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings
Date: Sat, 12 Dec 2020 14:49:15 +0530 [thread overview]
Message-ID: <20201212091915.GC8403@vkoul-mobl> (raw)
In-Reply-To: <160772823551.1580929.17011175154206191008@swboyd.mtv.corp.google.com>
On 11-12-20, 15:10, Stephen Boyd wrote:
> Quoting Krishna Manikandan (2020-12-10 23:09:44)
> > .../bindings/display/msm/dpu-sc7180.yaml | 235 +++++++++++++++++++
> > .../bindings/display/msm/dpu-sdm845.yaml | 216 ++++++++++++++++++
> > .../devicetree/bindings/display/msm/dpu.txt | 141 ------------
> > .../display/msm/dsi-common-controller.yaml | 235 +++++++++++++++++++
> > .../bindings/display/msm/dsi-controller-main.yaml | 119 ++++++++++
> > .../bindings/display/msm/dsi-phy-10nm.yaml | 64 ++++++
> > .../bindings/display/msm/dsi-phy-14nm.yaml | 64 ++++++
> > .../bindings/display/msm/dsi-phy-20nm.yaml | 68 ++++++
> > .../bindings/display/msm/dsi-phy-28nm.yaml | 64 ++++++
> > .../devicetree/bindings/display/msm/dsi-phy.yaml | 81 +++++++
> > .../devicetree/bindings/display/msm/dsi.txt | 249 ---------------------
> > 11 files changed, 1146 insertions(+), 390 deletions(-)
>
> This is quite a bit to review. Any chance to split it up into different
> patches? Looks like that could be: dpu, phy, and dsi to make this a bit
> more reviewable.
Yes that would certainly be very helpful for review.
Also I noticed that phy binding seem quite similar with few additions,
can we add a single binding document which documents .. or maybe check
with Rob.. what is the guidance, single doc or multiple..?
--
~Vinod
next prev parent reply other threads:[~2020-12-12 9:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 7:09 [PATCH v9 1/2] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings Krishna Manikandan
2020-12-11 7:09 ` [PATCH v9 2/2] dt-bindings: msm/dp: Add bindings of MSM DisplayPort controller Krishna Manikandan
2020-12-11 22:36 ` Stephen Boyd
2020-12-17 22:52 ` Tanmay Shah
2020-12-18 2:58 ` Stephen Boyd
2020-12-11 23:10 ` [PATCH v9 1/2] dt-bindings: msm: disp: add yaml schemas for DPU and DSI bindings Stephen Boyd
2020-12-12 9:19 ` Vinod Koul [this message]
2021-02-04 7:03 ` mkrishn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201212091915.GC8403@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=abhinavk@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=dianders@chromium.org \
--cc=kalyan_t@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=mkrishn@codeaurora.org \
--cc=rnayak@codeaurora.org \
--cc=robdclark@gmail.com \
--cc=sibis@codeaurora.org \
--cc=swboyd@chromium.org \
--cc=tanmay@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.