From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D258EC4361B for ; Sat, 12 Dec 2020 14:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 92F8E224DE for ; Sat, 12 Dec 2020 14:00:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2439133AbgLLOAk (ORCPT ); Sat, 12 Dec 2020 09:00:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:53562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2439135AbgLLOAj (ORCPT ); Sat, 12 Dec 2020 09:00:39 -0500 Date: Sat, 12 Dec 2020 15:59:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607781598; bh=W+S3uDjo9SUaklycr1VwLEkb3P+e5VKfy1opxSFjfP4=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=flXIgTj5QPdmF322uyfveGkWCvdiCUBTDqJEmaQAdBMU+9OnpTfe38HJDNJgc0lH8 G3M3nYjTvl4Jk0YTIcL5XhPPhChBAc7qxqYwpPq+/oyL9pin060A7R+FLePp8EI92r GwnqdckCsl6axBY1CL4fx8yH/moiz2Z+oLa3jsxNsEo1pT2EOLhqIregvSKc55N4Zj WuUAHrJAd8PgEDWlSYMQSNKmu4qJ1V3ZA+z2Yx8VyWB6hblUmlV0BHoIXeUaszFyMu HjV36aGN0+weJj3fLUwesb3uBHEoXTzG37NgAFnxayD4MEFDMvTjDeUmf4Kr35XObN Un6GIU6DTV1SA== From: Mike Rapoport To: John Hubbard Cc: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Wilcox , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Roman Gushchin , Shakeel Butt , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org Subject: Re: [PATCH v14 10/10] secretmem: test: add basic selftest for memfd_secret(2) Message-ID: <20201212135940.GD8946@kernel.org> References: <20201203062949.5484-1-rppt@kernel.org> <20201203062949.5484-11-rppt@kernel.org> <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> Precedence: bulk List-ID: X-Mailing-List: linux-api@vger.kernel.org Hi John, On Fri, Dec 11, 2020 at 10:16:23PM -0800, John Hubbard wrote: > On 12/2/20 10:29 PM, Mike Rapoport wrote: > > From: Mike Rapoport > ... > > +#include "../kselftest.h" > > + > > +#define fail(fmt, ...) ksft_test_result_fail(fmt, ##__VA_ARGS__) > > +#define pass(fmt, ...) ksft_test_result_pass(fmt, ##__VA_ARGS__) > > +#define skip(fmt, ...) ksft_test_result_skip(fmt, ##__VA_ARGS__) > > + > > +#ifdef __NR_memfd_secret > > + > > +#include > > Hi Mike, > > Say, when I tried this out from today's linux-next, I had to delete the > above line. In other words, the following was required in order to build: > > diff --git a/tools/testing/selftests/vm/memfd_secret.c b/tools/testing/selftests/vm/memfd_secret.c > index 79578dfd13e6..c878c2b841fc 100644 > --- a/tools/testing/selftests/vm/memfd_secret.c > +++ b/tools/testing/selftests/vm/memfd_secret.c > @@ -29,8 +29,6 @@ > > #ifdef __NR_memfd_secret > > -#include > - > #define PATTERN 0x55 > > static const int prot = PROT_READ | PROT_WRITE; > > > ...and that makes sense to me, because: > > a) secretmem.h is not in the uapi, which this selftests/vm build system > expects (it runs "make headers_install" for us, which is *not* going > to pick up items in the kernel include dirs), and > > b) There is nothing in secretmem.h that this test uses, anyway! Just these: > > bool vma_is_secretmem(struct vm_area_struct *vma); > bool page_is_secretmem(struct page *page); > bool secretmem_active(void); > > > ...or am I just Doing It Wrong? :) You are perfectly right, I had a stale header in uapi from the prevoius versions, the include in the test remained from then. @Andrew, can you please add the hunk above as a fixup? > thanks, > -- > John Hubbard > NVIDIA -- Sincerely yours, Mike. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D33F8C433FE for ; Sat, 12 Dec 2020 14:00:02 +0000 (UTC) Received: from ml01.01.org (ml01.01.org [198.145.21.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28AB1224D1 for ; Sat, 12 Dec 2020 14:00:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28AB1224D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvdimm-bounces@lists.01.org Received: from ml01.vlan13.01.org (localhost [IPv6:::1]) by ml01.01.org (Postfix) with ESMTP id 8D003100EBBDC; Sat, 12 Dec 2020 06:00:01 -0800 (PST) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.145.29.99; helo=mail.kernel.org; envelope-from=rppt@kernel.org; receiver= Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 39FAF100ED490 for ; Sat, 12 Dec 2020 05:59:59 -0800 (PST) Date: Sat, 12 Dec 2020 15:59:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607781598; bh=W+S3uDjo9SUaklycr1VwLEkb3P+e5VKfy1opxSFjfP4=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=flXIgTj5QPdmF322uyfveGkWCvdiCUBTDqJEmaQAdBMU+9OnpTfe38HJDNJgc0lH8 G3M3nYjTvl4Jk0YTIcL5XhPPhChBAc7qxqYwpPq+/oyL9pin060A7R+FLePp8EI92r GwnqdckCsl6axBY1CL4fx8yH/moiz2Z+oLa3jsxNsEo1pT2EOLhqIregvSKc55N4Zj WuUAHrJAd8PgEDWlSYMQSNKmu4qJ1V3ZA+z2Yx8VyWB6hblUmlV0BHoIXeUaszFyMu HjV36aGN0+weJj3fLUwesb3uBHEoXTzG37NgAFnxayD4MEFDMvTjDeUmf4Kr35XObN Un6GIU6DTV1SA== From: Mike Rapoport To: John Hubbard Subject: Re: [PATCH v14 10/10] secretmem: test: add basic selftest for memfd_secret(2) Message-ID: <20201212135940.GD8946@kernel.org> References: <20201203062949.5484-1-rppt@kernel.org> <20201203062949.5484-11-rppt@kernel.org> <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> Message-ID-Hash: ZJSOAJXB2KFC2NJV43O33A23UP3IB4O4 X-Message-ID-Hash: ZJSOAJXB2KFC2NJV43O33A23UP3IB4O4 X-MailFrom: rppt@kernel.org X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation CC: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dave Hansen , David Hildenbrand , Elena Reshetova , "H. Peter Anvin" , Ingo Molnar , James Bottomley , "Kirill A. Shutemov" , Matthew Wilcox , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , Rick Edgecombe , Roman Gushchin , Shakeel Butt , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org X-Mailman-Version: 3.1.1 Precedence: list List-Id: "Linux-nvdimm developer list." Archived-At: List-Archive: List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hi John, On Fri, Dec 11, 2020 at 10:16:23PM -0800, John Hubbard wrote: > On 12/2/20 10:29 PM, Mike Rapoport wrote: > > From: Mike Rapoport > ... > > +#include "../kselftest.h" > > + > > +#define fail(fmt, ...) ksft_test_result_fail(fmt, ##__VA_ARGS__) > > +#define pass(fmt, ...) ksft_test_result_pass(fmt, ##__VA_ARGS__) > > +#define skip(fmt, ...) ksft_test_result_skip(fmt, ##__VA_ARGS__) > > + > > +#ifdef __NR_memfd_secret > > + > > +#include > > Hi Mike, > > Say, when I tried this out from today's linux-next, I had to delete the > above line. In other words, the following was required in order to build: > > diff --git a/tools/testing/selftests/vm/memfd_secret.c b/tools/testing/selftests/vm/memfd_secret.c > index 79578dfd13e6..c878c2b841fc 100644 > --- a/tools/testing/selftests/vm/memfd_secret.c > +++ b/tools/testing/selftests/vm/memfd_secret.c > @@ -29,8 +29,6 @@ > > #ifdef __NR_memfd_secret > > -#include > - > #define PATTERN 0x55 > > static const int prot = PROT_READ | PROT_WRITE; > > > ...and that makes sense to me, because: > > a) secretmem.h is not in the uapi, which this selftests/vm build system > expects (it runs "make headers_install" for us, which is *not* going > to pick up items in the kernel include dirs), and > > b) There is nothing in secretmem.h that this test uses, anyway! Just these: > > bool vma_is_secretmem(struct vm_area_struct *vma); > bool page_is_secretmem(struct page *page); > bool secretmem_active(void); > > > ...or am I just Doing It Wrong? :) You are perfectly right, I had a stale header in uapi from the prevoius versions, the include in the test remained from then. @Andrew, can you please add the hunk above as a fixup? > thanks, > -- > John Hubbard > NVIDIA -- Sincerely yours, Mike. _______________________________________________ Linux-nvdimm mailing list -- linux-nvdimm@lists.01.org To unsubscribe send an email to linux-nvdimm-leave@lists.01.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C8299C433FE for ; Sat, 12 Dec 2020 14:00:20 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4F486224DE for ; Sat, 12 Dec 2020 14:00:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F486224DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NVd95bIQSgNnL9DMUFF+pTgUCUEp94l+OnPcJ79Xf9c=; b=AKKJ4BVPhB8NH4aQ/aM51Ed8d /MtBTxRUw8BsgIBn5Ox1ha8nm7wC/SwnFViur4EAOj+q5MsXOrqEz/j3WxJ8VYffS5ZsbrjKN4wu8 pHOPWkV4ND2JFzciuJJqZ9zepKa/zDYvg3JtEy7saEK60N3HfSeUVgiOAFlOIdPEKjftMGgRFrHu6 8uA5/TSQucHnMS76IMd+6HOf/fg3l0SjVKDofvge8zhNVruVJHwxMsCefOchAejd2+j4epUklPUza PXmE/mVzufd2z7aF8W7eSRiFANPoMJmd1CEQTT5l2mV0y1ZMcl/m+d58R86lIGwzJp+c0GFJRShXQ HtR+49TMA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ko5RR-0004v9-Qg; Sat, 12 Dec 2020 14:00:09 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ko5RN-0004sK-HI; Sat, 12 Dec 2020 14:00:06 +0000 Date: Sat, 12 Dec 2020 15:59:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607781598; bh=W+S3uDjo9SUaklycr1VwLEkb3P+e5VKfy1opxSFjfP4=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=flXIgTj5QPdmF322uyfveGkWCvdiCUBTDqJEmaQAdBMU+9OnpTfe38HJDNJgc0lH8 G3M3nYjTvl4Jk0YTIcL5XhPPhChBAc7qxqYwpPq+/oyL9pin060A7R+FLePp8EI92r GwnqdckCsl6axBY1CL4fx8yH/moiz2Z+oLa3jsxNsEo1pT2EOLhqIregvSKc55N4Zj WuUAHrJAd8PgEDWlSYMQSNKmu4qJ1V3ZA+z2Yx8VyWB6hblUmlV0BHoIXeUaszFyMu HjV36aGN0+weJj3fLUwesb3uBHEoXTzG37NgAFnxayD4MEFDMvTjDeUmf4Kr35XObN Un6GIU6DTV1SA== From: Mike Rapoport To: John Hubbard Subject: Re: [PATCH v14 10/10] secretmem: test: add basic selftest for memfd_secret(2) Message-ID: <20201212135940.GD8946@kernel.org> References: <20201203062949.5484-1-rppt@kernel.org> <20201203062949.5484-11-rppt@kernel.org> <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201212_090005_821305_E1F8C5DE X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, "H. Peter Anvin" , Christopher Lameter , Shuah Khan , Thomas Gleixner , Elena Reshetova , linux-arch@vger.kernel.org, Tycho Andersen , linux-nvdimm@lists.01.org, Will Deacon , x86@kernel.org, Matthew Wilcox , Mike Rapoport , Ingo Molnar , Michael Kerrisk , Arnd Bergmann , James Bottomley , Borislav Petkov , Alexander Viro , Andy Lutomirski , Paul Walmsley , "Kirill A. Shutemov" , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-fsdevel@vger.kernel.org, Shakeel Butt , Andrew Morton , Rick Edgecombe , Roman Gushchin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Hi John, On Fri, Dec 11, 2020 at 10:16:23PM -0800, John Hubbard wrote: > On 12/2/20 10:29 PM, Mike Rapoport wrote: > > From: Mike Rapoport > ... > > +#include "../kselftest.h" > > + > > +#define fail(fmt, ...) ksft_test_result_fail(fmt, ##__VA_ARGS__) > > +#define pass(fmt, ...) ksft_test_result_pass(fmt, ##__VA_ARGS__) > > +#define skip(fmt, ...) ksft_test_result_skip(fmt, ##__VA_ARGS__) > > + > > +#ifdef __NR_memfd_secret > > + > > +#include > > Hi Mike, > > Say, when I tried this out from today's linux-next, I had to delete the > above line. In other words, the following was required in order to build: > > diff --git a/tools/testing/selftests/vm/memfd_secret.c b/tools/testing/selftests/vm/memfd_secret.c > index 79578dfd13e6..c878c2b841fc 100644 > --- a/tools/testing/selftests/vm/memfd_secret.c > +++ b/tools/testing/selftests/vm/memfd_secret.c > @@ -29,8 +29,6 @@ > > #ifdef __NR_memfd_secret > > -#include > - > #define PATTERN 0x55 > > static const int prot = PROT_READ | PROT_WRITE; > > > ...and that makes sense to me, because: > > a) secretmem.h is not in the uapi, which this selftests/vm build system > expects (it runs "make headers_install" for us, which is *not* going > to pick up items in the kernel include dirs), and > > b) There is nothing in secretmem.h that this test uses, anyway! Just these: > > bool vma_is_secretmem(struct vm_area_struct *vma); > bool page_is_secretmem(struct page *page); > bool secretmem_active(void); > > > ...or am I just Doing It Wrong? :) You are perfectly right, I had a stale header in uapi from the prevoius versions, the include in the test remained from then. @Andrew, can you please add the hunk above as a fixup? > thanks, > -- > John Hubbard > NVIDIA -- Sincerely yours, Mike. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76674C4361B for ; Sat, 12 Dec 2020 14:01:31 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28FB5224DE for ; Sat, 12 Dec 2020 14:01:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 28FB5224DE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References:Message-ID: Subject:To:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=5azLCM/j7S916A63NMnu1NgTiAHg5XKEMI3l2il/UFI=; b=HMYzBqBfzga95zzjNaQYQZpfw lv9vMcavbSxeOEXEFgu1K+Tc39SR8CjukRnf9nUyvm4VbQV8oU9Rlj8mWkMyqrDH/Zqxz87tpsHem bKfUVfNktfqj49AUZCc/lI2mPF6gAAZJCduzk0SVqqJKQNsz5U4ZjOEK4RcuY1W685ChTnA8vrwOo bITV/ltedlp9eRSOiL6LV8NJYcsXXcm09uugpqD+ngD4StdtP5YLhZSJIJ/WVTrpMyEGO1w0+AHRR wfSBW68kIZvyVX70h0zbb7QgqQPmqDnPoIaNdWeiuj5A7cP0YAGX1WbzwmhUc+RQvQvue297/1Lwa 3adPd/sVw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ko5RQ-0004uw-Fs; Sat, 12 Dec 2020 14:00:08 +0000 Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ko5RN-0004sK-HI; Sat, 12 Dec 2020 14:00:06 +0000 Date: Sat, 12 Dec 2020 15:59:40 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1607781598; bh=W+S3uDjo9SUaklycr1VwLEkb3P+e5VKfy1opxSFjfP4=; h=From:To:Cc:Subject:References:In-Reply-To:From; b=flXIgTj5QPdmF322uyfveGkWCvdiCUBTDqJEmaQAdBMU+9OnpTfe38HJDNJgc0lH8 G3M3nYjTvl4Jk0YTIcL5XhPPhChBAc7qxqYwpPq+/oyL9pin060A7R+FLePp8EI92r GwnqdckCsl6axBY1CL4fx8yH/moiz2Z+oLa3jsxNsEo1pT2EOLhqIregvSKc55N4Zj WuUAHrJAd8PgEDWlSYMQSNKmu4qJ1V3ZA+z2Yx8VyWB6hblUmlV0BHoIXeUaszFyMu HjV36aGN0+weJj3fLUwesb3uBHEoXTzG37NgAFnxayD4MEFDMvTjDeUmf4Kr35XObN Un6GIU6DTV1SA== From: Mike Rapoport To: John Hubbard Subject: Re: [PATCH v14 10/10] secretmem: test: add basic selftest for memfd_secret(2) Message-ID: <20201212135940.GD8946@kernel.org> References: <20201203062949.5484-1-rppt@kernel.org> <20201203062949.5484-11-rppt@kernel.org> <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <248f928b-1383-48ea-8584-ec10146e60c9@nvidia.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201212_090005_821305_E1F8C5DE X-CRM114-Status: GOOD ( 17.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , David Hildenbrand , Peter Zijlstra , Catalin Marinas , Dave Hansen , linux-mm@kvack.org, linux-kselftest@vger.kernel.org, "H. Peter Anvin" , Christopher Lameter , Shuah Khan , Thomas Gleixner , Elena Reshetova , linux-arch@vger.kernel.org, Tycho Andersen , linux-nvdimm@lists.01.org, Will Deacon , x86@kernel.org, Matthew Wilcox , Mike Rapoport , Ingo Molnar , Michael Kerrisk , Arnd Bergmann , James Bottomley , Borislav Petkov , Alexander Viro , Andy Lutomirski , Paul Walmsley , "Kirill A. Shutemov" , Dan Williams , linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, Palmer Dabbelt , linux-fsdevel@vger.kernel.org, Shakeel Butt , Andrew Morton , Rick Edgecombe , Roman Gushchin Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi John, On Fri, Dec 11, 2020 at 10:16:23PM -0800, John Hubbard wrote: > On 12/2/20 10:29 PM, Mike Rapoport wrote: > > From: Mike Rapoport > ... > > +#include "../kselftest.h" > > + > > +#define fail(fmt, ...) ksft_test_result_fail(fmt, ##__VA_ARGS__) > > +#define pass(fmt, ...) ksft_test_result_pass(fmt, ##__VA_ARGS__) > > +#define skip(fmt, ...) ksft_test_result_skip(fmt, ##__VA_ARGS__) > > + > > +#ifdef __NR_memfd_secret > > + > > +#include > > Hi Mike, > > Say, when I tried this out from today's linux-next, I had to delete the > above line. In other words, the following was required in order to build: > > diff --git a/tools/testing/selftests/vm/memfd_secret.c b/tools/testing/selftests/vm/memfd_secret.c > index 79578dfd13e6..c878c2b841fc 100644 > --- a/tools/testing/selftests/vm/memfd_secret.c > +++ b/tools/testing/selftests/vm/memfd_secret.c > @@ -29,8 +29,6 @@ > > #ifdef __NR_memfd_secret > > -#include > - > #define PATTERN 0x55 > > static const int prot = PROT_READ | PROT_WRITE; > > > ...and that makes sense to me, because: > > a) secretmem.h is not in the uapi, which this selftests/vm build system > expects (it runs "make headers_install" for us, which is *not* going > to pick up items in the kernel include dirs), and > > b) There is nothing in secretmem.h that this test uses, anyway! Just these: > > bool vma_is_secretmem(struct vm_area_struct *vma); > bool page_is_secretmem(struct page *page); > bool secretmem_active(void); > > > ...or am I just Doing It Wrong? :) You are perfectly right, I had a stale header in uapi from the prevoius versions, the include in the test remained from then. @Andrew, can you please add the hunk above as a fixup? > thanks, > -- > John Hubbard > NVIDIA -- Sincerely yours, Mike. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel